Skip to content

Commit 9f19166

Browse files
author
DavidQ
committed
Clean up Object Vector Studio V2 control layout, shape selection, palette, preview, and JSON copy behavior - PR_26132_018-object-vector-studio-v2-control-layout-cleanup
1 parent 2679cb7 commit 9f19166

8 files changed

Lines changed: 450 additions & 265 deletions

File tree

docs/dev/reports/playwright_v8_coverage.txt

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,7 @@ Exercised tool entry points detected:
2222
Changed runtime JS files covered:
2323
(80%) tools/object-vector-studio-v2/js/bootstrap.js - executed lines 101/101; executed functions 4/5
2424
(91%) tools/object-vector-studio-v2/js/controls/ActionNavControl.js - executed lines 78/78; executed functions 10/11
25-
(92%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 2862/2862; executed functions 328/356
26-
(95%) tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js - executed lines 406/406; executed functions 52/55
27-
(98%) src/engine/rendering/ObjectVectorRuntimeAssetService.js - executed lines 919/919; executed functions 105/107
25+
(91%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 2879/2879; executed functions 334/366
2826

2927
Files with executed line/function counts where available:
3028
(2%) src/engine/input/ActionInputService.js - executed lines 397/397; executed functions 1/51
@@ -200,10 +198,10 @@ Files with executed line/function counts where available:
200198
(90%) tools/text2speech-V2/js/controls/ActionNavControl.js - executed lines 117/117; executed functions 19/21
201199
(90%) tools/text2speech-V2/js/TextToSpeechToolApp.js - executed lines 807/807; executed functions 62/69
202200
(91%) tools/object-vector-studio-v2/js/controls/ActionNavControl.js - executed lines 78/78; executed functions 10/11
201+
(91%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 2879/2879; executed functions 334/366
203202
(91%) tools/toolRegistry.js - executed lines 526/526; executed functions 10/11
204203
(91%) tools/workspace-manager-v2/js/services/WorkspaceManagerV2ContextService.js - executed lines 1598/1598; executed functions 145/159
205204
(92%) tools/object-vector-studio-v2/js/controls/ToolStarterShellControl.js - executed lines 112/112; executed functions 11/12
206-
(92%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 2862/2862; executed functions 328/356
207205
(93%) tools/asset-manager-v2/js/services/WorkspaceBridge.js - executed lines 305/305; executed functions 25/27
208206
(93%) tools/session-inspector-v2/js/SessionInspectorV2App.js - executed lines 337/337; executed functions 42/45
209207
(93%) tools/text2speech-V2/js/controls/QueueControl.js - executed lines 122/122; executed functions 26/28
@@ -296,10 +294,7 @@ Uncovered or low-coverage changed JS files:
296294

297295
Changed JS files considered:
298296
(0%) tests/playwright/tools/WorkspaceManagerV2.spec.mjs - changed JS file not collected as browser runtime coverage
299-
(50%) games/Asteroids/index.js - changed JS file with browser V8 coverage
300-
(52%) games/Asteroids/game/AsteroidsGameScene.js - changed JS file with browser V8 coverage
297+
(0%) tools/object-vector-studio-v2/tests/playwright/FirstClassToolStarter.spec.mjs - changed JS file not collected as browser runtime coverage
301298
(80%) tools/object-vector-studio-v2/js/bootstrap.js - changed JS file with browser V8 coverage
302299
(91%) tools/object-vector-studio-v2/js/controls/ActionNavControl.js - changed JS file with browser V8 coverage
303-
(92%) tools/object-vector-studio-v2/js/ToolStarterApp.js - changed JS file with browser V8 coverage
304-
(95%) tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js - changed JS file with browser V8 coverage
305-
(98%) src/engine/rendering/ObjectVectorRuntimeAssetService.js - changed JS file with browser V8 coverage
300+
(91%) tools/object-vector-studio-v2/js/ToolStarterApp.js - changed JS file with browser V8 coverage
Lines changed: 79 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,79 @@
1+
# PR_26132_018-object-vector-studio-v2-control-layout-cleanup
2+
3+
## Scope
4+
5+
Updates Object Vector Studio V2 UI layout only. No schema changes, no sample JSON changes, and no new feature systems.
6+
7+
## Changes
8+
9+
- Reduced stacked accordion spacing and kept removed useful help/status text in Status Log.
10+
- Moved Shape/Tools to the top of the right column, removed its visible hint paragraph, kept its content scrollable, and made tool buttons square.
11+
- Moved Words/Icons beside Grid and preserved icon mode for preview/frame action buttons.
12+
- Added a selectable shape list inside Object Details for the selected object.
13+
- Moved Object Details under Object in the left column and moved object/shape counts into the Object Details header.
14+
- Moved Dependency Graph into its own right-column accordion.
15+
- Reworked Palette as an accordion with Paint, Stroke, Current Color, Stroke Width, header swatch count, square swatches, and internal scrolling.
16+
- Moved Object Preview coordinate/status text into the Object Preview header and removed the old visible selection/render summary blocks.
17+
- Added Copy JSON inside JSON Details without changing accordion open/closed state.
18+
19+
## Validation
20+
21+
Playwright impacted: Yes.
22+
23+
Commands run:
24+
25+
- `node --check tools/object-vector-studio-v2/js/ToolStarterApp.js`
26+
- `node --check tools/object-vector-studio-v2/js/bootstrap.js`
27+
- `node --check tests/playwright/tools/WorkspaceManagerV2.spec.mjs`
28+
- `node --check tools/object-vector-studio-v2/tests/playwright/FirstClassToolStarter.spec.mjs`
29+
- `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --grep "Object Vector Studio V2" --reporter=list`
30+
- `npm run test:workspace-v2`
31+
32+
Result:
33+
34+
- Targeted Object Vector Studio V2 validation passed: 6 passed.
35+
- Full Workspace Manager V2 suite passed: 45 passed.
36+
- Playwright V8 coverage generated at `docs/dev/reports/playwright_v8_coverage.txt`.
37+
- Full samples smoke test skipped per request; this PR only changes Object Vector Studio V2 UI layout and workspace-v2 coverage validates the impacted surface.
38+
39+
## Playwright Coverage
40+
41+
Validates:
42+
43+
- Shape/Tools is in the right column.
44+
- Object Details is under Object in the left column.
45+
- Words/Icons is beside Grid.
46+
- Shape/tool buttons are square.
47+
- Object tiles do not overlap on load.
48+
- Shapes inside the selected object can be selected from the new shape list.
49+
- JSON Details Copy JSON preserves accordion state.
50+
- Removed useful status/help text appears in Status Log.
51+
52+
Expected pass behavior:
53+
54+
- Layout controls move to the requested columns, compact content scrolls internally, selectable shape rows are clickable, and JSON copy does not toggle the accordion.
55+
56+
Expected fail behavior:
57+
58+
- Invalid payloads, missing payloads, missing palette, or missing selected object still log visible/actionable failures and block invalid rendering or mutations.
59+
60+
## Manual Validation
61+
62+
1. Open `tools/object-vector-studio-v2/index.html`.
63+
2. Confirm left column order: Object, Object Details, Objects.
64+
3. Confirm right column order: Shape/Tools, Palette, JSON Details, Dependency Graph, Status Log.
65+
4. Load a valid Object Vector payload with a runtime palette.
66+
5. Create multiple shapes, then select shapes from the Object Details shape list.
67+
6. Confirm Paint/Stroke, Current Color, Stroke Width, and palette swatches sit at the top of Palette.
68+
7. Click JSON Details `Copy JSON` and confirm the accordion stays open.
69+
70+
Expected outcome:
71+
72+
- Object Vector Studio V2 has tighter accordions, usable right-column Shape/Tools, non-overlapping object tiles, clickable shape selection, palette controls at the top, and stable JSON copy behavior.
73+
74+
## Out Of Scope
75+
76+
- No schema changes.
77+
- No sample JSON changes.
78+
- No new feature systems.
79+
- No full samples smoke test.

0 commit comments

Comments
 (0)