Skip to content

Commit ad0737b

Browse files
author
DavidQ
committed
Remove engine domain index barrel exports phase 1 - PR_26140_067-remove-engine-domain-index-barrels-phase1
1 parent 6b71e83 commit ad0737b

572 files changed

Lines changed: 1465 additions & 843 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Lines changed: 55 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
1+
# PR_26140_067 Engine Domain Index Barrel Removal Phase 1
2+
3+
## Summary
4+
- Removed the targeted engine domain barrel files:
5+
- `src/engine/camera/index.js`
6+
- `src/engine/collision/index.js`
7+
- `src/engine/input/index.js`
8+
- `src/engine/theme/index.js`
9+
- Replaced active imports and re-exports from those barrels with direct canonical file imports.
10+
- Kept scope to import/export wiring only; no runtime logic, sample JSON, or entry file removal was changed.
11+
- Applied the user's scope clarification for import-only edits in `games/Asteroids/index.js`, `samples/**/index.js`, `src/engine/core/Engine.js`, and `src/engine/core/index.js`.
12+
13+
## Direct Import Mapping
14+
- Camera:
15+
- `Camera2D` -> `src/engine/camera/Camera2D.js`
16+
- `Camera3D` -> `src/engine/camera/Camera3D.js`
17+
- `followCameraTarget`, `worldRectToScreen` -> `src/engine/camera/CameraSystem.js`
18+
- `updateZoneCamera` -> `src/engine/camera/ZoneCameraSystem.js`
19+
- Collision:
20+
- AABB helpers -> `src/engine/collision/aabb.js`
21+
- polygon helpers -> `src/engine/collision/polygon.js`
22+
- raster helpers -> `src/engine/collision/raster.js`
23+
- hybrid helpers -> `src/engine/collision/hybrid.js`
24+
- Object Vector collision helpers -> `src/engine/collision/objectVector.js`
25+
- Input:
26+
- input services/maps/adapters -> their one-class files under `src/engine/input/`
27+
- `drawActionInputDebugOverlay` -> `src/engine/input/ActionInputDebugOverlay.js`
28+
- Theme:
29+
- header helpers -> `src/engine/theme/toolboxaid-header.js`
30+
- `Theme` -> `src/engine/theme/Theme.js`
31+
- `ThemeTokens` -> `src/engine/theme/ThemeTokens.js`
32+
33+
## Validation
34+
- PASS: target barrel scan reports `remaining targeted barrel imports/exports: 0`.
35+
- PASS: target deletion scan reports `deleted targeted index files: 4/4`.
36+
- PASS: no JSON files changed.
37+
- PASS: `node --check` passed for 567 changed existing JS/MJS files.
38+
- PASS: local import target validation passed for 567 changed existing JS/MJS files.
39+
- PASS: `npm run test:workspace-v2` passed 59/59 tests.
40+
- PASS: targeted affected engine/final tests passed:
41+
- `tests/core/Engine2DCapabilityCombinedFoundation.test.mjs`
42+
- `tests/core/Engine3DPhysicsHookIsolation.test.mjs`
43+
- `tests/core/EngineCoreBoundaryBaseline.test.mjs`
44+
- `tests/core/EngineSceneLifecycle.test.mjs`
45+
- `tests/core/Section1FinalResidueStructure.test.mjs`
46+
- `tests/final/PlatformUxSystems.test.mjs`
47+
- `tests/final/PrecisionCollisionSystems.test.mjs`
48+
- PASS: `npm run test:launch-smoke:games` passed 12/12 game entries.
49+
- PASS: `git diff --check` exited 0. Git emitted advisory line-ending warnings for touched test `.mjs` files only.
50+
- INFO: extra `npm test` was attempted as a broader engine check; it stopped on an existing unrelated missing import, `games/Asteroids/game/FullscreenBezelOverlay.js`, from `tests/games/FullscreenBezelOverlay.test.mjs`.
51+
- SKIPPED: full samples smoke test, per PR instruction.
52+
53+
## Side Effects Cleaned
54+
- `npm run test:launch-smoke:games` created `tmp/node_modules`; it was removed after validation so `tmp/` is reserved for the final delta ZIP.
55+
- `docs/dev/reports/launch_smoke_report.md` was restored to its pre-validation content and is not part of this PR.

games/AITargetDummy/game/AITargetDummyInputController.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ David Quesenberry
44
03/25/2026
55
AITargetDummyInputController.js
66
*/
7-
import { GamepadInputAdapter } from '/src/engine/input/index.js';
7+
import GamepadInputAdapter from '/src/engine/input/GamepadInputAdapter.js';
88
import { clamp } from '/src/shared/math/scalars.js';
99

1010
export default class AITargetDummyInputController {

games/AITargetDummy/main.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,9 @@ David Quesenberry
55
main.js
66
*/
77
import Engine from '/src/engine/core/Engine.js';
8-
import { InputService } from '/src/engine/input/index.js';
9-
import { Theme, ThemeTokens } from '/src/engine/theme/index.js';
8+
import InputService from '/src/engine/input/InputService.js';
9+
import { Theme } from '/src/engine/theme/Theme.js';
10+
import { ThemeTokens } from '/src/engine/theme/ThemeTokens.js';
1011
import AITargetDummyScene from './game/AITargetDummyScene.js';
1112

1213
const theme = new Theme(ThemeTokens);

games/Asteroids/entities/Asteroid.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ David Quesenberry
55
Asteroid.js
66
*/
77
import { TAU, randomRange, wrap } from '/src/shared/math/scalars.js';
8-
import { transformCollisionPoints } from '/src/engine/collision/index.js';
8+
import { transformCollisionPoints } from '/src/engine/collision/objectVector.js';
99

1010
const SIZE_PROFILES = {
1111
SML: { id: 1 },

games/Asteroids/entities/Bullet.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ David Quesenberry
55
Bullet.js
66
*/
77
import { wrap } from '/src/shared/math/scalars.js';
8-
import { transformCollisionPoints } from '/src/engine/collision/index.js';
8+
import { transformCollisionPoints } from '/src/engine/collision/objectVector.js';
99
import { normalizePoints } from '/src/shared/math/geometry.js';
1010

1111
export default class Bullet {

games/Asteroids/entities/Ship.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ David Quesenberry
55
Ship.js
66
*/
77
import { wrap } from '/src/shared/math/scalars.js';
8-
import { transformCollisionPoints } from '/src/engine/collision/index.js';
8+
import { transformCollisionPoints } from '/src/engine/collision/objectVector.js';
99
import { normalizePoints } from '/src/shared/math/geometry.js';
1010

1111
export default class Ship {

games/Asteroids/entities/Ufo.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ Ufo.js
77
import Bullet from './Bullet.js';
88
import { distance, randomRange } from '/src/shared/math/scalars.js';
99
import { normalizePoints } from '/src/shared/math/geometry.js';
10-
import { transformCollisionPoints } from '/src/engine/collision/index.js';
10+
import { transformCollisionPoints } from '/src/engine/collision/objectVector.js';
1111

1212
const UFO_PROFILES = {
1313
large: {

games/Asteroids/game/AsteroidsWorld.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import Asteroid from '../entities/Asteroid.js';
88
import Bullet from '../entities/Bullet.js';
99
import Ship from '../entities/Ship.js';
1010
import Ufo from '../entities/Ufo.js';
11-
import { arePolygonsColliding } from '/src/engine/collision/index.js';
11+
import { arePolygonsColliding } from '/src/engine/collision/polygon.js';
1212
import { distance, randomRange } from '/src/shared/math/scalars.js';
1313
import { sanitizeFiniteNumber, sanitizePositiveNumber } from '/src/shared/math/numberNormalization.js';
1414
import {

games/Asteroids/game/asteroidObjectGeometry.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import {
22
ASTEROIDS_ASTEROID_SIZE_OBJECT_IDS,
33
} from './asteroidsObjectGeometryManifest.js';
4-
import { getObjectVectorCollisionOutlinePoints } from '/src/engine/collision/index.js';
4+
import { getObjectVectorCollisionOutlinePoints } from '/src/engine/collision/objectVector.js';
55
import { asArray } from '/src/shared/array/arrays.js';
66
import { centerPoints, maxRadius } from '/src/shared/math/geometry.js';
77

games/Asteroids/game/asteroidsObjectGeometryManifest.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { getObjectVectorCollisionOutlinePoints } from '/src/engine/collision/index.js';
1+
import { getObjectVectorCollisionOutlinePoints } from '/src/engine/collision/objectVector.js';
22
import { isRecord } from '/src/shared/object/objects.js';
33
import { deepClone } from '/src/shared/json/clone.js';
44

0 commit comments

Comments
 (0)