|
| 1 | +# PR_26140_067 Engine Domain Index Barrel Removal Phase 1 |
| 2 | + |
| 3 | +## Summary |
| 4 | +- Removed the targeted engine domain barrel files: |
| 5 | + - `src/engine/camera/index.js` |
| 6 | + - `src/engine/collision/index.js` |
| 7 | + - `src/engine/input/index.js` |
| 8 | + - `src/engine/theme/index.js` |
| 9 | +- Replaced active imports and re-exports from those barrels with direct canonical file imports. |
| 10 | +- Kept scope to import/export wiring only; no runtime logic, sample JSON, or entry file removal was changed. |
| 11 | +- Applied the user's scope clarification for import-only edits in `games/Asteroids/index.js`, `samples/**/index.js`, `src/engine/core/Engine.js`, and `src/engine/core/index.js`. |
| 12 | + |
| 13 | +## Direct Import Mapping |
| 14 | +- Camera: |
| 15 | + - `Camera2D` -> `src/engine/camera/Camera2D.js` |
| 16 | + - `Camera3D` -> `src/engine/camera/Camera3D.js` |
| 17 | + - `followCameraTarget`, `worldRectToScreen` -> `src/engine/camera/CameraSystem.js` |
| 18 | + - `updateZoneCamera` -> `src/engine/camera/ZoneCameraSystem.js` |
| 19 | +- Collision: |
| 20 | + - AABB helpers -> `src/engine/collision/aabb.js` |
| 21 | + - polygon helpers -> `src/engine/collision/polygon.js` |
| 22 | + - raster helpers -> `src/engine/collision/raster.js` |
| 23 | + - hybrid helpers -> `src/engine/collision/hybrid.js` |
| 24 | + - Object Vector collision helpers -> `src/engine/collision/objectVector.js` |
| 25 | +- Input: |
| 26 | + - input services/maps/adapters -> their one-class files under `src/engine/input/` |
| 27 | + - `drawActionInputDebugOverlay` -> `src/engine/input/ActionInputDebugOverlay.js` |
| 28 | +- Theme: |
| 29 | + - header helpers -> `src/engine/theme/toolboxaid-header.js` |
| 30 | + - `Theme` -> `src/engine/theme/Theme.js` |
| 31 | + - `ThemeTokens` -> `src/engine/theme/ThemeTokens.js` |
| 32 | + |
| 33 | +## Validation |
| 34 | +- PASS: target barrel scan reports `remaining targeted barrel imports/exports: 0`. |
| 35 | +- PASS: target deletion scan reports `deleted targeted index files: 4/4`. |
| 36 | +- PASS: no JSON files changed. |
| 37 | +- PASS: `node --check` passed for 567 changed existing JS/MJS files. |
| 38 | +- PASS: local import target validation passed for 567 changed existing JS/MJS files. |
| 39 | +- PASS: `npm run test:workspace-v2` passed 59/59 tests. |
| 40 | +- PASS: targeted affected engine/final tests passed: |
| 41 | + - `tests/core/Engine2DCapabilityCombinedFoundation.test.mjs` |
| 42 | + - `tests/core/Engine3DPhysicsHookIsolation.test.mjs` |
| 43 | + - `tests/core/EngineCoreBoundaryBaseline.test.mjs` |
| 44 | + - `tests/core/EngineSceneLifecycle.test.mjs` |
| 45 | + - `tests/core/Section1FinalResidueStructure.test.mjs` |
| 46 | + - `tests/final/PlatformUxSystems.test.mjs` |
| 47 | + - `tests/final/PrecisionCollisionSystems.test.mjs` |
| 48 | +- PASS: `npm run test:launch-smoke:games` passed 12/12 game entries. |
| 49 | +- PASS: `git diff --check` exited 0. Git emitted advisory line-ending warnings for touched test `.mjs` files only. |
| 50 | +- INFO: extra `npm test` was attempted as a broader engine check; it stopped on an existing unrelated missing import, `games/Asteroids/game/FullscreenBezelOverlay.js`, from `tests/games/FullscreenBezelOverlay.test.mjs`. |
| 51 | +- SKIPPED: full samples smoke test, per PR instruction. |
| 52 | + |
| 53 | +## Side Effects Cleaned |
| 54 | +- `npm run test:launch-smoke:games` created `tmp/node_modules`; it was removed after validation so `tmp/` is reserved for the final delta ZIP. |
| 55 | +- `docs/dev/reports/launch_smoke_report.md` was restored to its pre-validation content and is not part of this PR. |
0 commit comments