Remove tools shared index barrel exports - PR_26140_066-remove-tools-shared-index-barrels

Author: DavidQ

docs/dev/reports/tools_shared_index_barrel_removal_report.md

@@ -0,0 +1,59 @@
+# PR_26140_066 Tools Shared Index Barrel Removal Report
+
+## Summary
+- Removed the targeted `tools/shared/**/index.js` barrel files.
+- Replaced all active imports from those barrels with direct imports from the canonical module files.
+- Preserved behavior by changing only import specifiers and deleting now-unused barrel files.
+- Did not touch sample entry `index.js` files, game entry `index.js` files, or `src/engine/**/index.js` files.
+- No replacement pass-through files were created.
+
+## Target Barrels Removed
+- `tools/shared/editor/index.js`
+- `tools/shared/pipeline/index.js`
+- `tools/shared/tooling/index.js`
+
+## Direct Import Decisions
+- Editor sample scenes now import directly from:
+  - `tools/shared/editor/LevelEditor.js`
+  - `tools/shared/editor/TileMapEditor.js`
+  - `tools/shared/editor/EntityPlacementEditor.js`
+  - `tools/shared/editor/TimelineEditor.js`
+- Pipeline sample scenes now import directly from:
+  - `tools/shared/pipeline/AssetImportPipeline.js`
+  - `tools/shared/pipeline/TexturePreprocessPipeline.js`
+  - `tools/shared/pipeline/AudioPreprocessPipeline.js`
+  - `tools/shared/pipeline/ContentMigrationSystem.js`
+  - `tools/shared/pipeline/BuildAssetManifestSystem.js`
+  - `tools/shared/pipeline/ContentValidationPipeline.js`
+- Tooling sample scenes now import directly from:
+  - `tools/shared/tooling/DeveloperConsole.js`
+  - `tools/shared/tooling/RuntimeInspector.js`
+  - `tools/shared/tooling/PropertyEditor.js`
+  - `tools/shared/tooling/LiveTuningService.js`
+  - `tools/shared/tooling/AssetBrowser.js`
+  - `tools/shared/tooling/SceneGraphViewer.js`
+
+## Guardrail Checks
+- PASS: no active imports remain from `tools/shared/editor/index.js`, `tools/shared/pipeline/index.js`, or `tools/shared/tooling/index.js`.
+- PASS: targeted `tools/shared/**/index.js` barrel files no longer exist.
+- PASS: no sample JSON files were modified.
+- PASS: sample entry `index.js`, game entry `index.js`, and `src/engine/**/index.js` files were not modified.
+- Required exception: none.
+
+## Validation
+- PASS: targeted syntax validation for 16 changed JavaScript files.
+- PASS: targeted import-target validation for 16 changed JavaScript files.
+- PASS: `npm run test:workspace-v2` with 59 passed.
+- PASS: `git diff --check` completed without whitespace errors.
+
+## Coverage Guardrail
+- Playwright generated the existing advisory V8 coverage report at `docs/dev/reports/coverage_changed_js_guardrail.txt`.
+- Missing or low coverage entries are WARN-only per project instructions.
+
+## Full Samples Smoke Test
+- Skipped. This PR only normalizes direct imports for targeted `tools/shared` barrel files, and the requested targeted validation plus Workspace V2 test gate passed.
+
+## Manual Validation
+1. Review `docs/dev/reports/codex_review.diff` and confirm each affected sample scene imports the concrete editor, pipeline, or tooling module directly.
+2. Confirm the three targeted `tools/shared/**/index.js` files are absent.
+3. Launch Workspace Manager V2 and confirm normal tool/game launch behavior remains intact.

samples/phase-14/1401/LevelEditorScene.js

@@ -7,7 +7,7 @@ LevelEditorScene.js
 import { Scene } from '/src/engine/scene/index.js';
 import { drawFrame, drawPanel } from '/src/engine/debug/index.js';
 import { Theme, ThemeTokens } from '/src/engine/theme/index.js';
-import { LevelEditor } from '/tools/shared/editor/index.js';
+import LevelEditor from '/tools/shared/editor/LevelEditor.js';
 
 const theme = new Theme(ThemeTokens);
 

samples/phase-14/1402/TileMapEditorScene.js

@@ -4,7 +4,7 @@ David Quesenberry
 03/22/2026
 TileMapEditorScene.js
 */
-import { Scene } from '/src/engine/scene/index.js'; import { drawFrame, drawPanel } from '/src/engine/debug/index.js'; import { Theme, ThemeTokens } from '/src/engine/theme/index.js'; import { TileMapEditor } from '/tools/shared/editor/index.js';
+import { Scene } from '/src/engine/scene/index.js'; import { drawFrame, drawPanel } from '/src/engine/debug/index.js'; import { Theme, ThemeTokens } from '/src/engine/theme/index.js'; import TileMapEditor from '/tools/shared/editor/TileMapEditor.js';
 const theme = new Theme(ThemeTokens);
 export default class TileMapEditorScene extends Scene {
   constructor() { super(); this.editor = new TileMapEditor({ width: 8, height: 4 }); this.status = 'Pick a tile type, then paint a row.'; }

samples/phase-14/1403/EntityPlacementEditorScene.js

@@ -4,7 +4,7 @@ David Quesenberry
 03/22/2026
 EntityPlacementEditorScene.js
 */
-import { Scene } from '/src/engine/scene/index.js'; import { drawFrame, drawPanel } from '/src/engine/debug/index.js'; import { Theme, ThemeTokens } from '/src/engine/theme/index.js'; import { EntityPlacementEditor } from '/tools/shared/editor/index.js';
+import { Scene } from '/src/engine/scene/index.js'; import { drawFrame, drawPanel } from '/src/engine/debug/index.js'; import { Theme, ThemeTokens } from '/src/engine/theme/index.js'; import EntityPlacementEditor from '/tools/shared/editor/EntityPlacementEditor.js';
 const theme = new Theme(ThemeTokens);
 export default class EntityPlacementEditorScene extends Scene {
   constructor() { super(); this.editor = new EntityPlacementEditor(); this.status = 'Add an entity, then move it through editor tooling.'; }

samples/phase-14/1404/TimelineCutsceneEditorScene.js

@@ -4,7 +4,7 @@ David Quesenberry
 03/22/2026
 TimelineCutsceneEditorScene.js
 */
-import { Scene } from '/src/engine/scene/index.js'; import { drawFrame, drawPanel } from '/src/engine/debug/index.js'; import { Theme, ThemeTokens } from '/src/engine/theme/index.js'; import { TimelineEditor } from '/tools/shared/editor/index.js';
+import { Scene } from '/src/engine/scene/index.js'; import { drawFrame, drawPanel } from '/src/engine/debug/index.js'; import { Theme, ThemeTokens } from '/src/engine/theme/index.js'; import TimelineEditor from '/tools/shared/editor/TimelineEditor.js';
 const theme = new Theme(ThemeTokens);
 export default class TimelineCutsceneEditorScene extends Scene {
   constructor() { super(); this.timeline = new TimelineEditor(); this.status = 'Add and reposition cutscene clips.'; }

samples/phase-14/1413/AssetImportPipelineScene.js

@@ -1,4 +1,4 @@
-import { Scene } from '/src/engine/scene/index.js'; import { drawFrame, drawPanel } from '/src/engine/debug/index.js'; import { Theme, ThemeTokens } from '/src/engine/theme/index.js'; import { AssetImportPipeline } from '/tools/shared/pipeline/index.js';
+import { Scene } from '/src/engine/scene/index.js'; import { drawFrame, drawPanel } from '/src/engine/debug/index.js'; import { Theme, ThemeTokens } from '/src/engine/theme/index.js'; import AssetImportPipeline from '/tools/shared/pipeline/AssetImportPipeline.js';
 const theme = new Theme(ThemeTokens);
 export default class AssetImportPipelineScene extends Scene {
   constructor(options = {}) {

samples/phase-14/1414/TextureSpritePreprocessPipelineScene.js

@@ -1,7 +1,7 @@
 import { Scene } from "/src/engine/scene/index.js";
 import { drawFrame, drawPanel } from "/src/engine/debug/index.js";
 import { Theme, ThemeTokens } from "/src/engine/theme/index.js";
-import { TexturePreprocessPipeline } from "/tools/shared/pipeline/index.js";
+import TexturePreprocessPipeline from "/tools/shared/pipeline/TexturePreprocessPipeline.js";
 import { drawSpriteProjectFrame, loadSpriteProjectPreset } from "/samples/shared/spritePresetRuntime.js";
 
 const theme = new Theme(ThemeTokens);