Skip to content

Commit a74c89d

Browse files
author
DavidQ
committed
Fix actual middle point rounding and clarify Snap Angle rotate UI - PR_26133_084-fix-actual-middle-rounding-and-snap-angle-rotate-ui
1 parent 963bfec commit a74c89d

6 files changed

Lines changed: 386 additions & 51 deletions

File tree

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
# Middle Rounding And Snap Angle UI Verification
2+
3+
PR: PR_26133_084-fix-actual-middle-rounding-and-snap-angle-rotate-ui
4+
5+
## Status
6+
7+
- PASS: middle/interior point rounding visibly changes rendered geometry.
8+
- PASS: Snap Angle Rotate uses constrained dropdown controls when enabled.
9+
10+
## Middle/Interior Rounding
11+
12+
- Verified polygon point rows still have one rounding checkbox per row.
13+
- Verified checking point 2 changes the rendered polygon from a straight `polygon` to a rendered `path` with a quadratic `Q` curve.
14+
- Verified checking point 3 adds a second independent `Q` curve.
15+
- Verified unchecking point 2 leaves point 3 rounded and point 2 square.
16+
- Verified polyline middle points use the same rendered `path` + `Q` curve behavior.
17+
- Verified start/end rounding remains covered by independent arc endpoint checks.
18+
- Verified `[+]` still copies and inserts a point after the current row.
19+
- Verified trash still deletes only that row and keeps schema minimum-point guards.
20+
21+
## Snap Angle Rotate UI
22+
23+
- Verified Snap Angle disabled:
24+
- numeric Rotate textbox enabled
25+
- Rotate dropdown disabled
26+
- Snap Angle Step selector disabled
27+
- Verified Snap Angle enabled:
28+
- numeric Rotate textbox disabled
29+
- Rotate dropdown enabled
30+
- Snap Angle Step selector enabled
31+
- Verified default Step `15` dropdown values:
32+
- `0, 15, 30, 45, 60, 75, 90, 105, 120, 135, 150, 165, 180, 195, 210, 225, 240, 255, 270, 285, 300, 315, 330, 345`
33+
- Verified Step `45` dropdown values:
34+
- `0, 45, 90, 135, 180, 225, 270, 315`
35+
- Verified selecting `45` from the dropdown rotates the selected shape by `45` degrees.
36+
- Verified disabling Snap Angle restores raw numeric rotation input; entering `-30` applies the raw delta.
37+
38+
## Validation
39+
40+
- PASS: npm run test:workspace-v2
41+
- Result: 54 passed
42+
- Console/runtime errors: none observed in the exercised Object Vector Studio V2 flows.

docs/dev/reports/playwright_v8_coverage_report.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Playwright V8 Coverage Report
22

3-
PR: PR_26133_083-fix-middle-point-rounding-and-verify-snap-angle
3+
PR: PR_26133_084-fix-actual-middle-rounding-and-snap-angle-rotate-ui
44

55
Source: docs/dev/reports/playwright_v8_coverage_report.txt generated by the latest npm run test:workspace-v2 run.
66

@@ -21,9 +21,10 @@ Source: docs/dev/reports/playwright_v8_coverage_report.txt generated by the late
2121

2222
## Changed Runtime JS Files Covered
2323

24-
- (95%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 7092/7092; executed functions 714/752
24+
- (95%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 7294/7294; executed functions 731/769
2525

2626
## Changed JS Files Considered
2727

28-
- (95%) tools/object-vector-studio-v2/js/ToolStarterApp.js - Object Vector Studio V2 runtime covered by browser V8 coverage while focused rounding and Snap Angle behavior was exercised.
28+
- (95%) tools/object-vector-studio-v2/js/ToolStarterApp.js - Object Vector Studio V2 runtime covered by browser V8 coverage while rounded point rendering and Snap Angle dropdown behavior were exercised.
29+
- (0%) tools/object-vector-studio-v2/styles/toolStarter.css - CSS layout file, not collected as browser JS coverage.
2930
- (0%) tests/playwright/tools/WorkspaceManagerV2.spec.mjs - Playwright test file, not collected as browser runtime coverage.

docs/dev/reports/playwright_workspace_v2_results.md

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Playwright Workspace V2 Results
22

3-
PR: PR_26133_083-fix-middle-point-rounding-and-verify-snap-angle
3+
PR: PR_26133_084-fix-actual-middle-rounding-and-snap-angle-rotate-ui
44

55
## Validation
66

@@ -15,11 +15,12 @@ PR: PR_26133_083-fix-middle-point-rounding-and-verify-snap-angle
1515
- Shape Geometry point rows still render exactly one Round checkbox per point row.
1616
- Row-local plus buttons still insert a copied point directly after the current row.
1717
- Row-local trash buttons still delete only their row and reject invalid minimum-count deletion.
18-
- Polygon interior point rounding now verifies two rounded middle/corner points, then unrounds one and confirms the other stays rounded.
19-
- Polyline middle point rounding still verifies independent middle-joint round/unround behavior.
20-
- Arc start/end rounding still verifies independent endpoint controls.
21-
- Snap Angle Rotate is explicitly verified with Snap Angle enabled: Rotate input 22 applies 15 degrees using the current 15 degree snap increment.
22-
- Snap Angle disabled still applies the raw entered rotation delta.
18+
- Polygon and polyline middle/interior rounding now verifies actual rendered SVG geometry changes to a path with quadratic `Q` corner curves.
19+
- Checking two middle/interior points, then unchecking one, keeps the other rendered as the only rounded joint.
20+
- Start/end rounding still passes through the existing arc endpoint coverage.
21+
- Snap Angle enabled disables the free numeric Rotate textbox and enables the Rotate dropdown plus Step selector.
22+
- Snap Angle disabled re-enables the numeric Rotate textbox and disables the constrained dropdown controls.
23+
- Default 15 degree dropdown values and 45 degree Step-generated dropdown values were verified.
2324

2425
## Console/Runtime Errors
2526

0 commit comments

Comments
 (0)