Fix middle point rounding and verify Snap Angle rotate behavior - PR_26133_083-fix-middle-point-rounding-and-verify-snap-angle

Author: DavidQ

docs/dev/reports/playwright_v8_coverage_report.md

@@ -1,6 +1,6 @@
 # Playwright V8 Coverage Report
 
-PR: PR_26133_081-point-row-layout-and-independent-rounding-fix
+PR: PR_26133_083-fix-middle-point-rounding-and-verify-snap-angle
 
 Source: docs/dev/reports/playwright_v8_coverage_report.txt generated by the latest npm run test:workspace-v2 run.
 
@@ -21,9 +21,9 @@ Source: docs/dev/reports/playwright_v8_coverage_report.txt generated by the late
 
 ## Changed Runtime JS Files Covered
 
-- (95%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 7011/7011; executed functions 712/750
+- (95%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 7092/7092; executed functions 714/752
 
 ## Changed JS Files Considered
 
-- (95%) tools/object-vector-studio-v2/js/ToolStarterApp.js - changed runtime JS file with browser V8 coverage
-- (0%) tests/playwright/tools/WorkspaceManagerV2.spec.mjs - Playwright test file, not collected as browser runtime coverage
+- (95%) tools/object-vector-studio-v2/js/ToolStarterApp.js - Object Vector Studio V2 runtime covered by browser V8 coverage while focused rounding and Snap Angle behavior was exercised.
+- (0%) tests/playwright/tools/WorkspaceManagerV2.spec.mjs - Playwright test file, not collected as browser runtime coverage.

docs/dev/reports/playwright_workspace_v2_results.md

@@ -1,23 +1,25 @@
 # Playwright Workspace V2 Results
 
-PR: PR_26133_081-point-row-layout-and-independent-rounding-fix
+PR: PR_26133_083-fix-middle-point-rounding-and-verify-snap-angle
 
 ## Validation
 
 - PASS: npm run test:workspace-v2
 - Result: 54 passed
-- Runtime: 5.5m
+- Runtime: 5.3m
 - Browser project: playwright
 - Workers: 1
 
 ## Targeted Checks Covered
 
-- Shape Geometry point rows still render exactly one Round checkbox per row.
-- Point rows now use one right-aligned action cell containing Round and the row trash button.
-- Editable point row layout keeps Point, X, Y, and actions in four stable columns.
-- Polygon/polyline point-list shapes no longer inherit shared middle/corner rounding from legacy pointStyle fallback.
-- Checking two middle polyline points and then unchecking one leaves the other middle point rounded.
-- Row trash deletion and invalid delete rejection coverage remain green.
+- Shape Geometry point rows still render exactly one Round checkbox per point row.
+- Row-local plus buttons still insert a copied point directly after the current row.
+- Row-local trash buttons still delete only their row and reject invalid minimum-count deletion.
+- Polygon interior point rounding now verifies two rounded middle/corner points, then unrounds one and confirms the other stays rounded.
+- Polyline middle point rounding still verifies independent middle-joint round/unround behavior.
+- Arc start/end rounding still verifies independent endpoint controls.
+- Snap Angle Rotate is explicitly verified with Snap Angle enabled: Rotate input 22 applies 15 degrees using the current 15 degree snap increment.
+- Snap Angle disabled still applies the raw entered rotation delta.
 
 ## Console/Runtime Errors
 

docs/dev/reports/snap_angle_rotate_verification.md

@@ -0,0 +1,29 @@
+# Snap Angle Rotate Verification
+
+PR: PR_26133_083-fix-middle-point-rounding-and-verify-snap-angle
+
+## Status
+
+- PASS: Snap Angle affects Object Transform Rotate when enabled.
+
+## Validation
+
+- PASS: npm run test:workspace-v2
+- Result: 54 passed
+- Focused coverage: tests/playwright/tools/WorkspaceManagerV2.spec.mjs
+
+## Rotate Behavior Verified
+
+- Enabled Snap Angle.
+- Entered Rotate value `22`.
+- Clicked Rotate.
+- PASS: selected shape transform rotation became `15`.
+- PASS: Rotate input stayed `22` while the applied delta snapped to the current 15 degree increment.
+- PASS: status log reported `Snap Angle active: 22 -> 15`.
+- Disabled Snap Angle.
+- Entered Rotate value `-30`.
+- PASS: Rotate applied the raw `-30` degree delta and the wrapped transform summary showed `rot 345`.
+
+## Conclusion
+
+PASS: Snap Angle Rotate behavior is verified and must not be marked complete without this passing coverage.

tests/playwright/tools/WorkspaceManagerV2.spec.mjs

@@ -2694,6 +2694,22 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       await expect(page.locator("#objectVectorStudioV2JsonDetails")).toContainText('"rotation": 15');
       await expect(page.locator("#objectVectorStudioV2RotateInput")).toHaveValue("22");
       await expect(page.locator("#statusLog")).toHaveValue(/OK Rotated shape row 0 by 15 degrees\. Snap Angle active: 22 -> 15\./);
+      const snapAngleRotateVerification = await page.evaluate(() => {
+        const shape = window.__objectVectorStudioV2App.selectedShape();
+        const statusLines = document.querySelector("#statusLog").value.trim().split("\n");
+        return {
+          angleSnapEnabled: window.__objectVectorStudioV2App.angleSnapEnabled,
+          inputValue: document.querySelector("#objectVectorStudioV2RotateInput").value,
+          rotation: shape.transform.rotation,
+          status: statusLines[statusLines.length - 1].replace(/^\[[^\]]+\]\s*/, "")
+        };
+      });
+      expect(snapAngleRotateVerification).toEqual({
+        angleSnapEnabled: true,
+        inputValue: "22",
+        rotation: 15,
+        status: "OK Rotated shape row 0 by 15 degrees. Snap Angle active: 22 -> 15."
+      });
       await page.locator("#objectVectorStudioV2AngleSnapButton").click();
       await page.locator("#objectVectorStudioV2RotateInput").fill("-30");
       await expect(page.locator("#objectVectorStudioV2RotateInput")).toHaveValue("-30");
@@ -4075,6 +4091,42 @@ test.describe("Workspace Manager V2 bootstrap", () => {
         pointRounding: [false, true, false, false],
         strokeLinejoin: "miter"
       });
+      await page.locator("#objectVectorStudioV2ShapeGeometryDetails [data-polygon-point-round='true'][data-polygon-point-index='2']").check();
+      await expect(page.locator("#statusLog")).toHaveValue(/OK Updated point 3 rounding to round for shape row 0\./);
+      const twoInteriorPointsRounded = await page.locator("#objectVectorStudioV2RenderSurface").evaluate((surface) => {
+        const shape = surface.querySelector("[data-shape-index='0']");
+        const markers = Array.from(surface.querySelectorAll("[data-point-style-caps='polygon'] [data-point-style-cap]")).map((marker) => marker.dataset.pointStyleCap);
+        return {
+          markers,
+          pointRounding: window.__objectVectorStudioV2App.selectedShape().style.pointRounding,
+          strokeLinejoin: shape.getAttribute("stroke-linejoin")
+        };
+      });
+      expect(twoInteriorPointsRounded).toEqual({
+        markers: ["point-1", "point-2"],
+        pointRounding: [false, true, true, false],
+        strokeLinejoin: "miter"
+      });
+      await page.locator("#objectVectorStudioV2ShapeGeometryDetails [data-polygon-point-round='true'][data-polygon-point-index='1']").uncheck();
+      await expect(page.locator("#statusLog")).toHaveValue(/OK Updated point 2 rounding to square for shape row 0\./);
+      const independentInteriorPoint = await page.locator("#objectVectorStudioV2RenderSurface").evaluate((surface) => {
+        const shape = surface.querySelector("[data-shape-index='0']");
+        const markers = Array.from(surface.querySelectorAll("[data-point-style-caps='polygon'] [data-point-style-cap]")).map((marker) => marker.dataset.pointStyleCap);
+        return {
+          markers,
+          pointRounding: window.__objectVectorStudioV2App.selectedShape().style.pointRounding,
+          strokeLinejoin: shape.getAttribute("stroke-linejoin")
+        };
+      });
+      expect(independentInteriorPoint).toEqual({
+        markers: ["point-2"],
+        pointRounding: [false, false, true, false],
+        strokeLinejoin: "miter"
+      });
+      await page.locator("#objectVectorStudioV2ShapeGeometryDetails [data-polygon-point-round='true'][data-polygon-point-index='1']").check();
+      await expect(page.locator("#statusLog")).toHaveValue(/OK Updated point 2 rounding to round for shape row 0\./);
+      await page.locator("#objectVectorStudioV2ShapeGeometryDetails [data-polygon-point-round='true'][data-polygon-point-index='2']").uncheck();
+      await expect(page.locator("#statusLog")).toHaveValue(/OK Updated point 3 rounding to square for shape row 0\./);
       await page.locator("#objectVectorStudioV2ShapeGeometryDetails [data-polygon-point-add='true'][data-polygon-point-index='1']").click();
       await expect.poll(() => page.locator("#objectVectorStudioV2ShapeGeometryDetails .object-vector-studio-v2__polygon-point-field").evaluateAll((rows) => rows.map((row) => ({
         label: row.querySelector(".object-vector-studio-v2__polygon-point-label").textContent.trim(),