Remove deprecated tool registrations and align workspace tile actions - PR_26130_030-remove-deprecated-tools-and-align-tile-actions

Author: DavidQ

docs/dev/reports/PR_26130_030-remove-deprecated-tools-and-align-tile-actions.md

@@ -0,0 +1,63 @@
+# PR_26130_030-remove-deprecated-tools-and-align-tile-actions
+
+## Summary
+- Removed Asset Browser / Import Hub and Tile Model Converter from active tool registration, Tools Index rendering, workspace/tool shared navigation, project adapter/toolState hooks, schema metadata, starter template state, and deprecated targeted tests.
+- Deleted the deprecated tool implementation folders and their tool payload schemas.
+- Updated Workspace Manager V2 tool tiles so the action row has a fixed height and is anchored to the bottom of each tile across varied count/description text.
+- Added/updated Workspace Manager V2 Playwright coverage for removed registry/index/workspace launch paths and fixed tile action layout metrics.
+
+## Scope Notes
+- No `start_of_day` files changed.
+- No full sample JSON alignment was attempted.
+- Historical docs/reports and legacy runtime compatibility references were not rewritten unless they were active current-tool availability references.
+- Asset Manager V2's explicit guard rejecting old `tools.asset-browser` workspace payloads remains intentionally in place as a negative validation path.
+
+## Playwright Impacted
+Yes.
+
+Validated behavior:
+- Asset Browser / Import Hub is absent from the Tools Index and tool registry.
+- Tile Model Converter is absent from the Tools Index and tool registry.
+- Removed tools have no active sample launch definitions and their old direct tool folders return 404.
+- Removed tools do not render as Workspace Manager V2 tool tiles.
+- Workspace Manager V2 tool tile action rows have fixed height, fixed chip height, and consistent bottom alignment.
+
+Expected pass behavior:
+- `npm run test:workspace-v2` passes all Workspace Manager V2 tests.
+- Removed tool IDs are unavailable from registry/launch lookup and do not render in Workspace Manager V2.
+- Workspace tool action chips stay aligned at the bottom of fixed-height tiles.
+
+Expected fail behavior:
+- Any reintroduced `asset-browser` or `tile-model-converter` registry, index, launch, or workspace tile path fails the updated Playwright assertions.
+- Any tile action row height or bottom-baseline drift fails the layout metric assertions.
+
+## Validation
+- PASS: `npm run test:workspace-v2` -> 36 passed.
+- PASS: `node --test tests/tools/ToolSchemaStrictModeValidation.test.mjs`.
+- PASS: `node --check` on changed runtime/test JavaScript files spot-checked during implementation.
+- PASS: JSON parse check for changed JSON files.
+- PASS: `git diff --check`.
+- PASS: Playwright V8 coverage report generated at `docs/dev/reports/playwright_v8_coverage_report.txt`.
+
+Coverage highlights for changed runtime JS:
+- `(100%) tools/renderToolsIndex.js - changed JS file with browser V8 coverage`
+- `(93%) tools/workspace-manager-v2/js/controls/ToolTilesControl.js - changed JS file with browser V8 coverage`
+- `(91%) tools/toolRegistry.js - changed JS file with browser V8 coverage`
+- `(32%) tools/shared/platformShell.js - changed JS file with browser V8 coverage`
+- `(9%) tools/shared/projectSystemAdapters.js - changed JS file with browser V8 coverage`
+- `(6%) tools/shared/projectToolIntegration.js - changed JS file with browser V8 coverage`
+
+## Full Samples Smoke Test
+Skipped. This PR removes deprecated active tool availability and adjusts Workspace Manager V2 tile styling; targeted Workspace V2 Playwright coverage is the required validation gate. Full sample smoke remains out of scope and intentionally was not run.
+
+## Manual Validation
+1. Open `tools/index.html` and confirm Asset Browser / Import Hub and Tile Model Converter are not listed.
+2. Open Workspace Manager V2, pick the repo, select Asteroids, and confirm the six remaining workspace tiles render without the removed tools.
+3. Confirm each workspace tile keeps How To Use and Read Me action chips pinned to the bottom of the tile.
+4. Try the old direct paths `/tools/Asset%20Browser/index.html` and `/tools/Tile%20Model%20Converter/index.html`; both should be unavailable.
+
+## Review Artifacts
+- `docs/dev/reports/codex_review.diff`
+- `docs/dev/reports/codex_changed_files.txt`
+- `docs/dev/reports/playwright_v8_coverage_report.txt`
+- `tmp/PR_26130_030-remove-deprecated-tools-and-align-tile-actions_delta.zip`

tests/playwright/tools/WorkspaceManagerV2.spec.mjs

@@ -977,7 +977,9 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       await expect(textToSpeechToolCard).toBeVisible();
       await expect(textToSpeechToolCard.locator("a", { hasText: "Text to Speech V2" })).toHaveAttribute("href", "/tools/text2speech-V2/index.html");
       await expect(textToSpeechToolCard).toContainText("First-Class Tool V2 for browser speech synthesis");
-      const toolsIndexState = await page.evaluate(() => {
+      const toolsIndexState = await page.evaluate(async () => {
+        const registryModule = await import("/tools/toolRegistry.js");
+        const launchModule = await import("/tools/shared/toolLaunchSSoTData.js");
         const firstClassToolsSection = Array.from(document.querySelectorAll("section"))
           .find((section) => section.querySelector(":scope > h2")?.textContent?.trim() === "First-Class Tools");
         const workflowGrid = firstClassToolsSection?.querySelector("[data-active-tools-workflow-grid]");
@@ -997,9 +999,23 @@ test.describe("Workspace Manager V2 bootstrap", () => {
           allCards: cards.map((toolCard) => toolCard.querySelector("h3")?.textContent?.trim() || ""),
           headings: Array.from(firstClassToolsSection?.querySelectorAll(":scope > h3") || [])
             .map((heading) => heading.textContent.trim()),
+          launchIds: launchModule.listToolLaunchIds(),
           paletteManagerActionClasses: actionClassesForCard("Palette Manager V2"),
           plannedCards: Array.from(plannedToolsGrid?.querySelectorAll(".card h3") || [])
             .map((heading) => heading.textContent.trim()),
+          registryIds: registryModule.getToolRegistry().map((tool) => tool.id),
+          removedLaunchDefinitions: {
+            assetBrowser: launchModule.getSampleToolLaunchDefinition("asset-browser"),
+            tileModelConverter: launchModule.getSampleToolLaunchDefinition("tile-model-converter")
+          },
+          removedToolLookup: {
+            assetBrowser: registryModule.getToolById("asset-browser"),
+            tileModelConverter: registryModule.getToolById("tile-model-converter")
+          },
+          removedToolPathStatuses: await Promise.all([
+            fetch("/tools/Asset%20Browser/index.html", { cache: "no-store" }).then((response) => response.status),
+            fetch("/tools/Tile%20Model%20Converter/index.html", { cache: "no-store" }).then((response) => response.status)
+          ]),
           sampleLabels: Array.from(firstClassToolsSection?.querySelectorAll(".tools-platform-card__action") || [])
             .map((action) => action.textContent.trim())
             .filter((label) => label.startsWith("Samples")),
@@ -1020,6 +1036,17 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       expect(toolsIndexState.utilitiesCards).toContain("Text to Speech V2");
       expect(toolsIndexState.allCards).not.toContain("Asset Browser / Import Hub");
       expect(toolsIndexState.allCards).not.toContain("Tile Model Converter");
+      expect(toolsIndexState.registryIds).not.toContain("asset-browser");
+      expect(toolsIndexState.registryIds).not.toContain("tile-model-converter");
+      expect(toolsIndexState.removedToolLookup).toEqual({
+        assetBrowser: null,
+        tileModelConverter: null
+      });
+      expect(toolsIndexState.launchIds).not.toContain("tool.asset-browser");
+      expect(toolsIndexState.launchIds).not.toContain("tool.tile-model-converter");
+      expect(toolsIndexState.removedLaunchDefinitions.assetBrowser.launchDefinition).toBeNull();
+      expect(toolsIndexState.removedLaunchDefinitions.tileModelConverter.launchDefinition).toBeNull();
+      expect(toolsIndexState.removedToolPathStatuses).toEqual([404, 404]);
       expect(toolsIndexState.plannedCards).toContain("Piper WASM Backend");
       expect(toolsIndexState.plannedCards).toContain("Optional SSML Processing Layer");
       expect(toolsIndexState.plannedCards).not.toContain("Character Voice Presets");
@@ -3006,6 +3033,8 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       await expect(page.locator("#workspaceToolTiles [data-workspace-tool-id]")).toHaveCount(6);
       await expect(page.locator('[data-workspace-tool-id="workspace-manager-v2"]')).toHaveCount(0);
       await expect(page.locator('[data-workspace-tool-id="session-inspector"]')).toHaveCount(0);
+      await expect(page.locator('[data-workspace-tool-id="asset-browser"]')).toHaveCount(0);
+      await expect(page.locator('[data-workspace-tool-id="tile-model-converter"]')).toHaveCount(0);
       const toolGroupMembership = await page.locator(".workspace-manager-v2__tool-group").evaluateAll((groups) => Object.fromEntries(groups.map((group) => [
         group.querySelector(".workspace-manager-v2__tool-group-title")?.textContent?.trim(),
         Array.from(group.querySelectorAll(".workspace-manager-v2__tool-tile-name"), (name) => name.textContent.trim())
@@ -3221,6 +3250,16 @@ test.describe("Workspace Manager V2 bootstrap", () => {
         height: Math.round(tile.getBoundingClientRect().height),
         width: Math.round(tile.getBoundingClientRect().width)
       })));
+      const tileActionLayout = await page.locator("#workspaceToolTiles [data-workspace-tool-id]").evaluateAll((tiles) => tiles.map((tile) => {
+        const tileRect = tile.getBoundingClientRect();
+        const actions = tile.querySelector(".workspace-manager-v2__tool-tile-actions");
+        const actionRect = actions.getBoundingClientRect();
+        return {
+          actionBottomGap: Math.round(tileRect.bottom - actionRect.bottom),
+          actionHeight: Math.round(actionRect.height),
+          chipHeights: Array.from(actions.querySelectorAll(".workspace-manager-v2__tool-tile-action"), (action) => Math.round(action.getBoundingClientRect().height))
+        };
+      }));
       expect(tileLayout).toEqual([
         { height: 142, width: 180 },
         { height: 142, width: 180 },
@@ -3229,6 +3268,9 @@ test.describe("Workspace Manager V2 bootstrap", () => {
         { height: 142, width: 180 },
         { height: 142, width: 180 }
       ]);
+      expect([...new Set(tileActionLayout.map((entry) => entry.actionBottomGap))]).toHaveLength(1);
+      expect(tileActionLayout.every((entry) => entry.actionHeight === 24)).toBe(true);
+      expect(tileActionLayout.every((entry) => entry.chipHeights.every((height) => height === 22))).toBe(true);
       await expect(page.locator("#statusLog")).toHaveValue(/OK Boundary contract: game\.gameData is runtime data; game\.workspace is editor\/tool state\. Runtime ignores game\.workspace; tools may read game\.gameData, write game\.workspace, and update game\.gameData only through explicit validated apply\/build\/export actions\./);
       await expect(page.locator("#statusLog")).toHaveValue(/OK Hydrated workspace session for asset-manager-v2, palette-manager-v2, preview-generator-v2, text2speech-V2, session-inspector-v2\./);
       await expect(page.locator("#statusLog")).toHaveValue(/INFO Skipped workspace session hydration for templates-v2: starter\/dev-only tool is not enabled by the selected game workspace config\./);

tests/runtime/GamesIndexWorkspaceManagerOpen.test.mjs

@@ -373,7 +373,6 @@ function readExpectedMetadataSets() {
           const tileMapEntries = manifest?.tools?.["tile-map-editor"]?.maps;
           const parallaxEntries = manifest?.tools?.["parallax-editor"]?.parallaxLevels;
           const vectorEntries = manifest?.tools?.["svg-asset-studio"]?.vectors;
-          const assetBrowserEntries = manifest?.tools?.["asset-browser"]?.assets;
 
           const countEntries = (value) => {
             if (Array.isArray(value)) {
@@ -390,7 +389,6 @@ function readExpectedMetadataSets() {
             || countEntries(tileMapEntries) > 0
             || countEntries(parallaxEntries) > 0
             || countEntries(vectorEntries) > 0
-            || countEntries(assetBrowserEntries) > 0
           );
           hasManifestVectors = countEntries(vectorEntries) > 0;
           const firstSkin = hasManifestSkin ? skins[0] : null;

tests/runtime/SampleStandaloneToolDataFlow.test.mjs

@@ -657,32 +657,6 @@ function findPresetFilePathForSample(sampleId, toolId) {
   return "";
 }
 
-async function runTargetedAssetBrowserAssertion(page, url) {
-  await page.navigate(url);
-  let status = null;
-  const started = Date.now();
-  while ((Date.now() - started) < 9000) {
-    status = await page.evaluate(`(() => {
-      const statusText = String(document.getElementById("importStatusText")?.textContent || "").trim();
-      const selectedCategory = String(document.getElementById("importCategorySelect")?.value || "").trim();
-      const selectedDestination = String(document.getElementById("importDestinationSelect")?.value || "").trim();
-      const destinationOptionCount = Number(document.getElementById("importDestinationSelect")?.options?.length || 0);
-      return { statusText, selectedCategory, selectedDestination, destinationOptionCount };
-    })()`);
-    if (/Loaded preset/i.test(status.statusText) || /Preset load failed/i.test(status.statusText)) {
-      break;
-    }
-    await wait(150);
-  }
-
-  assert.match(status.statusText, /Loaded preset/i, "Asset Browser did not report preset load.");
-  assert.doesNotMatch(status.statusText, /Preset load failed/i, "Asset Browser reported preset load failure.");
-  assert.ok(status.selectedCategory, "Asset Browser selected category is empty.");
-  assert.equal(status.selectedDestination, "", "Asset Browser destination should require explicit action-time selection.");
-  assert.ok(status.destinationOptionCount > 1, "Asset Browser destination options were not populated.");
-  return status;
-}
-
 async function runTargetedAssetPipelineAssertion(page, url, expectedGameId) {
   await page.navigate(url);
   let status = null;
@@ -771,9 +745,6 @@ function extractPaletteFromPresetPayload(rawPreset) {
 
 function buildTargetedCases(roundtripRows, toolMap) {
   const specs = [
-    { sampleId: "0204", toolId: "asset-browser" },
-    { sampleId: "1413", toolId: "asset-browser" },
-    { sampleId: "1505", toolId: "asset-browser" },
     { sampleId: "0510", toolId: "asset-pipeline" },
     { sampleId: "1413", toolId: "asset-pipeline" },
     { sampleId: "1417", toolId: "asset-pipeline" },
@@ -819,9 +790,6 @@ function buildGenericFailureCloseoutCases(roundtripRows, toolMap) {
     { sampleId: "0210", toolId: "physics-sandbox" },
     { sampleId: "0303", toolId: "physics-sandbox" },
     { sampleId: "1606", toolId: "physics-sandbox" },
-    { sampleId: "0221", toolId: "tile-model-converter" },
-    { sampleId: "0305", toolId: "tile-model-converter" },
-    { sampleId: "1209", toolId: "tile-model-converter" },
     { sampleId: "0221", toolId: "3d-json-payload" },
     { sampleId: "0305", toolId: "3d-json-payload" },
     { sampleId: "1208", toolId: "3d-json-payload" },
@@ -950,54 +918,6 @@ async function runPhysicsSandboxContractAssertion(page, url, expectedBody) {
   return status;
 }
 
-async function runTileModelConverterContractAssertion(page, url, expectedCandidate, expectedConversion) {
-  await page.navigate(url);
-  let status = null;
-  const started = Date.now();
-  while ((Date.now() - started) < 9000) {
-    status = await page.evaluate(`(() => {
-      const statusText = String(document.getElementById("converterStatus")?.textContent || "").trim();
-      const inputText = String(document.getElementById("converterInput")?.value || "").trim();
-      let parsed = null;
-      try {
-        parsed = inputText ? JSON.parse(inputText) : null;
-      } catch {
-        parsed = null;
-      }
-      const candidateKeys = parsed?.candidate && typeof parsed.candidate === "object" ? Object.keys(parsed.candidate) : [];
-      const conversionKeys = parsed?.conversion && typeof parsed.conversion === "object" ? Object.keys(parsed.conversion) : [];
-      return {
-        statusText,
-        parsedCandidate: parsed?.candidate || null,
-        parsedConversion: parsed?.conversion || null,
-        candidateCount: candidateKeys.length,
-        conversionCount: conversionKeys.length
-      };
-    })()`);
-    if (
-      /Preset load failed/i.test(status.statusText)
-      || (status.candidateCount > 0 && status.conversionCount > 0)
-    ) {
-      break;
-    }
-    await wait(150);
-  }
-  assert.doesNotMatch(status.statusText, /Preset load failed/i, "Tile Model Converter reported preset load failure.");
-  assert.ok(status.candidateCount > 0, "Tile Model Converter candidate payload is empty.");
-  assert.ok(status.conversionCount > 0, "Tile Model Converter conversion payload is empty.");
-  assert.equal(
-    JSON.stringify(status.parsedCandidate),
-    JSON.stringify(expectedCandidate),
-    "Tile Model Converter candidate payload mismatch."
-  );
-  assert.equal(
-    JSON.stringify(status.parsedConversion),
-    JSON.stringify(expectedConversion),
-    "Tile Model Converter conversion payload mismatch."
-  );
-  return status;
-}
-
 async function runJsonNormalizerContractAssertion(page, url, expectedPointCount, expectedSegmentCount) {
   await page.navigate(url);
   let status = null;
@@ -1193,15 +1113,6 @@ export async function run() {
         genericContractResults.push({ sampleId: testCase.sampleId, toolId: testCase.toolId, ...result });
         continue;
       }
-      if (testCase.toolId === "tile-model-converter") {
-        const expectedCandidate = testCase.presetPayload?.config?.candidate;
-        const expectedConversion = testCase.presetPayload?.config?.conversion;
-        assert.ok(expectedCandidate && typeof expectedCandidate === "object", `Missing expected converter candidate in ${toPosixPath(path.relative(repoRoot, testCase.presetFilePath))}.`);
-        assert.ok(expectedConversion && typeof expectedConversion === "object", `Missing expected converter conversion in ${toPosixPath(path.relative(repoRoot, testCase.presetFilePath))}.`);
-        const result = await runTileModelConverterContractAssertion(page, url, expectedCandidate, expectedConversion);
-        genericContractResults.push({ sampleId: testCase.sampleId, toolId: testCase.toolId, ...result });
-        continue;
-      }
       if (testCase.toolId === "3d-json-payload") {
         const expectedPointCount = Array.isArray(testCase.presetPayload?.config?.mapPayload?.points)
           ? testCase.presetPayload.config.mapPayload.points.length
@@ -1250,11 +1161,6 @@ export async function run() {
 
     for (const testCase of targetedCases) {
       const url = buildStandaloneToolUrl(baseUrl, testCase.tool.entryPoint, testCase.row);
-      if (testCase.toolId === "asset-browser") {
-        const result = await runTargetedAssetBrowserAssertion(page, url);
-        targetedResults.push({ sampleId: testCase.sampleId, toolId: testCase.toolId, ...result });
-        continue;
-      }
       if (testCase.toolId === "asset-pipeline") {
         const expectedGameId = String(testCase.presetPayload?.config?.pipelinePayload?.gameId || "").trim();
         assert.ok(expectedGameId, `Missing expected pipeline gameId in ${toPosixPath(path.relative(repoRoot, testCase.presetFilePath))}.`);

tests/tools/AssetUsageIntegration.test.mjs

@@ -39,22 +39,20 @@ export async function run() {
 
   try {
     const actions = getSharedShellActions("sprite-editor", "tool");
-    assert.equal(actions.length, 4);
+    assert.equal(actions.length, 2);
     assert.deepEqual(
       actions.map((entry) => entry.label),
       [
-        SHARED_ACTION_LABELS.browseAssets,
-        SHARED_ACTION_LABELS.importAssets,
         SHARED_ACTION_LABELS.browsePalettes,
         SHARED_ACTION_LABELS.managePalettes
       ]
     );
     assert.equal(
       actions[0].href,
-      "../Asset Browser/index.html?view=browse&sourceToolId=sprite-editor"
+      "../palette-manager-v2/index.html?view=browse&sourceToolId=sprite-editor"
     );
     assert.equal(
-      actions[3].href,
+      actions[1].href,
       "../palette-manager-v2/index.html?view=manage&sourceToolId=sprite-editor"
     );