Clean tools index entries and show Text to Speech V2 item count - PR_26130_029-tools-index-cleanup-and-text-to-speech-count

Author: DavidQ

docs/dev/reports/PR_26130_029-tools-index-cleanup-and-text-to-speech-count.md

@@ -0,0 +1,28 @@
+# PR_26130_029-tools-index-cleanup-and-text-to-speech-count
+
+## Summary
+- Removed the planned `Character Voice Presets` and `Game Character Voice / Event Integration` cards from `tools/index.html`.
+- Hid `Asset Browser / Import Hub` and `Tile Model Converter` from the generated tools index surface without deleting their runtime folders or changing broader registry visibility.
+- Replaced the Workspace Manager V2 Text to Speech V2 tile detail from `Speech synthesis ready.` to a live `N text to speech` count.
+- Threaded the existing Text to Speech V2 session summary count into Workspace Manager V2 tool tile rendering.
+- Added Playwright coverage that locks Session Inspector V2 How To Use and Read Me buttons to the same shared tools-index action class pattern used by Palette Manager V2.
+
+## Scope Notes
+- Scope was limited to `tools/index.html`, the tools index renderer, Workspace Manager V2 tile count display, and direct Playwright coverage.
+- Runtime folders for `tools/asset-browser` and `tools/tile-model-converter` were not deleted.
+- No start_of_day changes.
+- Full samples smoke test was not run. Reason: this PR is limited to tools index cleanup and Workspace Manager V2 tile display; the requested `npm run test:workspace-v2` suite covers the scoped behavior.
+
+## Validation
+- First run: `npm run test:workspace-v2` timed out at the command timeout before completion.
+- Final run: `npm run test:workspace-v2`
+- Result: 36 passed.
+- Playwright V8 coverage report included changed runtime JS coverage:
+  - `(100%) tools/renderToolsIndex.js - executed lines 180/180; executed functions 28/28`
+  - `(86%) tools/workspace-manager-v2/js/WorkspaceManagerV2App.js - executed lines 940/940; executed functions 42/49`
+  - `(93%) tools/workspace-manager-v2/js/controls/ToolTilesControl.js - executed lines 126/126; executed functions 14/15`
+
+## Artifacts
+- Diff report: `docs/dev/reports/codex_review.diff`
+- Changed files report: `docs/dev/reports/codex_changed_files.txt`
+- Delta ZIP: `tmp/PR_26130_029-tools-index-cleanup-and-text-to-speech-count_delta.zip`

tests/playwright/tools/WorkspaceManagerV2.spec.mjs

@@ -984,17 +984,26 @@ test.describe("Workspace Manager V2 bootstrap", () => {
         const utilitiesGrid = firstClassToolsSection?.querySelector("[data-active-tools-utilities-grid]");
         const viewersGrid = firstClassToolsSection?.querySelector("[data-active-tools-viewers-grid]");
         const workspaceCard = workflowGrid?.querySelector(".tools-platform-card");
+        const cards = Array.from(firstClassToolsSection?.querySelectorAll(".tools-platform-card") || []);
+        const actionClassesForCard = (title) => {
+          const toolCard = cards.find((candidate) => candidate.querySelector("h3")?.textContent?.trim() === title);
+          return Object.fromEntries(Array.from(toolCard?.querySelectorAll(".tools-platform-card__action") || [])
+            .map((action) => [action.textContent.trim(), action.className.trim()]));
+        };
         const plannedToolsGrid = document.querySelector("[data-planned-tools-grid]");
         return {
           actionLabels: Array.from(firstClassToolsSection?.querySelectorAll(".tools-platform-card__action") || [])
             .map((action) => action.textContent.trim()),
+          allCards: cards.map((toolCard) => toolCard.querySelector("h3")?.textContent?.trim() || ""),
           headings: Array.from(firstClassToolsSection?.querySelectorAll(":scope > h3") || [])
             .map((heading) => heading.textContent.trim()),
+          paletteManagerActionClasses: actionClassesForCard("Palette Manager V2"),
           plannedCards: Array.from(plannedToolsGrid?.querySelectorAll(".card h3") || [])
             .map((heading) => heading.textContent.trim()),
           sampleLabels: Array.from(firstClassToolsSection?.querySelectorAll(".tools-platform-card__action") || [])
             .map((action) => action.textContent.trim())
             .filter((label) => label.startsWith("Samples")),
+          sessionInspectorActionClasses: actionClassesForCard("Session Inspector V2"),
           utilitiesCards: Array.from(utilitiesGrid?.querySelectorAll(".tools-platform-card h3") || [])
             .map((heading) => heading.textContent.trim()),
           viewersCards: Array.from(viewersGrid?.querySelectorAll(".tools-platform-card h3") || [])
@@ -1009,10 +1018,12 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       expect(toolsIndexState.workflowCards).toEqual(["Workspace Manager V2"]);
       expect(toolsIndexState.utilitiesCards).not.toContain("Workspace Manager V2");
       expect(toolsIndexState.utilitiesCards).toContain("Text to Speech V2");
+      expect(toolsIndexState.allCards).not.toContain("Asset Browser / Import Hub");
+      expect(toolsIndexState.allCards).not.toContain("Tile Model Converter");
       expect(toolsIndexState.plannedCards).toContain("Piper WASM Backend");
       expect(toolsIndexState.plannedCards).toContain("Optional SSML Processing Layer");
-      expect(toolsIndexState.plannedCards).toContain("Character Voice Presets");
-      expect(toolsIndexState.plannedCards).toContain("Game Character Voice / Event Integration");
+      expect(toolsIndexState.plannedCards).not.toContain("Character Voice Presets");
+      expect(toolsIndexState.plannedCards).not.toContain("Game Character Voice / Event Integration");
       expect(toolsIndexState.plannedCards).not.toEqual(expect.arrayContaining([
         "Raspberry Pi Speech Deployment",
         "Queue-Based Speech Playback",
@@ -1023,6 +1034,9 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       expect(toolsIndexState.viewersCards).toContain("Session Inspector V2");
       expect(toolsIndexState.viewersCards).not.toContain("Session Inspector");
       expect(toolsIndexState.workspaceActionLabels).toEqual(["How To Use", "Read Me"]);
+      expect(toolsIndexState.sessionInspectorActionClasses["How To Use"]).toBe(toolsIndexState.paletteManagerActionClasses["How To Use"]);
+      expect(toolsIndexState.sessionInspectorActionClasses["Read Me"]).toBe(toolsIndexState.paletteManagerActionClasses["Read Me"]);
+      expect(toolsIndexState.sessionInspectorActionClasses["How To Use"]).toBe("tools-platform-card__action tools-platform-card__action--secondary");
       expect(toolsIndexState.actionLabels).not.toContain("README");
       expect(toolsIndexState.sampleLabels.every((label) => /^Samples \(\d+\)$/.test(label))).toBe(true);
       expect(pageErrors).toEqual([]);
@@ -2116,8 +2130,8 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       await selectMockRepo(page);
       await page.locator("#activeGameSelect").selectOption("Asteroids");
       await expectWorkspaceReturnRehydrated(page);
-      expect(await page.evaluate(() => Object.hasOwn(window.__workspaceManagerV2App.activeContext.tools, "text2speech-V2"))).toBe(false);
-      expect(await page.evaluate(() => JSON.parse(sessionStorage.getItem("workspace.tools.text2speech-V2")).data)).toBeNull();
+      expect(await page.evaluate(() => Object.hasOwn(window.__workspaceManagerV2App.activeContext.tools, "text2speech-V2"))).toBe(true);
+      expect(await page.evaluate(() => JSON.parse(sessionStorage.getItem("workspace.tools.text2speech-V2")).data)).toEqual([]);
       const schemaContract = await page.evaluate(async () => {
         const schema = await fetch("/tools/schemas/tools/text2speech-V2.schema.json", { cache: "no-store" }).then((response) => response.json());
         return {
@@ -3198,7 +3212,8 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       await expect(textToSpeechToolTile).toBeEnabled();
       await expect(textToSpeechToolTile).toContainText("Text to Speech V2");
       await expect(textToSpeechToolTile).toContainText("Ready to launch");
-      await expect(textToSpeechToolTile).toContainText("Speech synthesis ready");
+      await expect(textToSpeechToolTile).toContainText("0 text to speech");
+      await expect(textToSpeechToolTile).not.toContainText("Speech synthesis ready");
       await expect(sessionInspectorTile).toBeEnabled();
       await expect(sessionInspectorTile).toContainText("Session Inspector V2");
       await expect(sessionInspectorTile).not.toContainText("Session storage inspector");
@@ -3692,7 +3707,8 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       await expect(textToSpeechToolTile).toBeEnabled();
       await expect(textToSpeechToolTile).toContainText("Text to Speech V2");
       await expect(textToSpeechToolTile).toContainText("Ready to launch");
-      await expect(textToSpeechToolTile).toContainText("Speech synthesis ready");
+      await expect(textToSpeechToolTile).toContainText("0 text to speech");
+      await expect(textToSpeechToolTile).not.toContainText("Speech synthesis ready");
       await expect(page.locator("#statusLog")).toHaveValue(/OK Hydrated workspace session for asset-manager-v2, palette-manager-v2, preview-generator-v2, text2speech-V2, session-inspector-v2\./);
       const textToSpeechSessionData = await page.evaluate(() => JSON.parse(sessionStorage.getItem("workspace.tools.text2speech-V2")).data);
       const activeContextHasTextToSpeechPayload = await page.evaluate(() => Object.hasOwn(window.__workspaceManagerV2App.activeContext.tools, "text2speech-V2"));
@@ -3737,6 +3753,17 @@ test.describe("Workspace Manager V2 bootstrap", () => {
         context.tools["text2speech-V2"] = payload;
         const validation = await app.contextService.validateGeneratedManifest(context);
         const hostContextId = app.contextService.writePersistedContext(app.activeHostContextId, context);
+        const session = JSON.parse(sessionStorage.getItem("workspace.tools.text2speech-V2"));
+        sessionStorage.setItem("workspace.tools.text2speech-V2", JSON.stringify({
+          ...session,
+          data: payload,
+          dirty: {
+            isDirty: false,
+            reason: null,
+            changedAt: null,
+            changedKeys: []
+          }
+        }));
         const metrics = app.contextSummaryMetrics(context);
         app.applyContextResult({
           assetCount: metrics.assetCount,
@@ -3748,6 +3775,8 @@ test.describe("Workspace Manager V2 bootstrap", () => {
         return { hostContextId, validation };
       }, TEXT_TO_SPEECH_SAMPLE_PRESET_PATH);
       expect(seededWorkspace.validation).toEqual({ ok: true });
+      await expect(page.locator('[data-workspace-tool-id="text2speech-V2"]')).toContainText("1 text to speech");
+      await expect(page.locator('[data-workspace-tool-id="text2speech-V2"]')).not.toContainText("Speech synthesis ready");
       expect(await page.evaluate(async () => {
         const app = window.__workspaceManagerV2App;
         const context = structuredClone(app.activeContext);
@@ -3768,6 +3797,8 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       await page.locator("#returnToWorkspaceButton").click();
       await expect(page).toHaveURL(new RegExp(`workspace-manager-v2/index\\.html\\?hostContextId=${seededWorkspace.hostContextId}`));
       await expectWorkspaceReturnedFromTool(page, { dirty: true });
+      await expect(page.locator('[data-workspace-tool-id="text2speech-V2"]')).toContainText("0 text to speech");
+      await expect(page.locator('[data-workspace-tool-id="text2speech-V2"]')).not.toContainText("Speech synthesis ready");
       const returnedState = await page.evaluate(() => {
         const session = JSON.parse(sessionStorage.getItem("workspace.tools.text2speech-V2"));
         const outputContext = JSON.parse(document.querySelector("#workspaceContextOutput").value);
@@ -3987,7 +4018,7 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       await expect(page.locator("#statusLog")).toHaveValue(/OK Saved path: games\/Asteroids\/game\.manifest\.json\./);
       await expect(page.locator("#statusLog")).toHaveValue(/OK Save write validation: file content changed\./);
       await expect(page.locator("#statusLog")).toHaveValue(/INFO Saved file size: \d+ bytes\./);
-      await expect(page.locator("#statusLog")).toHaveValue(/INFO Saved toolState items: (?:3 \(asset-manager-v2 assets=14; palette-manager-v2 swatches=11; vector-map-editor vectors=5\)|4 \(asset-manager-v2 assets=14; palette-manager-v2 swatches=11; text2speech-V2 queue=1; vector-map-editor vectors=5\))\./);
+      await expect(page.locator("#statusLog")).toHaveValue(/INFO Saved toolState items: (?:3 \(asset-manager-v2 assets=14; palette-manager-v2 swatches=11; vector-map-editor vectors=5\)|4 \(asset-manager-v2 assets=14; palette-manager-v2 swatches=11; text2speech-V2 queue=(?:0|1); vector-map-editor vectors=5\))\./);
       await expect(page.locator("#statusLog")).toHaveValue(/OK Save validation result: game manifest valid; root game\.workspace toolState valid; saved context matched re-read file\./);
       await expect(page.locator("#statusLog")).toHaveValue(/OK Save dirty\/clean validation: 1 dirty toolState payload persisted; 1 toolState key marked clean\./);
       await expect(page.locator("#statusLog")).toHaveValue(/OK Saved Workspace Manager V2 toolState context workspace-manager-v2-Asteroids\./);

tools/index.html

@@ -121,21 +121,6 @@ <h3>Optional SSML Processing Layer</h3>
           </div>
         </div>
 
-        <div class="card">
-          <h3>Character Voice Presets</h3>
-          <p>Plan character-oriented voice presets for reusable narrator, hero, villain, alert, and game role settings.</p>
-          <div class="meta">
-            <span class="pill planned">Planned</span>
-          </div>
-        </div>
-
-        <div class="card">
-          <h3>Game Character Voice / Event Integration</h3>
-          <p>Connect character voice presets to game events, prompts, menus, hazards, and in-game feedback triggers.</p>
-          <div class="meta">
-            <span class="pill planned">Planned</span>
-          </div>
-        </div>
       </div>
     </section>
 

tools/renderToolsIndex.js

@@ -3,6 +3,10 @@ import { escapeHtml } from "../src/shared/string/stringUtil.js";
 
 const SAMPLES_INDEX_PATH = "/samples/index.html";
 const SAMPLES_METADATA_PATH = "/samples/metadata/samples.index.metadata.json";
+const TOOLS_INDEX_HIDDEN_TOOL_IDS = Object.freeze(new Set([
+  "asset-browser",
+  "tile-model-converter"
+]));
 
 function toStandaloneHref(entryPoint) {
   const normalized = String(entryPoint || "").replace(/^\.?\/*/, "");
@@ -83,10 +87,8 @@ function classifyToolGroup(toolId) {
     "performance-profiler"
   ]);
   const utilityToolIds = new Set([
-    "asset-browser",
     "asset-manager-v2",
     "asset-pipeline",
-    "tile-model-converter",
     "physics-sandbox",
     "text2speech-V2",
     "3d-json-payload"
@@ -154,6 +156,7 @@ function renderActiveToolsList(sampleCountByToolId) {
     .filter((entry) => entry.active === true)
     .filter((entry) => entry.visibleInToolsList === true)
     .filter((entry) => entry.id !== "state-inspector")
+    .filter((entry) => !TOOLS_INDEX_HIDDEN_TOOL_IDS.has(entry.id))
     .sort((left, right) => String(left.displayName || "").localeCompare(String(right.displayName || "")));
 
   const workflow = tools.filter((tool) => classifyToolGroup(tool.id) === "workflow").map((tool) => renderToolCard(tool, sampleCountByToolId));

tools/workspace-manager-v2/js/WorkspaceManagerV2App.js

@@ -488,6 +488,7 @@
       : { context: result.context, toolSummaries: {} };
     const paletteSummary = sessionRefresh.toolSummaries["palette-manager-v2"] || {};
     const assetSummary = sessionRefresh.toolSummaries["asset-manager-v2"] || {};
+    const textToSpeechSummary = sessionRefresh.toolSummaries["text2speech-V2"] || {};
     const dirtyByToolId = Object.fromEntries(Object.entries(sessionRefresh.toolSummaries)
       .map(([toolId, summary]) => [toolId, summary.dirtyStatus || "unknown"]));
     const paletteSwatchCount = Number.isInteger(paletteSummary.paletteSwatchCount)
@@ -496,6 +497,9 @@
     const assetCount = Number.isInteger(assetSummary.assetCount)
       ? assetSummary.assetCount
       : result.assetCount;
+    const textToSpeechCount = Number.isInteger(textToSpeechSummary.speechQueueCount)
+      ? textToSpeechSummary.speechQueueCount
+      : 0;
     this.activeContext = sessionRefresh.context;
     this.activeGame = result.game;
     this.activeHostContextId = result.hostContextId || null;
@@ -517,7 +521,8 @@
       dirtyByToolId,
       enabledToolIds: hydration.ok ? hydration.hydratedToolIds : [],
       manifestStatus: this.activeToolStateRequiresRepoHandle ? "Repo folder required" : "Schema-valid manifest",
-      paletteSwatchCount
+      paletteSwatchCount,
+      textToSpeechCount
     });
     this.syncLifecycleControls();
   }

tools/workspace-manager-v2/js/controls/ToolTilesControl.js

@@ -18,7 +18,8 @@ export class ToolTilesControl {
       assetCount: 0,
       canLaunch: false,
       manifestStatus: "Waiting for manifest",
-      paletteSwatchCount: 0
+      paletteSwatchCount: 0,
+      textToSpeechCount: 0
     });
   }
 
@@ -28,7 +29,8 @@ export class ToolTilesControl {
     dirtyByToolId = {},
     enabledToolIds = [],
     manifestStatus = "Waiting for manifest",
-    paletteSwatchCount = 0
+    paletteSwatchCount = 0,
+    textToSpeechCount = 0
   } = {}) {
     const enabledToolIdSet = new Set(enabledToolIds);
     this.container.replaceChildren(...TOOL_GROUPS.map((group) => this.groupSection({
@@ -38,11 +40,12 @@ export class ToolTilesControl {
       enabledToolIdSet,
       group,
       manifestStatus,
-      paletteSwatchCount
+      paletteSwatchCount,
+      textToSpeechCount
     })));
   }
 
-  detailForTool(tool, { assetCount, manifestStatus, paletteSwatchCount }) {
+  detailForTool(tool, { assetCount, manifestStatus, paletteSwatchCount, textToSpeechCount }) {
     if (tool.id === "templates-v2") {
       return "Canonical V2 template";
     }
@@ -56,12 +59,12 @@ export class ToolTilesControl {
       return "";
     }
     if (tool.id === "text2speech-V2") {
-      return "Speech synthesis ready";
+      return `${textToSpeechCount} text to speech`;
     }
     return manifestStatus;
   }
 
-  groupSection({ assetCount, canLaunch, dirtyByToolId, enabledToolIdSet, group, manifestStatus, paletteSwatchCount }) {
+  groupSection({ assetCount, canLaunch, dirtyByToolId, enabledToolIdSet, group, manifestStatus, paletteSwatchCount, textToSpeechCount }) {
     const section = document.createElement("section");
     section.className = "workspace-manager-v2__tool-group";
     section.setAttribute("aria-label", `${group} tools`);
@@ -82,6 +85,7 @@ export class ToolTilesControl {
           enabledToolIdSet,
           manifestStatus,
           paletteSwatchCount,
+          textToSpeechCount,
           tool
         }));
       });
@@ -90,7 +94,7 @@ export class ToolTilesControl {
     return section;
   }
 
-  tile({ assetCount, canLaunch, dirtyByToolId, enabledToolIdSet, manifestStatus, paletteSwatchCount, tool }) {
+  tile({ assetCount, canLaunch, dirtyByToolId, enabledToolIdSet, manifestStatus, paletteSwatchCount, textToSpeechCount, tool }) {
     const isEnabledForGame = canLaunch && enabledToolIdSet.has(tool.id);
     const dirtyStatus = dirtyByToolId[tool.id] || "unknown";
     const button = document.createElement("button");
@@ -113,7 +117,7 @@ export class ToolTilesControl {
       ? "Ready to launch"
       : (canLaunch ? "Not enabled for game" : manifestStatus);
 
-    const detailText = this.detailForTool(tool, { assetCount, manifestStatus, paletteSwatchCount });
+    const detailText = this.detailForTool(tool, { assetCount, manifestStatus, paletteSwatchCount, textToSpeechCount });
 
     const actions = document.createElement("span");
     actions.className = "workspace-manager-v2__tool-tile-actions";