Enforce object ID as runtime SSoT and remove duplicate object asset identity - PR_26133_027-object-id-ssot-manifest-schema-cleanup

Author: DavidQ

docs/dev/reports/object_id_ssot_cleanup_report.md

@@ -0,0 +1,58 @@
+# Object ID SSoT Cleanup Report
+
+Task: PR_26133_027-object-id-ssot-manifest-schema-cleanup
+Date: 2026-05-13
+
+## Runtime Identity Contract
+
+Object IDs are the single source of truth for Object Vector runtime/gameplay identity. Object Vector Studio V2 assetLibrary entries now use the runtime object ID directly in `id`, and duplicate runtime alias fields are rejected.
+
+Preferred Object Vector assetLibrary entry shape is now:
+
+```json
+{
+  "id": "object.asteroids.ship",
+  "name": "Asteroids Ship",
+  "tags": ["player", "ship"]
+}
+```
+
+## Removed Or Replaced
+
+- Removed `objectId` from `workspace.tools.object-vector-studio-v2.assetLibrary.assets[*]` in `games/Asteroids/game.manifest.json`.
+- Replaced redundant `asset.asteroids.*` Object Vector assetLibrary IDs with matching `object.asteroids.*` IDs.
+- Updated Object Vector Studio V2 editor logic so rename/delete/runtime preview/dependency graph behavior follows `asset.id` as the object ID.
+- Updated runtime asset validation and normalization so Object Vector assetLibrary entries cannot carry duplicate `objectId` aliases.
+
+## What Remains And Why
+
+- `object.asteroids.*` remains under `game.gameData.objectVectorRuntime.objectIds` and Object Vector Studio V2 object records because those are runtime object identities.
+- `vector.asteroids.*` remains only in vector-document/editor scoped data and is not used as runtime object identity.
+- `assets.*` asset-manager IDs remain for true media/file assets such as audio, image, and font records.
+- No `asset.asteroids.*` runtime Object Vector identity remains in active Asteroids runtime/editor payloads.
+
+## Schema And Validation
+
+- `tools/schemas/tools/object-vector-studio-v2.schema.json` no longer requires or permits `libraryAsset.objectId`.
+- Object Vector Studio V2 validation now requires each library entry `id` to reference an existing object.
+- Object Vector runtime validation now follows the same library ID/object ID contract.
+- Playwright coverage includes explicit rejection for:
+  - `assetLibrary.assets[*].objectId`
+  - `assetLibrary.assets[*].id` values that do not resolve to an existing object ID
+
+## Editor Controls
+
+- Triangle-labeled Object Vector polygon shapes hide Add Point and Delete Point controls.
+- Editable non-triangle polygons retain Add Point and Delete Point behavior.
+- Duplicate Frame renders between Frame Earlier and Frame Later.
+
+## Validation
+
+- PASS - Asteroids game manifest validates against the updated schema.
+- PASS - Asteroids small asteroid resolves by `objectId: object.asteroids.asteroid.small`.
+- PASS - Object Vector Studio V2 loads Asteroids objects through `object.*` IDs.
+- PASS - Object Vector Studio V2 rejects duplicate runtime alias fields in assetLibrary entries.
+- PASS - Active Asteroids runtime/editor payloads have no `asset.asteroids.*` Object Vector runtime identity.
+- PASS - Triangle/non-triangle polygon controls verified in Playwright.
+- PASS - Duplicate Frame ordering verified in Playwright.
+- PASS - `npm run test:workspace-v2` completed with 49 passed.

docs/dev/reports/playwright_v8_coverage_report.md

@@ -1,6 +1,6 @@
-# PR_26133_026 Playwright V8 Coverage Report
+# PR_26133_027 Playwright V8 Coverage Report
 
-Task: PR_26133_026-object-id-ssot-schema-and-editor-controls
+Task: PR_26133_027-object-id-ssot-manifest-schema-cleanup
 Date: 2026-05-13
 
 ## Result
@@ -24,17 +24,18 @@ PASS - Coverage reporting was generated during `npm run test:workspace-v2`.
 ## Changed Runtime JS Coverage
 
 - `tools/object-vector-studio-v2/js/ToolStarterApp.js`: 94% function coverage, 4190/4190 reported lines executed, 452/483 reported functions executed.
-- `games/Asteroids/game/AsteroidsGameScene.js`: 52% function coverage, 846/846 reported lines executed, 25/48 reported functions executed.
-- `tools/shared/asteroidsPlatformDemo.js`: not collected by Playwright V8 coverage; covered by focused node test `AsteroidsPlatformDemo.test.mjs`.
+- `tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js`: 95% function coverage, 411/411 reported lines executed, 53/56 reported functions executed.
+- `src/engine/rendering/ObjectVectorRuntimeAssetService.js`: 98% function coverage, 916/916 reported lines executed, 106/108 reported functions executed.
 
 ## PR-Specific Coverage/Validation Relevance
 
 The workspace-v2 run exercises the Object Vector Studio V2 editor and Asteroids runtime paths changed in this PR:
 
-- triangle geometry layout and controls,
-- frame control ordering,
-- objectId-based Asteroids Object Vector runtime rendering,
-- Workspace Manager game manifest schema loading and validation,
-- Object Vector Studio V2 loading of Asteroids workspace objects.
+- Object Vector Studio V2 schema rejection for duplicate runtime identity aliases.
+- Object Vector Studio V2 assetLibrary hydration through `object.*` IDs.
+- Asset library inheritance and runtime preview resolution through object IDs.
+- Asteroids runtime Object Vector rendering through `object.asteroids.*` IDs.
+- Triangle/non-triangle polygon point control behavior.
+- Duplicate Frame control ordering.
 
 Generated source report: `docs/dev/reports/playwright_v8_coverage_report.txt`.

docs/dev/reports/playwright_workspace_v2_results.md

@@ -1,6 +1,6 @@
-# PR_26133_026 Workspace V2 Validation
+# PR_26133_027 Workspace V2 Validation
 
-Task: PR_26133_026-object-id-ssot-schema-and-editor-controls
+Task: PR_26133_027-object-id-ssot-manifest-schema-cleanup
 Date: 2026-05-13
 
 ## Result
@@ -9,32 +9,27 @@ PASS - `npm run test:workspace-v2`
 
 - 49 Playwright tests passed.
 - Focused Object Vector Studio V2 checks passed before the full run.
-- Asteroids runtime Object Vector rendering passed with objectId-based lookup.
+- Asteroids manifest schema validation passed after the assetLibrary cleanup.
 - No sample JSON files were changed.
 
 ## Targeted Verification
 
+- PASS - Object Vector Studio V2 assetLibrary entries use `object.*` IDs and do not carry duplicate `objectId` fields.
+- PASS - Duplicate runtime identity aliases fail Object Vector Studio V2 schema validation.
+- PASS - Asteroids runtime resolves the small asteroid through `object.asteroids.asteroid.small`.
+- PASS - Object Vector Studio V2 loads Asteroids objects through `object.*` IDs.
+- PASS - Active Asteroids Object Vector runtime rendering uses object IDs for ship, asteroid, and UFO paths.
 - PASS - Triangle Geometry hides Add Point and Delete Point controls.
-- PASS - Non-triangle polygon geometry keeps Add Point and Delete Point controls.
+- PASS - Non-triangle polygon geometry keeps Add Point and Delete Point behavior.
 - PASS - Frame controls render as Frame Earlier, Duplicate Frame, Frame Later.
-- PASS - Asteroids runtime renders ship, asteroid, and UFO Object Vector objects using object.asteroids.* IDs.
-- PASS - Asteroids small asteroid resolves through objectId object.asteroids.asteroid.small.
-- PASS - Object Vector Studio V2 still loads Asteroids objects from workspace.tools.object-vector-studio-v2.
-- PASS - game.gameData.objectVectorRuntime.objectIds contains only object.* runtime references.
 - PASS - No runtime console/page errors were reported by the targeted Playwright coverage.
 
 ## Commands
 
+- PASS - `node --check src/engine/rendering/ObjectVectorRuntimeAssetService.js`
 - PASS - `node --check tools/object-vector-studio-v2/js/ToolStarterApp.js`
-- PASS - `node --check games/Asteroids/game/AsteroidsGameScene.js`
-- PASS - `node --check tools/shared/asteroidsPlatformDemo.js`
+- PASS - `node --check tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js`
 - PASS - `node --check tests/playwright/tools/WorkspaceManagerV2.spec.mjs`
-- PASS - `node -e "JSON.parse(...)"` for schema and Asteroids manifest.
-- PASS - WorkspaceManagerV2ContextService game manifest validation script.
-- PASS - ObjectVectorRuntimeAssetService objectId lookup script for object.asteroids.asteroid.small.
-- PASS - `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list -g "compacts Object Vector Studio V2 geometry layouts|supports Object Vector Studio V2 animation states|loads Object Vector Studio V2 runtime assets"`
+- PASS - Asteroids manifest schema and runtime object ID probe with `WorkspaceManagerV2ContextService` and `ObjectVectorRuntimeAssetService`.
+- PASS - `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list --grep "schema-only palette gate|geometry layouts|animation states|asset library inheritance|runtime assets into Asteroids|header lifecycle"`
 - PASS - `npm run test:workspace-v2`
-
-## Notes
-
-Asset IDs remain in Object Vector Studio V2 assetLibrary as editor/library asset entries. Runtime game selection now uses object IDs directly.

games/Asteroids/game.manifest.json

@@ -225,39 +225,33 @@
           "assetLibrary": {
             "assets": [
               {
-                "id": "asset.asteroids.ship",
+                "id": "object.asteroids.ship",
                 "name": "Asteroids Ship",
-                "objectId": "object.asteroids.ship",
                 "tags": ["player", "ship"]
               },
               {
-                "id": "asset.asteroids.asteroid.large",
+                "id": "object.asteroids.asteroid.large",
                 "name": "Large Asteroid",
-                "objectId": "object.asteroids.asteroid.large",
                 "tags": ["asteroid", "large"]
               },
               {
-                "id": "asset.asteroids.asteroid.medium",
+                "id": "object.asteroids.asteroid.medium",
                 "name": "Medium Asteroid",
-                "objectId": "object.asteroids.asteroid.medium",
                 "tags": ["asteroid", "medium"]
               },
               {
-                "id": "asset.asteroids.asteroid.small",
+                "id": "object.asteroids.asteroid.small",
                 "name": "Small Asteroid",
-                "objectId": "object.asteroids.asteroid.small",
                 "tags": ["asteroid", "small"]
               },
               {
-                "id": "asset.asteroids.ufo.large",
+                "id": "object.asteroids.ufo.large",
                 "name": "Large UFO",
-                "objectId": "object.asteroids.ufo.large",
                 "tags": ["ufo", "large"]
               },
               {
-                "id": "asset.asteroids.ufo.small",
+                "id": "object.asteroids.ufo.small",
                 "name": "Small UFO",
-                "objectId": "object.asteroids.ufo.small",
                 "tags": ["ufo", "small"]
               }
             ]

src/engine/rendering/ObjectVectorRuntimeAssetService.js

@@ -298,9 +298,9 @@ export class ObjectVectorRuntimeAssetService {
     });
     (payload.assetLibrary?.assets || []).forEach((asset) => {
       assetsById.set(asset.id, asset);
-      const usage = assetUsageByObjectId.get(asset.objectId) || [];
+      const usage = assetUsageByObjectId.get(asset.id) || [];
       usage.push(asset.id);
-      assetUsageByObjectId.set(asset.objectId, usage);
+      assetUsageByObjectId.set(asset.id, usage);
     });
     return {
       assetUsageByObjectId,
@@ -331,8 +331,8 @@ export class ObjectVectorRuntimeAssetService {
         this.log("FAIL", `Object Vector runtime asset resolution failed: assetId=${assetId} is missing from the asset library.`);
         return null;
       }
-      resolvedObjectId = asset.objectId;
-      this.logCacheOnce(`asset:${assetSet.sourceLabel}:${assetId}`, `Object Vector runtime asset ${assetId} resolved to ${resolvedObjectId}.`);
+      resolvedObjectId = asset.id;
+      this.logCacheOnce(`asset:${assetSet.sourceLabel}:${assetId}`, `Object Vector runtime library id ${assetId} resolved to object ${resolvedObjectId}.`);
     }
 
     let object = resolvedObjectId ? assetSet.objectsById.get(resolvedObjectId) : null;
@@ -657,6 +657,9 @@ export class ObjectVectorRuntimeAssetService {
     if (Object.prototype.hasOwnProperty.call(schema.$defs?.object?.properties || {}, "type")) {
       errors.push("Object Vector Studio V2 object schema must not define object type.");
     }
+    if (Object.prototype.hasOwnProperty.call(schema.$defs?.libraryAsset?.properties || {}, "objectId")) {
+      errors.push("Object Vector Studio V2 library asset schema must not define objectId.");
+    }
   }
 
   validatePayload(payload) {
@@ -737,8 +740,8 @@ export class ObjectVectorRuntimeAssetService {
         errors.push(`root.assetLibrary.assets[${assetIndex}].id ${asset.id} duplicates an existing library asset id.`);
       }
       assetIds.add(asset.id);
-      if (!objectsById.has(asset.objectId)) {
-        errors.push(`root.assetLibrary.assets[${assetIndex}].objectId ${asset.objectId} must reference an existing object.`);
+      if (!objectsById.has(asset.id)) {
+        errors.push(`root.assetLibrary.assets[${assetIndex}].id ${asset.id} must reference an existing object.`);
       }
     });
   }
@@ -920,7 +923,6 @@ export class ObjectVectorRuntimeAssetService {
         assets: normalized.assetLibrary.assets.map((asset) => ({
           id: asset.id.trim(),
           name: asset.name.trim(),
-          objectId: asset.objectId.trim(),
           tags: asset.tags.map((tag) => tag.trim()).filter(Boolean)
         }))
       };