Enforce object ID as runtime SSoT and clean up triangle and frame controls - PR_26133_026-object-id-ssot-schema-and-editor-controls

Author: DavidQ

docs/dev/reports/object_id_ssot_migration_report.md

@@ -0,0 +1,41 @@
+# Object ID SSoT Migration Report
+
+Task: PR_26133_026-object-id-ssot-schema-and-editor-controls
+Date: 2026-05-13
+
+## Runtime Identity Contract
+
+Object IDs are now the single source of truth for Asteroids Object Vector runtime identity. Runtime game selection uses `object.asteroids.*` IDs directly instead of resolving through `asset.asteroids.*` IDs or `vector.asteroids.*` editor IDs.
+
+## Removed Or Replaced Runtime Identity
+
+- Replaced Asteroids scene constants that selected `asset.asteroids.*` with `object.asteroids.*` constants.
+- Replaced Asteroids scene render calls from `assetId` to `objectId` for ship, asteroid sizes, and UFO sizes.
+- Replaced Asteroids platform demo runtime visual preference `vectorIds` with runtime `objectIds`.
+
+## What Remains And Why
+
+- `asset.asteroids.*` remains in `workspace.tools.object-vector-studio-v2.assetLibrary` because those entries are editor/library assets that map to Object Vector objects. Runtime scene selection no longer depends on them.
+- `vector.asteroids.*` remains in `workspace.tools.vector-map-editor.vectorMapDocument.vectors` and vector document asset refs because those are editor/vector-document geometry IDs, not game runtime object identities.
+- Object Vector object records remain under `workspace.tools.object-vector-studio-v2.objects`; the runtime loader resolves these objects by object ID.
+
+## Schema Changes
+
+- Added `game.gameData.objectVectorRuntime.objectIds` to `tools/schemas/game.manifest.schema.json`.
+- The schema constrains runtime object references with the `^object\.` identity pattern so asset IDs and vector IDs are rejected when this contract is used.
+- Updated `games/Asteroids/game.manifest.json` to declare ship, asteroid, and UFO runtime object IDs in `game.gameData.objectVectorRuntime.objectIds`.
+
+## Editor Controls
+
+- Triangle-labeled Object Vector polygon shapes hide Add Point, Delete Point, and point selection controls.
+- Editable non-triangle polygons retain Add Point and Delete Point behavior.
+- Duplicate Frame now renders between Frame Earlier and Frame Later.
+
+## Validation
+
+- PASS - Asteroids game manifest validates against the updated schema.
+- PASS - Asteroids small asteroid resolves by `objectId: object.asteroids.asteroid.small`.
+- PASS - Object Vector Studio V2 loads Asteroids objects.
+- PASS - Triangle/non-triangle polygon controls verified in Playwright.
+- PASS - Duplicate Frame ordering verified in Playwright.
+- PASS - `npm run test:workspace-v2` completed with 49 passed.

docs/dev/reports/playwright_v8_coverage_report.md

@@ -1,6 +1,6 @@
-# PR_26133_025 Playwright V8 Coverage Report
+# PR_26133_026 Playwright V8 Coverage Report
 
-Task: PR_26133_025-object-vector-studio-dirty-state-save-tracking
+Task: PR_26133_026-object-id-ssot-schema-and-editor-controls
 Date: 2026-05-13
 
 ## Result
@@ -23,17 +23,18 @@ PASS - Coverage reporting was generated during `npm run test:workspace-v2`.
 
 ## Changed Runtime JS Coverage
 
-- `tools/object-vector-studio-v2/js/ToolStarterApp.js`: 94% function coverage, 4171/4171 reported lines executed, 450/481 reported functions executed.
+- `tools/object-vector-studio-v2/js/ToolStarterApp.js`: 94% function coverage, 4190/4190 reported lines executed, 452/483 reported functions executed.
+- `games/Asteroids/game/AsteroidsGameScene.js`: 52% function coverage, 846/846 reported lines executed, 25/48 reported functions executed.
+- `tools/shared/asteroidsPlatformDemo.js`: not collected by Playwright V8 coverage; covered by focused node test `AsteroidsPlatformDemo.test.mjs`.
 
 ## PR-Specific Coverage/Validation Relevance
 
-The new Workspace Manager V2 Playwright coverage exercises the Object Vector Studio V2 workspace dirty contract end to end:
+The workspace-v2 run exercises the Object Vector Studio V2 editor and Asteroids runtime paths changed in this PR:
 
-- clean startup session state,
-- selection/preview actions remaining clean,
-- every requested persisted edit category marking the Object Vector session dirty,
-- Workspace Manager Save becoming enabled after return,
-- invalid save preserving dirty state without manifest writes,
-- successful save clearing dirty state only after verified write-back.
+- triangle geometry layout and controls,
+- frame control ordering,
+- objectId-based Asteroids Object Vector runtime rendering,
+- Workspace Manager game manifest schema loading and validation,
+- Object Vector Studio V2 loading of Asteroids workspace objects.
 
 Generated source report: `docs/dev/reports/playwright_v8_coverage_report.txt`.

docs/dev/reports/playwright_workspace_v2_results.md

@@ -1,40 +1,40 @@
-# PR_26133_025 Workspace V2 Validation
+# PR_26133_026 Workspace V2 Validation
 
-Task: PR_26133_025-object-vector-studio-dirty-state-save-tracking
+Task: PR_26133_026-object-id-ssot-schema-and-editor-controls
 Date: 2026-05-13
 
 ## Result
 
 PASS - `npm run test:workspace-v2`
 
 - 49 Playwright tests passed.
-- Focused Object Vector Studio V2 dirty-state test passed before the full run.
-- No console/runtime page errors were reported by the new dirty-state coverage.
+- Focused Object Vector Studio V2 checks passed before the full run.
+- Asteroids runtime Object Vector rendering passed with objectId-based lookup.
 - No sample JSON files were changed.
 
-## Targeted Object Vector Studio V2 Verification
-
-- PASS - Object Vector Studio V2 workspace launches start with `workspace.tools.object-vector-studio-v2.dirty.isDirty=false`.
-- PASS - Selection-only changes do not mark the workspace tool session dirty.
-- PASS - Preview-only actions tested through zoom, pan, and grid visibility do not change persisted Object Vector data or dirty state.
-- PASS - Persisted object edits mark `workspace.tools.object-vector-studio-v2` dirty.
-- PASS - Persisted object geometry edits mark dirty.
-- PASS - Persisted object transform edits mark dirty.
-- PASS - Persisted palette/color application marks dirty.
-- PASS - Shape add, visibility, lock/unlock, and delete edits mark dirty.
-- PASS - Object add, rename, duplicate, and delete edits mark dirty.
-- PASS - Returning to Workspace Manager V2 enables Save and marks the Object Vector Studio V2 tile dirty.
-- PASS - Failed invalid save keeps dirty state active and does not write a manifest.
-- PASS - Successful save clears dirty state only after verified manifest write-back.
+## Targeted Verification
+
+- PASS - Triangle Geometry hides Add Point and Delete Point controls.
+- PASS - Non-triangle polygon geometry keeps Add Point and Delete Point controls.
+- PASS - Frame controls render as Frame Earlier, Duplicate Frame, Frame Later.
+- PASS - Asteroids runtime renders ship, asteroid, and UFO Object Vector objects using object.asteroids.* IDs.
+- PASS - Asteroids small asteroid resolves through objectId object.asteroids.asteroid.small.
+- PASS - Object Vector Studio V2 still loads Asteroids objects from workspace.tools.object-vector-studio-v2.
+- PASS - game.gameData.objectVectorRuntime.objectIds contains only object.* runtime references.
+- PASS - No runtime console/page errors were reported by the targeted Playwright coverage.
 
 ## Commands
 
 - PASS - `node --check tools/object-vector-studio-v2/js/ToolStarterApp.js`
+- PASS - `node --check games/Asteroids/game/AsteroidsGameScene.js`
+- PASS - `node --check tools/shared/asteroidsPlatformDemo.js`
 - PASS - `node --check tests/playwright/tools/WorkspaceManagerV2.spec.mjs`
-- PASS - `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list -g "tracks Object Vector Studio V2 dirty state"`
+- PASS - `node -e "JSON.parse(...)"` for schema and Asteroids manifest.
+- PASS - WorkspaceManagerV2ContextService game manifest validation script.
+- PASS - ObjectVectorRuntimeAssetService objectId lookup script for object.asteroids.asteroid.small.
+- PASS - `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list -g "compacts Object Vector Studio V2 geometry layouts|supports Object Vector Studio V2 animation states|loads Object Vector Studio V2 runtime assets"`
 - PASS - `npm run test:workspace-v2`
-- PASS - `git diff --check HEAD` completed with line-ending warnings only.
 
 ## Notes
 
-The full workspace-v2 run produced transient Asteroids manifest write-back output from existing save tests. That generated file noise was restored after validation; the final tracked diff contains only Object Vector Studio V2 dirty tracking and its Playwright test coverage.
+Asset IDs remain in Object Vector Studio V2 assetLibrary as editor/library asset entries. Runtime game selection now uses object IDs directly.

games/Asteroids/game.manifest.json

@@ -11,6 +11,16 @@
         "directPath": "/games/Asteroids/index.html",
         "workspaceManagerPath": "/tools/workspace-manager-v2/index.html?gameId=Asteroids",
         "workspaceManagerOptional": true
+      },
+      "objectVectorRuntime": {
+        "objectIds": {
+          "ship": "object.asteroids.ship",
+          "asteroidLarge": "object.asteroids.asteroid.large",
+          "asteroidMedium": "object.asteroids.asteroid.medium",
+          "asteroidSmall": "object.asteroids.asteroid.small",
+          "ufoLarge": "object.asteroids.ufo.large",
+          "ufoSmall": "object.asteroids.ufo.small"
+        }
       }
     },
     "workspace": {

games/Asteroids/game/AsteroidsGameScene.js

@@ -25,16 +25,16 @@ const SCORE_TWO_X = 824;
 const LIFE_SPACING = 22;
 const PAUSE_OVERLAY_COLOR = 'rgba(2, 6, 23, 0.58)';
 const INITIALS_OVERLAY_COLOR = 'rgba(1, 6, 19, 0.62)';
-const ASTEROID_OBJECT_VECTOR_ASSET_IDS = Object.freeze({
-  1: "asset.asteroids.asteroid.small",
-  2: "asset.asteroids.asteroid.medium",
-  3: "asset.asteroids.asteroid.large",
+const ASTEROID_OBJECT_VECTOR_OBJECT_IDS = Object.freeze({
+  1: "object.asteroids.asteroid.small",
+  2: "object.asteroids.asteroid.medium",
+  3: "object.asteroids.asteroid.large",
 });
-const UFO_OBJECT_VECTOR_ASSET_IDS = Object.freeze({
-  large: "asset.asteroids.ufo.large",
-  small: "asset.asteroids.ufo.small",
+const UFO_OBJECT_VECTOR_OBJECT_IDS = Object.freeze({
+  large: "object.asteroids.ufo.large",
+  small: "object.asteroids.ufo.small",
 });
-const SHIP_OBJECT_VECTOR_ASSET_ID = "asset.asteroids.ship";
+const SHIP_OBJECT_VECTOR_OBJECT_ID = "object.asteroids.ship";
 const LIFE_ICON_POINTS = [
   [14, 0],
   [-10, -8],
@@ -735,7 +735,7 @@ export default class AsteroidsGameScene extends Scene {
       this.drawObjectVectorAsset(renderer, "asteroids", {
         elapsedMs: this.objectVectorPlaybackMs,
         fps: 12,
-        assetId: ASTEROID_OBJECT_VECTOR_ASSET_IDS[asteroid.size],
+        objectId: ASTEROID_OBJECT_VECTOR_OBJECT_IDS[asteroid.size],
         rotation: asteroid.angle,
         stateId: "active",
         x: asteroid.x,
@@ -747,7 +747,7 @@ export default class AsteroidsGameScene extends Scene {
       this.drawObjectVectorAsset(renderer, "ufo", {
         elapsedMs: this.objectVectorPlaybackMs,
         fps: 12,
-        assetId: UFO_OBJECT_VECTOR_ASSET_IDS[this.world.ufo.type],
+        objectId: UFO_OBJECT_VECTOR_OBJECT_IDS[this.world.ufo.type],
         stateId: "active",
         x: this.world.ufo.x,
         y: this.world.ufo.y,
@@ -768,7 +768,7 @@ export default class AsteroidsGameScene extends Scene {
       this.drawObjectVectorAsset(renderer, "ship", {
         elapsedMs: this.objectVectorPlaybackMs,
         fps: 12,
-        assetId: SHIP_OBJECT_VECTOR_ASSET_ID,
+        objectId: SHIP_OBJECT_VECTOR_OBJECT_ID,
         rotation: this.world.ship.angle + Math.PI / 2,
         stateId: this.world.ship.thrusting && this.session.mode === 'playing' ? "thrust" : "idle",
         x: this.world.ship.x,

tests/playwright/tools/WorkspaceManagerV2.spec.mjs

@@ -2890,6 +2890,8 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       await expect(page.locator("#objectVectorStudioV2ObjectGeometrySummary")).toHaveText("(triangle)");
       await expect(page.locator("#objectVectorStudioV2ObjectGeometryName")).toHaveText(/polygon-\d+/);
       await expect(page.locator("#objectVectorStudioV2ObjectDetails")).not.toContainText(/Shape\s*polygon-\d+ \(triangle\)/);
+      await expect(page.locator("#objectVectorStudioV2ObjectDetails [data-polygon-side-action]")).toHaveCount(0);
+      await expect(page.locator("#objectVectorStudioV2ObjectDetails [data-polygon-point-select='true']")).toHaveCount(0);
 
       expect(pageErrors).toEqual([]);
       expect(consoleErrors).toEqual([]);
@@ -3333,6 +3335,7 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       await expect(page.locator("#objectVectorStudioV2ObjectDetails")).not.toContainText("ship-template-hull");
       await expect(page.locator("#objectVectorStudioV2ObjectGeometrySummary")).toHaveText("(polygon)");
       await expect(page.locator("#objectVectorStudioV2ObjectGeometryName")).toHaveText("ship-template-hull");
+      await expect(page.locator("[aria-label='Frame controls'] button")).toHaveText(["Frame Earlier", "Duplicate Frame", "Frame Later"]);
 
       await page.locator("#objectVectorStudioV2DuplicateFrameButton").click();
       await expect(page.locator("#objectVectorStudioV2FrameTimeline [data-state-id='idle']")).toHaveCount(2);
@@ -4042,8 +4045,10 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       expect(diagnostics.renderCounts.ufo).toBeGreaterThan(0);
       const eventMessages = diagnostics.events.map((entry) => entry.message).join("\n");
       expect(eventMessages).toContain("Object Vector runtime asset load from Asteroids game.manifest.json:tools.object-vector-studio-v2: 6 objects.");
-      expect(eventMessages).toContain("Object Vector runtime asset asset.asteroids.ship resolved to object.asteroids.ship.");
-      expect(eventMessages).toContain("Object Vector runtime asset asset.asteroids.ufo.small resolved to object.asteroids.ufo.small.");
+      expect(eventMessages).toContain("Object Vector runtime cache miss for object.asteroids.ship; cached resolved object.");
+      expect(eventMessages).toContain("Object Vector runtime cache miss for object.asteroids.ufo.small; cached resolved object.");
+      expect(eventMessages).not.toContain("Object Vector runtime asset asset.asteroids.ship resolved to object.asteroids.ship.");
+      expect(eventMessages).not.toContain("Object Vector runtime asset asset.asteroids.ufo.small resolved to object.asteroids.ufo.small.");
       expect(eventMessages).toContain("Object Vector runtime frame resolved: object.asteroids.ship idle/idle-frame-1.");
       expect(eventMessages).toContain("Object Vector runtime rendered object.asteroids.ship: 1 shapes state=idle frame=idle-frame-1.");
       expect(eventMessages).toContain("Object Vector runtime rendered object.asteroids.ufo.small: 2 shapes state=active frame=active-frame-1.");
@@ -6395,6 +6400,15 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       expect(asteroidsManifest.documentKind).toBeUndefined();
       expect(asteroidsManifest.tools).toBeUndefined();
       expect(asteroidsManifest.game.gameData.launch.directPath).toBe("/games/Asteroids/index.html");
+      expect(asteroidsManifest.game.gameData.objectVectorRuntime.objectIds).toEqual({
+        asteroidLarge: "object.asteroids.asteroid.large",
+        asteroidMedium: "object.asteroids.asteroid.medium",
+        asteroidSmall: "object.asteroids.asteroid.small",
+        ship: "object.asteroids.ship",
+        ufoLarge: "object.asteroids.ufo.large",
+        ufoSmall: "object.asteroids.ufo.small"
+      });
+      expect(Object.values(asteroidsManifest.game.gameData.objectVectorRuntime.objectIds).every((id) => id.startsWith("object."))).toBe(true);
       const manifestWorkspace = asteroidsManifest.game.workspace;
       expect(manifestWorkspace.documentKind).toBe("workspace-manifest");
       expect(Object.keys(manifestWorkspace.tools).sort()).toEqual(expect.arrayContaining(["asset-manager-v2", "object-vector-studio-v2", "palette-manager-v2", "vector-map-editor"]));

tools/object-vector-studio-v2/index.html

@@ -157,8 +157,8 @@ <h2 class="tools-platform-frame__eyebrow">First-Class Tools Surface V2</h2>
                 </label>
               </div>
               <div class="object-vector-studio-v2__animation-controls" aria-label="Frame controls">
-                <button id="objectVectorStudioV2DuplicateFrameButton" type="button" disabled title="Disabled until a state frame is selected">Duplicate Frame</button>
                 <button id="objectVectorStudioV2FrameEarlierButton" type="button" disabled title="Disabled until the selected frame can move earlier">Frame Earlier</button>
+                <button id="objectVectorStudioV2DuplicateFrameButton" type="button" disabled title="Disabled until a state frame is selected">Duplicate Frame</button>
                 <button id="objectVectorStudioV2FrameLaterButton" type="button" disabled title="Disabled until the selected frame can move later">Frame Later</button>
               </div>
               <div id="objectVectorStudioV2FrameTimeline" class="object-vector-studio-v2__frame-timeline" aria-label="Frame timeline"></div>