Skip to content

Commit 818fb4d

Browse files
author
DavidQ
committed
Add final coverage, review evidence, HTML handler, ZIP return, and tool registration rules - PR_26126_060-project-instructions-final-gaps
1 parent 96b61fa commit 818fb4d

2 files changed

Lines changed: 99 additions & 0 deletions

File tree

docs/dev/PROJECT_INSTRUCTIONS.md

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -618,3 +618,43 @@ Do NOT require:
618618
- full feature coverage
619619
- 100% code coverage
620620
- performance requirements
621+
622+
## CODE COVERAGE CONTRACT
623+
624+
When runtime JavaScript changes, Codex must produce a Playwright V8 coverage report.
625+
626+
The coverage report must list changed runtime JavaScript files.
627+
628+
Coverage report lines must start with coverage percentage in this format:
629+
630+
`(xx%) <file-path> - <details>`
631+
632+
Coverage is advisory unless a PR explicitly defines thresholds.
633+
634+
Do not require 100% coverage.
635+
636+
## CODEX ZIP RETURN CONTRACT
637+
638+
Codex must include the repo-structured ZIP in returned artifacts for user and ChatGPT review.
639+
640+
The ZIP must still follow the CODEX ZIP STANDARD.
641+
642+
## CODE REVIEW EVIDENCE RULE
643+
644+
ChatGPT must not claim code review was completed unless it inspected uploaded source, ZIP contents, or `codex_review.diff`.
645+
646+
Pattern-based or process-based review must be labeled as such.
647+
648+
## HTML INLINE HANDLER RESTRICTION
649+
650+
HTML must not contain inline event handlers such as `onclick`, `onchange`, `oninput`, `onsubmit`, or similar.
651+
652+
Event wiring must live in external JavaScript classes or modules.
653+
654+
## FIRST-CLASS TOOL REGISTRATION RULE
655+
656+
New first-class tools must include registry, index, and NAV wiring where applicable.
657+
658+
New first-class tools must include Playwright launch coverage.
659+
660+
Tool registration must not rely on hidden defaults or silent fallback.
Lines changed: 59 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,59 @@
1+
PR_26126_060-project-instructions-final-gaps
2+
3+
Purpose:
4+
Append final project instruction gaps for code coverage, ZIP return wording, review evidence, HTML inline handler restrictions, and first-class tool registration.
5+
6+
Appended sections:
7+
8+
## CODE COVERAGE CONTRACT
9+
10+
When runtime JavaScript changes, Codex must produce a Playwright V8 coverage report.
11+
12+
The coverage report must list changed runtime JavaScript files.
13+
14+
Coverage report lines must start with coverage percentage in this format:
15+
16+
`(xx%) <file-path> - <details>`
17+
18+
Coverage is advisory unless a PR explicitly defines thresholds.
19+
20+
Do not require 100% coverage.
21+
22+
## CODEX ZIP RETURN CONTRACT
23+
24+
Codex must include the repo-structured ZIP in returned artifacts for user and ChatGPT review.
25+
26+
The ZIP must still follow the CODEX ZIP STANDARD.
27+
28+
## CODE REVIEW EVIDENCE RULE
29+
30+
ChatGPT must not claim code review was completed unless it inspected uploaded source, ZIP contents, or `codex_review.diff`.
31+
32+
Pattern-based or process-based review must be labeled as such.
33+
34+
## HTML INLINE HANDLER RESTRICTION
35+
36+
HTML must not contain inline event handlers such as `onclick`, `onchange`, `oninput`, `onsubmit`, or similar.
37+
38+
Event wiring must live in external JavaScript classes or modules.
39+
40+
## FIRST-CLASS TOOL REGISTRATION RULE
41+
42+
New first-class tools must include registry, index, and NAV wiring where applicable.
43+
44+
New first-class tools must include Playwright launch coverage.
45+
46+
Tool registration must not rely on hidden defaults or silent fallback.
47+
48+
49+
Validation notes:
50+
- docs/dev/PROJECT_INSTRUCTIONS.md was the only target document edited.
51+
- Existing content was preserved; new sections were appended at the end of the file.
52+
- No roadmap, code, samples, schema, or start_of_day files were modified for this PR.
53+
- Playwright impacted: No.
54+
- No Playwright impact. This PR is docs/workflow only.
55+
56+
Manual test notes:
57+
- Open docs/dev/PROJECT_INSTRUCTIONS.md and confirm the new final-gap sections appear at the end of the file.
58+
- Confirm the Code Coverage Contract states the Playwright V8 report format and advisory nature.
59+
- Confirm the ZIP, code review evidence, HTML inline handler, and first-class tool registration rules are clear and copy/paste ready.

0 commit comments

Comments
 (0)