Ensure Playwright coverage aggregates across multiple tools including Palette Manager - PR_26126_059-playwright-coverage-multi-tool-verification

Author: DavidQ

docs/dev/reports/playwright_v8_coverage_report.txt

@@ -1,13 +1,20 @@
 Playwright V8 Coverage Report
 
-PR: PR_26126_058-playwright-coverage-include-palette-manager
+PR: PR_26126_059-playwright-coverage-multi-tool-verification
 Coverage source: Playwright/Chromium built-in V8 coverage.
-Coverage scope: all collected runtime JavaScript under src/, tools/, and common/.
+Coverage scope: all repo-relative browser JavaScript collected by Playwright/Chromium V8 coverage.
 Dependencies: no new npm packages.
 Thresholds: none enforced.
 Note: coverage is an advisory baseline only for this PR.
 Note: line counts are V8 range-based and advisory; function counts show partial module exercise where available.
 Note: entry percentages use function coverage when available, otherwise line coverage.
+Note: coverage entries are aggregated across every page/tool where coverageReporter.start(page) and coverageReporter.stop(page) ran.
+
+Exercised tool entry points detected:
+(84%) Preview Generator V2 - exercised 19 runtime JS files
+(49%) Palette Manager - exercised 12 runtime JS files
+(0%) Workspace V2 - not exercised by this Playwright run
+(0%) Workspace Manager - not exercised by this Playwright run
 
 Changed runtime JS files covered:
 (100%) none changed - no changed runtime JS files
@@ -63,6 +70,7 @@ Files with executed line/function counts where available:
 (38%) src/engine/camera/Camera3D.js - executed lines 48/48; executed functions 3/8
 (38%) tools/palette-manager-v2/modules/PaletteValidationService.js - executed lines 88/88; executed functions 3/8
 (39%) tools/palette-manager-v2/modules/PaletteManagerApp.js - executed lines 934/934; executed functions 43/110
+(40%) samples/phase-01/0102/KeyboardMoveScene.js - executed lines 78/78; executed functions 2/5
 (40%) src/engine/scene/Scene.js - executed lines 12/12; executed functions 2/5
 (42%) tools/preview-generator-v2/PreviewGeneratorV2Capture.js - executed lines 477/477; executed functions 10/24
 (44%) tools/palette-manager-v2/controls/PaletteEditorControl.js - executed lines 225/225; executed functions 14/32
@@ -97,7 +105,10 @@ Files with executed line/function counts where available:
 (80%) src/engine/core/FrameClock.js - executed lines 32/32; executed functions 4/5
 (80%) src/engine/theme/accordionV2/accordionV2.js - executed lines 26/26; executed functions 4/5
 (81%) tools/preview-generator-v2/PreviewGeneratorV2App.js - executed lines 539/539; executed functions 47/58
+(82%) samples/shared/sampleDetailPageEnhancement.js - executed lines 471/471; executed functions 41/50
 (87%) tools/common/PaletteSortService.js - executed lines 103/103; executed functions 13/15
+(100%) samples/phase-01/0102/main.js - executed lines 23/23; executed functions 1/1
+(100%) samples/shared/numberUtils.js - executed lines 7/7; executed functions 1/1
 (100%) src/engine/audio/index.js - executed lines 15/15; executed functions 1/1
 (100%) src/engine/camera/index.js - executed lines 10/10; executed functions 1/1
 (100%) src/engine/config/index.js - executed lines 7/7; executed functions 1/1
@@ -136,4 +147,3 @@ Uncovered or low-coverage changed JS files:
 
 Changed JS files considered:
 (0%) tests/helpers/playwrightV8CoverageReporter.mjs - changed JS file not collected as browser runtime coverage
-(0%) tests/playwright/PreviewGeneratorV2Baseline.spec.mjs - changed JS file not collected as browser runtime coverage

docs/dev/reports/preview_generator_v2_playwright_coverage.txt

@@ -1,46 +1,28 @@
-# Preview Generator V2 Playwright Coverage - PR_26126_040
+PR_26126_059-preview-generator-v2-playwright-coverage
 
-Reviewed:
-- docs/dev/reports/preview_generator_v2_playwright_result.txt
-- tests/playwright/PreviewGeneratorV2Baseline.spec.mjs
-- package.json
-
-Coverage decision:
-- Preview Generator V2 is already explicitly covered by Playwright.
-- No duplicate Playwright test was added.
-
-Existing Playwright coverage:
-- Launches tools/preview-generator-v2/index.html through the repo HTTP server.
-- Verifies the Preview Generator V2 app shell is visible.
-- Verifies tools/common/toolShellCommon.css is loaded.
-- Verifies the Preview Generator V2 heading is visible.
-- Verifies menuSample nav exists.
-- Verifies Generate Preview and Stop render and begin disabled.
-- Verifies Games is the default target source.
-- Verifies Paths or IDs input is visible.
-- Verifies Status block is visible.
-- Verifies common style declarations apply to header, accordion, app shell, and fullscreen layout targets.
-- Verifies Repo Destination accordion collapses and reopens with aria-expanded state changes.
-- Verifies no page errors during the launch/toggle path.
-
-Broken hooks:
-- No broken Preview Generator V2 selectors, IDs, or Playwright hooks were found.
-- No UI behavior changes were made.
-
-Validation gap fixed:
-- package.json did not define npm run test:workspace-v2.
-- Added test:workspace-v2 as the repository validation command for the existing Preview Generator V2 Playwright baseline.
-
-Validation run:
-- node --check tests/playwright/PreviewGeneratorV2Baseline.spec.mjs
-- npm run test:workspace-v2
+Playwright command:
+npm run test:workspace-v2
 
 Result:
-- PASS: npm run test:workspace-v2 passed.
-- PASS: 1 Playwright test passed.
-
-Scope guard:
-- No samples modified.
-- No schemas added or modified.
-- No start_of_day folders modified.
-- No duplicate Playwright tests added.
+PASS - 4 Playwright tests passed.
+
+Coverage aggregation:
+- Coverage collection uses Playwright/Chromium V8 coverage.
+- Coverage is started and stopped for each page/tool loaded by the Playwright tests.
+- Coverage entries are merged into one report at docs/dev/reports/playwright_v8_coverage_report.txt.
+- The report is not limited to Preview Generator V2 and is not filtered to a specific folder.
+
+Tool entry verification:
+- Preview Generator V2 runtime entries found: 19
+- Palette Manager runtime entries found: 12
+- Workspace V2 browser entry point was not exercised by this Playwright run; no tools/workspace-v2 index entry exists in the active tool surface.
+
+Coverage report expectations:
+- Entries use the format `(xx%) <file-path> - <details>`.
+- Runtime rows are sorted by lowest coverage first.
+- The final report contains both Preview Generator V2 and Palette Manager runtime files, proving merged multi-tool coverage instead of last-page overwrite.
+
+Manual test notes:
+- Open docs/dev/reports/playwright_v8_coverage_report.txt.
+- Confirm the Exercised tool entry points section lists Preview Generator V2 and Palette Manager as exercised.
+- Confirm the Files with executed line/function counts section contains both tools/preview-generator-v2/* and tools/palette-manager-v2/* entries.

tests/helpers/playwrightV8CoverageReporter.mjs

@@ -46,14 +46,18 @@ export class PlaywrightV8CoverageReporter {
     const reportLines = [
       "Playwright V8 Coverage Report",
       "",
-      "PR: PR_26126_058-playwright-coverage-include-palette-manager",
+      "PR: PR_26126_059-playwright-coverage-multi-tool-verification",
       "Coverage source: Playwright/Chromium built-in V8 coverage.",
-      "Coverage scope: all collected runtime JavaScript under src/, tools/, and common/.",
+      "Coverage scope: all repo-relative browser JavaScript collected by Playwright/Chromium V8 coverage.",
       "Dependencies: no new npm packages.",
       "Thresholds: none enforced.",
       "Note: coverage is an advisory baseline only for this PR.",
       "Note: line counts are V8 range-based and advisory; function counts show partial module exercise where available.",
       "Note: entry percentages use function coverage when available, otherwise line coverage.",
+      "Note: coverage entries are aggregated across every page/tool where coverageReporter.start(page) and coverageReporter.stop(page) ran.",
+      "",
+      "Exercised tool entry points detected:",
+      ...this.formatToolEntryPoints(coverageByPath),
       "",
       "Changed runtime JS files covered:",
       ...this.formatChangedRuntimeCoverage(changedRuntimeJsFiles, coverageByPath),
@@ -105,7 +109,11 @@ export class PlaywrightV8CoverageReporter {
     }
     let pathname;
     try {
-      pathname = new URL(url).pathname;
+      const coverageUrl = new URL(url);
+      if (coverageUrl.protocol.startsWith("http") && !["127.0.0.1", "localhost"].includes(coverageUrl.hostname)) {
+        return null;
+      }
+      pathname = coverageUrl.pathname;
     } catch {
       return null;
     }
@@ -249,11 +257,6 @@ export class PlaywrightV8CoverageReporter {
 
   formatCoverageTable(coverageByPath) {
     const records = [...coverageByPath.values()]
-      .filter((record) => (
-        record.repoPath.startsWith("tools/")
-        || record.repoPath.startsWith("src/")
-        || record.repoPath.startsWith("common/")
-      ))
       .sort((left, right) => this.compareCoverageEntries(
         { filePath: left.repoPath, record: left },
         { filePath: right.repoPath, record: right }
@@ -268,6 +271,27 @@ export class PlaywrightV8CoverageReporter {
     ));
   }
 
+  formatToolEntryPoints(coverageByPath) {
+    const toolEntryPoints = [
+      { name: "Preview Generator V2", prefix: "tools/preview-generator-v2/" },
+      { name: "Palette Manager", prefix: "tools/palette-manager-v2/" },
+      { name: "Workspace V2", prefix: "tools/workspace-v2/" },
+      { name: "Workspace Manager", prefix: "tools/workspace-manager/" }
+    ];
+    return toolEntryPoints.map(({ name, prefix }) => {
+      const records = [...coverageByPath.values()].filter((record) => record.repoPath.startsWith(prefix));
+      if (!records.length) {
+        return `(0%) ${name} - not exercised by this Playwright run`;
+      }
+      const executedFunctions = records.reduce((total, record) => total + record.executedFunctions.size, 0);
+      const totalFunctions = records.reduce((total, record) => total + record.totalFunctions.size, 0);
+      const percent = totalFunctions
+        ? Math.round((executedFunctions / totalFunctions) * 100)
+        : 100;
+      return `(${percent}%) ${name} - exercised ${records.length} runtime JS files`;
+    });
+  }
+
   formatLowCoverageChangedFiles(changedRuntimeJsFiles, coverageByPath) {
     if (!changedRuntimeJsFiles.length) {
       return ["(100%) none changed - no changed runtime JS files"];