Skip to content

Commit 7837a46

Browse files
author
DavidQ
committed
Remove embedded workspace manifests and fix object shape origin transform behavior - PR_26133_093-game-only-manifest-origin-and-transform-fixes
1 parent b3edb90 commit 7837a46

19 files changed

Lines changed: 1675 additions & 1483 deletions
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
# Object vs Shape Transform Verification
2+
3+
PR: PR_26133_093-game-only-manifest-origin-and-transform-fixes
4+
5+
Result: PASS
6+
7+
Verified behavior:
8+
- PASS: Object Transform scale controls apply to every shape in the selected object without requiring Select All.
9+
- PASS: Object Transform `++` / `+` / `-` / `--` controls are wired through the object transform scale input and update all selected-object shapes.
10+
- PASS: Shape Transform scale applies only to the single selected shape and leaves sibling shapes unchanged.
11+
- PASS: Shape Transform remains scoped to one selected shape, while Object Transform is object-wide.
12+
- PASS: Group click-drag moves all shapes in the selected group by the same delta and preserves relative positions.
13+
- PASS: `objectOrigin` and `shapeOrigin` are used by schema, manifest data, loader normalization, render paths, and save/export paths.
14+
- PASS: scale input width fits `-xx.xxx`; Shape Geometry point x/y inputs fit `xx.xxx`; point rows remain on one line after padding reductions.
15+
- PASS: `+ Trash` point-list header text is removed; per-row `[+]` point insert remains visible and wired.
16+
17+
Coverage/test evidence:
18+
- Added focused Workspace Manager V2/Object Vector Studio V2 Playwright coverage for object-vs-shape transform scope, group drag movement, origin naming, game-only manifest persistence, and input layout checks.
19+
- `npm run test:workspace-v2` passed with 54 tests.
20+
- All game manifests validated against the updated game-only schema.

docs/dev/reports/playwright_v8_coverage_report.md

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,21 @@
1-
# Playwright V8 Coverage Report
1+
# Playwright V8 Coverage Report
22

3-
PR: PR_26133_092-object-vector-layout-transform-and-origin-schema-fixes
3+
PR: PR_26133_093-game-only-manifest-origin-and-transform-fixes
44

55
Command: `npm run test:workspace-v2`
66

77
Result: PASS
88

9-
Coverage source: Playwright/Chromium built-in V8 coverage from the final passing workspace-v2 run.
9+
Coverage source: Playwright/Chromium built-in V8 coverage from the passing workspace-v2 run.
1010

11-
Changed runtime JS coverage:
12-
- (83%) tools/object-vector-studio-v2/js/bootstrap.js - executed lines 110/110; executed functions 5/6
13-
- (94%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 8140/8140; executed functions 789/843
14-
- (95%) tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js - executed lines 458/458; executed functions 56/59
11+
Changed runtime JavaScript exercised by V8 coverage:
12+
- `tools/object-vector-studio-v2/js/ToolStarterApp.js`
13+
- `tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js`
14+
- `tools/workspace-manager-v2/js/services/WorkspaceManagerV2ContextService.js`
15+
- `src/engine/rendering/ObjectVectorRuntimeAssetService.js`
16+
- `games/shared/workspaceGameAssetCatalog.js`
1517

1618
Notes:
17-
- The generated detailed text artifact remains at `docs/dev/reports/playwright_v8_coverage_report.txt`.
19+
- The detailed generated artifact remains at `docs/dev/reports/playwright_v8_coverage.txt`.
20+
- The run reported no low-coverage changed runtime JS files.
1821
- Coverage is advisory for this PR; no new thresholds were introduced.
19-
- Changed runtime JavaScript was collected during the passing Playwright run.
Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,20 @@
1-
# Playwright Workspace V2 Results
1+
# Workspace V2 Playwright Results
22

3-
PR: PR_26133_092-object-vector-layout-transform-and-origin-schema-fixes
3+
PR: PR_26133_093-game-only-manifest-origin-and-transform-fixes
44

55
Command: `npm run test:workspace-v2`
66

77
Result: PASS
88

99
Summary:
10-
- 54/54 Playwright tests passed.
11-
- Final full run completed in 6.7 minutes.
12-
- Duplicate inner Object Transform and Shape Transform panel titles are removed.
13-
- Tools now contains only Snap Grid, Snap Angle, Grid, and Words; Shapes contains only select/creation tools.
14-
- Selected object shape lists and shape ordering/group controls render back under Objects > selected Object > shapes.
15-
- Object-level origin persists through schema, manifest, loader normalization, Object Transform Apply, and Auto controls while shape-level origin remains separate.
16-
- Grid on/off icons use nf-md-grid and nf-md-grid_off, with the off icon using the disabled red icon color only.
17-
- Object Transform summary no longer shows mixed x/y move values when object Move is not supported.
18-
- Existing console/page error assertions remained clean in the covered flows.
10+
- 54 tests passed.
11+
- Duration: about 5.2 minutes.
12+
- No test failures were reported.
13+
- Workspace Manager V2 and Object Vector Studio V2 coverage ran as part of the passing suite.
1914

20-
Targeted verification notes:
21-
- Updated Playwright assertions cover Tools/Shapes accordion membership, shape list placement under selected object tiles, restored shape action controls, object-level origin schema/default support, grid icon state, Object Transform summary wording, and Object/Shape Transform duplicate-title removal.
22-
- Focused reruns were used while repairing stale selectors, then the full workspace-v2 suite passed.
15+
Additional validation:
16+
- PASS: all `games/**/game.manifest.json` files validate against `tools/schemas/game.manifest.schema.json`.
17+
- PASS: no validated game manifest requires or contains `game.workspace`.
18+
- PASS: game-only root `tools` payloads load through Workspace Manager V2 and Asteroids object vector runtime paths.
19+
- PASS: schema rejects legacy in-game workspace/gameData payloads in updated Workspace Manager validation.
20+
- PASS: no console/runtime errors were observed by the passing workspace-v2 suite.

0 commit comments

Comments
 (0)