Skip to content

Commit b3edb90

Browse files
author
DavidQ
committed
Fix Object Vector Studio layout regressions object origin schema and transform display - PR_26133_092-object-vector-layout-transform-and-origin-schema-fixes
1 parent d67efb9 commit b3edb90

10 files changed

Lines changed: 234 additions & 159 deletions

File tree

docs/dev/reports/playwright_v8_coverage_report.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Playwright V8 Coverage Report
22

3-
PR: PR_26133_091-transform-origin-grouping-and-layout-polish
3+
PR: PR_26133_092-object-vector-layout-transform-and-origin-schema-fixes
44

55
Command: `npm run test:workspace-v2`
66

@@ -9,8 +9,9 @@ Result: PASS
99
Coverage source: Playwright/Chromium built-in V8 coverage from the final passing workspace-v2 run.
1010

1111
Changed runtime JS coverage:
12-
- (83%) tools/object-vector-studio-v2/js/bootstrap.js - executed lines 111/111; executed functions 5/6
13-
- (94%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 8148/8148; executed functions 791/844
12+
- (83%) tools/object-vector-studio-v2/js/bootstrap.js - executed lines 110/110; executed functions 5/6
13+
- (94%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 8140/8140; executed functions 789/843
14+
- (95%) tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js - executed lines 458/458; executed functions 56/59
1415

1516
Notes:
1617
- The generated detailed text artifact remains at `docs/dev/reports/playwright_v8_coverage_report.txt`.
Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,22 @@
11
# Playwright Workspace V2 Results
22

3-
PR: PR_26133_091-transform-origin-grouping-and-layout-polish
3+
PR: PR_26133_092-object-vector-layout-transform-and-origin-schema-fixes
44

55
Command: `npm run test:workspace-v2`
66

77
Result: PASS
88

99
Summary:
1010
- 54/54 Playwright tests passed.
11-
- Final full run completed in 5.5 minutes.
12-
- Origin controls now render as `Origin X [input] Y [input] [Apply] [Auto]` for Object Transform and Shape Transform.
13-
- Object Transform is focused on origin, rotate, scale, and resize; object-level Move was removed from the panel.
14-
- Tools and Shapes are split into separate right-column accordions, with Palette, Tools, Shapes, Shape Geometry, Shape Transform, JSON Details, Dependency Details, and Status Log in the requested order.
15-
- Grouped shape body selection remains single-shape; clicking the group icon selects the full group and updates the preview/list selection state.
16-
- Shape Geometry and Shape Transform disable during multi-select.
11+
- Final full run completed in 6.7 minutes.
12+
- Duplicate inner Object Transform and Shape Transform panel titles are removed.
13+
- Tools now contains only Snap Grid, Snap Angle, Grid, and Words; Shapes contains only select/creation tools.
14+
- Selected object shape lists and shape ordering/group controls render back under Objects > selected Object > shapes.
15+
- Object-level origin persists through schema, manifest, loader normalization, Object Transform Apply, and Auto controls while shape-level origin remains separate.
16+
- Grid on/off icons use nf-md-grid and nf-md-grid_off, with the off icon using the disabled red icon color only.
17+
- Object Transform summary no longer shows mixed x/y move values when object Move is not supported.
1718
- Existing console/page error assertions remained clean in the covered flows.
1819

1920
Targeted verification notes:
20-
- Updated Playwright assertions cover origin row button ordering, Object/Shape Transform Snap Angle rotate controls, grouped-shape icon selection, multi-select disabled states, right-column accordion order, and Dependency Details wording.
21-
- Numeric display normalization is covered through the Object Vector Studio V2 field rendering paths and transform/geometry input helpers.
21+
- Updated Playwright assertions cover Tools/Shapes accordion membership, shape list placement under selected object tiles, restored shape action controls, object-level origin schema/default support, grid icon state, Object Transform summary wording, and Object/Shape Transform duplicate-title removal.
22+
- Focused reruns were used while repairing stale selectors, then the full workspace-v2 suite passed.

games/Asteroids/game.manifest.json

Lines changed: 35 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -474,7 +474,11 @@
474474
"tags": [
475475
"player",
476476
"ship"
477-
]
477+
],
478+
"origin": {
479+
"x": 0,
480+
"y": 0
481+
}
478482
},
479483
{
480484
"id": "object.asteroids.large-asteroid",
@@ -574,7 +578,11 @@
574578
"tags": [
575579
"asteroid",
576580
"large"
577-
]
581+
],
582+
"origin": {
583+
"x": 0,
584+
"y": 0
585+
}
578586
},
579587
{
580588
"id": "object.asteroids.small-asteroid",
@@ -650,7 +658,11 @@
650658
"tags": [
651659
"asteroid",
652660
"small"
653-
]
661+
],
662+
"origin": {
663+
"x": 0,
664+
"y": 0
665+
}
654666
},
655667
{
656668
"id": "object.asteroids.large-ufo",
@@ -734,7 +746,11 @@
734746
"tags": [
735747
"ufo",
736748
"large"
737-
]
749+
],
750+
"origin": {
751+
"x": 0,
752+
"y": 0
753+
}
738754
},
739755
{
740756
"id": "object.asteroids.small-ufo",
@@ -818,7 +834,11 @@
818834
"tags": [
819835
"ufo",
820836
"small"
821-
]
837+
],
838+
"origin": {
839+
"x": 0,
840+
"y": 0
841+
}
822842
},
823843
{
824844
"id": "object.asteroids.medium-asteroid",
@@ -898,7 +918,11 @@
898918
"tags": [
899919
"asteroid",
900920
"medium"
901-
]
921+
],
922+
"origin": {
923+
"x": 0,
924+
"y": 0
925+
}
902926
},
903927
{
904928
"id": "object.asteroids.medium-asteroid-2",
@@ -978,7 +1002,11 @@
9781002
"tags": [
9791003
"asteroid",
9801004
"medium"
981-
]
1005+
],
1006+
"origin": {
1007+
"x": 0,
1008+
"y": 0
1009+
}
9821010
}
9831011
]
9841012
},

0 commit comments

Comments
 (0)