Remove shared index barrel exports in favor of direct imports - PR_26140_065-remove-shared-index-barrels

Author: DavidQ

docs/dev/reports/shared_index_barrel_removal_report.md

@@ -0,0 +1,47 @@
+# PR_26140_065 Shared Index Barrel Removal Report
+
+## Summary
+- Removed the remaining `src/shared/**/index.js` barrel files.
+- Replaced imports from shared folder indexes with direct canonical file imports.
+- Preserved behavior by changing only module specifiers and deleting now-unused barrel files.
+- No replacement pass-through files or root shared exports were created.
+
+## Shared Barrels Removed
+- `src/shared/contracts/index.js`
+- `src/shared/id/index.js`
+- `src/shared/math/index.js`
+- `src/shared/number/index.js`
+- `src/shared/state/index.js`
+- `src/shared/string/index.js`
+
+## Direct Import Decisions
+- String helpers now import from `src/shared/string/strings.js`.
+- Number helpers now import from `src/shared/number/numbers.js`.
+- Promotion state consumers now import `getPromotionState` from `src/shared/state/getState.js`.
+- Replay contract consumers now import replay constants from `src/shared/contracts/replayContracts.js`.
+- Existing imports that already targeted canonical files were left unchanged.
+
+## Guardrail Checks
+- PASS: no active imports remain from `src/shared/**/index.js`.
+- PASS: no `src/shared/**/index.js` files remain.
+- PASS: no sample JSON files were modified.
+- PASS: no replacement pass-through files were created under `src/shared`.
+- Required exception: none.
+
+## Validation
+- PASS: targeted syntax validation for 71 changed JavaScript files.
+- PASS: targeted import-target validation for 71 changed JavaScript files.
+- PASS: `npm run test:workspace-v2` with 59 passed.
+- PASS: `git diff --check` completed with Git CRLF normalization warnings only.
+
+## Coverage Guardrail
+- Playwright generated the advisory V8 coverage report at `docs/dev/reports/coverage_changed_js_guardrail.txt`.
+- Missing or low coverage entries are WARN-only per project instructions.
+
+## Full Samples Smoke Test
+- Skipped. The PR is scoped to shared import-path normalization and the requested targeted validation plus Workspace V2 test gate passed.
+
+## Manual Validation
+1. Review `docs/dev/reports/codex_review.diff` and confirm all shared index imports now point at canonical files.
+2. Confirm `src/shared` contains no `index.js` files in any nested folder.
+3. Launch Workspace Manager V2 and confirm tool/game flows still load normally.

games/Asteroids/debug/asteroidsShowcaseDebug.js

@@ -6,7 +6,7 @@ asteroidsShowcaseDebug.js
 */
 
 import { asArray, asObject } from "/src/engine/debug/inspectors/shared/inspectorUtils.js";
-import { sanitizeText } from "/src/shared/string/index.js";
+import { sanitizeText } from "/src/shared/string/strings.js";
 
 function formatNumber(value, defaultValue = 0) {
   return Number.isFinite(value) ? Number(value) : defaultValue;

games/Asteroids/game/AsteroidsGameScene.js

@@ -6,7 +6,7 @@ AsteroidsGameScene.js
 */
 import { AttractModeController, Scene } from '/src/engine/scene/index.js';
 import { ParticleSystem } from '/src/engine/fx/index.js';
-import { asPositiveInteger } from '/src/shared/number/index.js';
+import { asPositiveInteger } from '/src/shared/number/numbers.js';
 import AsteroidsSession from './AsteroidsSession.js';
 import AsteroidsWorld from './AsteroidsWorld.js';
 import AsteroidsAudio from '../systems/AsteroidsAudio.js';

games/Asteroids/index.js

@@ -8,7 +8,7 @@ import { ObjectVectorRuntimeAssetService } from "/src/engine/rendering/index.js"
 import { Theme, ThemeTokens } from "/src/engine/theme/index.js";
 import { resolveDebugConfig } from "/src/shared/debug/config.js";
 import { createNoopDevConsoleIntegration } from "/src/shared/debug/noopDevConsoleIntegration.js";
-import { asPositiveInteger } from "/src/shared/number/index.js";
+import { asPositiveInteger } from "/src/shared/number/numbers.js";
 import AsteroidsGameScene from "./game/AsteroidsGameScene.js";
 import { loadAsteroidsObjectGeometryFromManifest } from "./game/asteroidsObjectGeometryManifest.js";
 import { preloadWorkspaceGameAssetCatalog } from "../shared/workspaceGameAssetCatalog.js";

games/SolarSystem/game/SolarSystemWorld.js

@@ -5,7 +5,7 @@ David Quesenberry
 SolarSystemWorld.js
 */
 import { toObject } from '/src/shared/object/objects.js';
-import { toFiniteNumber } from '/src/shared/number/index.js';
+import { toFiniteNumber } from '/src/shared/number/numbers.js';
 
 const MAX_STEP_SECONDS = 1 / 60;
 

games/bouncing-ball/game/BouncingBallWorld.js

@@ -6,7 +6,7 @@ BouncingBallWorld.js
 */
 import { clamp } from '/src/shared/math/scalars.js';
 import { toObject } from '/src/shared/object/objects.js';
-import { toFiniteNumber } from '/src/shared/number/index.js';
+import { toFiniteNumber } from '/src/shared/number/numbers.js';
 
 const MAX_STEP_SECONDS = 1 / 120;
 const DEFAULT_BOUNCING_BALL_WORLD_SKIN = Object.freeze({

games/breakout/game/BreakoutWorld.js

@@ -6,7 +6,7 @@ BreakoutWorld.js
 */
 import { clamp } from '/src/shared/math/scalars.js';
 import { toObject } from '/src/shared/object/objects.js';
-import { toFiniteNumber } from '/src/shared/number/index.js';
+import { toFiniteNumber } from '/src/shared/number/numbers.js';
 
 const MAX_STEP_SECONDS = 1 / 120;
 

games/breakout/main.js

@@ -9,7 +9,7 @@ import { InputService } from '/src/engine/input/index.js';
 import { Theme, ThemeTokens } from '/src/engine/theme/index.js';
 import { resolveDebugConfig } from '../../src/shared/debug/config.js';
 import { createNoopDevConsoleIntegration } from '../../src/shared/debug/noopDevConsoleIntegration.js';
-import { sanitizeText } from '../../src/shared/string/index.js';
+import { sanitizeText } from '../../src/shared/string/strings.js';
 import BreakoutScene from './game/BreakoutScene.js';
 
 const theme = new Theme(ThemeTokens);

games/index.render.js

@@ -1,7 +1,7 @@
 import { asArray } from '../src/shared/array/arrays.js';
 import { getToolRegistry } from "../tools/toolRegistry.js";
 import { resolveGamePreviewMap } from "./shared/gameManifestPreviewResolver.js";
-import { normalizeText, normalizeToken } from "../src/shared/string/index.js";
+import { normalizeText, normalizeToken } from "../src/shared/string/strings.js";
 import { launchWithExternalToolWorkspaceReset, resolveGameWorkspaceLaunchHref } from "../tools/shared/toolLaunchSSoT.js";
 
 const METADATA_PATH = "./metadata/games.index.metadata.json";

games/pong/game/PongScene.js

@@ -10,7 +10,7 @@ import PongAudio from './PongAudio.js';
 import { getPongModes } from './PongModeConfig.js';
 import { wrapTextByCharacterCount } from '/src/shared/string/textWrap.js';
 import { toObject } from '/src/shared/object/objects.js';
-import { toFiniteNumber } from '/src/shared/number/index.js';
+import { toFiniteNumber } from '/src/shared/number/numbers.js';
 
 const COURT = {
   width: 960,