Stabilize storage, preview, workspace, and object vector targeted fixes while preserving Workspace manifest contract - PR_26133_099-storage-preview-workspace-followup

Author: DavidQ

docs/dev/reports/PR_26133_099-storage-preview-workspace-followup_report.md

@@ -0,0 +1,45 @@
+# PR_26133_099-storage-preview-workspace-followup Report
+
+## Scope
+
+- Targeted tool: Preview Generator V2.
+- Implementation scope used: `tools/preview-generator-v2/*` and `docs/dev/reports/*`.
+- `common/*` was allowed by the PR, but no `common` directory exists in this repo checkout and no common changes were needed.
+- Workspace manifest/schema structures were not modified.
+
+## Issue Fixed
+
+Before this follow-up, the repo-root-unavailable failure kept the selected repo display label in `repoRootDisplayPath`. The error text was actionable, but downstream path logs could still treat the label as if it were a resolved repo-root path.
+
+The fix keeps `repoRootDisplayPath` empty when no absolute repo root is available. The selected repo label and required action remain in the failure message.
+
+## Playwright Impact
+
+Playwright impacted: Yes.
+
+Validated behavior:
+- Preview Generator V2 still logs actionable output-path resolution failures.
+- Preview Generator V2 still logs actionable repo-root selection failures without fallback.
+- Workspace V2 regression coverage remains green.
+
+Expected pass behavior:
+- Missing repo-root absolute path logs selected repo label and required action.
+- Full absolute output path remains unavailable.
+- No `OK WRITE` is logged for unresolved output paths.
+
+Expected fail behavior:
+- If the repo-root label is treated as a resolved path, path-resolution logs would show a fake repo root instead of unavailable.
+
+## Validation
+
+- PASS: `node --check tools/preview-generator-v2/PreviewGeneratorV2App.js`
+- PASS: `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list -g "Preview Generator V2 (output path resolution failures|repo-root selection failures without fallback)"` (2/2)
+- PASS: `npm run test:workspace-v2` (56/56)
+- SKIPPED: full samples smoke test, per PR instruction and project testing rules; this change is limited to Preview Generator V2 path-state failure handling.
+
+## Manual Validation
+
+1. Open Preview Generator V2 without an absolute repo-root path but with a selected repo label.
+2. Run generation for a game preview target.
+3. Confirm the log shows the selected repo label and required action to reselect the repo root.
+4. Confirm the full absolute output path is `(unavailable)` and no `OK WRITE` appears.

tools/preview-generator-v2/PreviewGeneratorV2App.js

@@ -481,7 +481,7 @@ function selectedRepoRootPathState() {
     return {
       ok: false,
       message: `Repo root path is unavailable; cannot resolve a full absolute output path. Selected repo label: ${displayLabel}; handle root name: ${handleName || "(unavailable)"}; session key checked: ${WORKSPACE_REPO_REFERENCE_SESSION_KEY}. Required action: select the repo root folder again in Workspace Manager V2 or Pick Repo before generating previews.`,
-      repoRootDisplayPath: displayLabel === "(unavailable)" ? "" : displayLabel,
+      repoRootDisplayPath: "",
       repoRootPath: ""
     };
   }