Fix storage cookies preview output workspace dirty state and Object Vector future shapes - PR_26133_098-storage-preview-workspace-and-object-vector-fix-batch

Author: DavidQ

docs/dev/reports/playwright_v8_coverage_report.md

@@ -23,7 +23,14 @@ Exercised tool entry points detected:
 (0%) Workspace Manager - not exercised by this Playwright run
 
 Changed runtime JS files covered:
-(94%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 8334/8334; executed functions 818/866
+(86%) src/engine/runtime/fullscreenBezel.js - executed lines 1042/1042; executed functions 62/72
+(86%) tools/workspace-manager-v2/js/WorkspaceManagerV2App.js - executed lines 963/963; executed functions 42/49
+(88%) tools/preview-generator-v2/PreviewGeneratorV2App.js - executed lines 1500/1500; executed functions 107/121
+(92%) src/engine/runtime/gameImageConvention.js - executed lines 233/233; executed functions 23/25
+(95%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 8380/8380; executed functions 826/874
+(98%) tools/storage-inspector-v2/js/StorageInspectorV2App.js - executed lines 348/348; executed functions 52/53
+(100%) tools/storage-inspector-v2/js/controls/FilterControl.js - executed lines 35/35; executed functions 9/9
+(100%) tools/storage-inspector-v2/js/services/StorageInspectorV2StorageService.js - executed lines 259/259; executed functions 39/39
 
 Files with executed line/function counts where available:
 (2%) src/engine/input/ActionInputService.js - executed lines 397/397; executed functions 1/51
@@ -98,9 +105,7 @@ Files with executed line/function counts where available:
 (43%) games/Asteroids/systems/AsteroidsInitialsEntry.js - executed lines 71/71; executed functions 3/7
 (43%) games/Pong/game/PongAudio.js - executed lines 57/57; executed functions 3/7
 (44%) games/Asteroids/systems/ShipDebrisSystem.js - executed lines 84/84; executed functions 4/9
-(44%) src/engine/runtime/fullscreenBezel.js - executed lines 1034/1034; executed functions 29/66
 (47%) src/engine/input/InputService.js - executed lines 185/185; executed functions 14/30
-(47%) src/engine/runtime/backgroundImage.js - executed lines 205/205; executed functions 8/17
 (47%) src/engine/runtime/RuntimeMonitoringHooks.js - executed lines 191/191; executed functions 8/17
 (50%) games/Asteroids/index.js - executed lines 211/211; executed functions 6/12
 (50%) src/engine/camera/ZoneCameraSystem.js - executed lines 26/26; executed functions 1/2
@@ -146,12 +151,12 @@ Files with executed line/function counts where available:
 (68%) tools/palette-manager-v2/controls/UserPaletteControl.js - executed lines 95/95; executed functions 13/19
 (70%) games/Asteroids/systems/AsteroidsHighScoreService.js - executed lines 73/73; executed functions 7/10
 (71%) src/engine/input/KeyboardState.js - executed lines 34/34; executed functions 5/7
+(71%) src/engine/runtime/backgroundImage.js - executed lines 205/205; executed functions 12/17
 (71%) src/engine/runtime/FullscreenService.js - executed lines 123/123; executed functions 10/14
 (71%) src/shared/utils/debugConfigUtils.js - executed lines 89/89; executed functions 5/7
 (71%) tools/asset-manager-v2/js/assetPreviewHelpers.js - executed lines 156/156; executed functions 10/14
 (71%) tools/palette-manager-v2/controls/PaletteValidationErrorControl.js - executed lines 30/30; executed functions 5/7
 (71%) tools/world-vector-studio-v2/js/controls/ActionNavControl.js - executed lines 76/76; executed functions 5/7
-(73%) src/engine/runtime/gameImageConvention.js - executed lines 207/207; executed functions 16/22
 (73%) src/engine/theme/mount-shared-header.js - executed lines 143/143; executed functions 8/11
 (75%) games/Pong/game/PongModeConfig.js - executed lines 88/88; executed functions 3/4
 (75%) games/shared/workspaceGameRuntimeContext.js - executed lines 58/58; executed functions 3/4
@@ -175,34 +180,35 @@ Files with executed line/function counts where available:
 (80%) tools/workspace-manager-v2/js/controls/AccordionSection.js - executed lines 27/27; executed functions 4/5
 (80%) tools/world-vector-studio-v2/js/controls/AccordionSection.js - executed lines 27/27; executed functions 4/5
 (81%) games/Asteroids/game/asteroidsObjectVectorRoles.js - executed lines 174/174; executed functions 13/16
-(82%) src/engine/rendering/CanvasRenderer.js - executed lines 100/100; executed functions 9/11
 (82%) tools/storage-inspector-v2/js/controls/EntryListControl.js - executed lines 59/59; executed functions 9/11
 (83%) games/Asteroids/entities/Asteroid.js - executed lines 61/61; executed functions 5/6
 (83%) tools/object-vector-studio-v2/js/bootstrap.js - executed lines 110/110; executed functions 5/6
 (83%) tools/palette-manager-v2/main.js - executed lines 227/227; executed functions 15/18
 (83%) tools/storage-inspector-v2/js/controls/AccordionSection.js - executed lines 41/41; executed functions 5/6
+(85%) src/engine/audio/GaplessLoopPlayer.js - executed lines 187/187; executed functions 17/20
 (86%) games/Asteroids/systems/AsteroidsAudio.js - executed lines 134/134; executed functions 12/14
 (86%) games/shared/gameSkinLoader.js - executed lines 352/352; executed functions 18/21
 (86%) src/engine/audio/WebAudioToneBackend.js - executed lines 65/65; executed functions 6/7
+(86%) src/engine/runtime/fullscreenBezel.js - executed lines 1042/1042; executed functions 62/72
 (86%) tools/asset-manager-v2/js/controls/AssetCatalogControl.js - executed lines 134/134; executed functions 12/14
 (86%) tools/workspace-manager-v2/js/controls/RepoDestinationControl.js - executed lines 25/25; executed functions 6/7
 (86%) tools/workspace-manager-v2/js/WorkspaceManagerV2App.js - executed lines 963/963; executed functions 42/49
 (88%) games/Pong/game/PongInputController.js - executed lines 77/77; executed functions 7/8
 (88%) games/shared/workspaceGameAssetCatalog.js - executed lines 313/313; executed functions 23/26
-(88%) tools/preview-generator-v2/PreviewGeneratorV2App.js - executed lines 1498/1498; executed functions 107/121
+(88%) tools/preview-generator-v2/PreviewGeneratorV2App.js - executed lines 1500/1500; executed functions 107/121
 (88%) tools/shared/toolLaunchSSoTData.js - executed lines 112/112; executed functions 14/16
 (88%) tools/text2speech-V2/js/controls/TextInputControl.js - executed lines 24/24; executed functions 7/8
 (88%) tools/world-vector-studio-v2/js/controls/SourceInputControl.js - executed lines 33/33; executed functions 7/8
 (89%) games/Asteroids/game/asteroidObjectGeometry.js - executed lines 82/82; executed functions 16/18
 (89%) tools/asset-manager-v2/js/services/AssetSchemaValidator.js - executed lines 295/295; executed functions 25/28
 (89%) tools/preview-generator-v2/controls/StatusLogControl.js - executed lines 32/32; executed functions 8/9
-(89%) tools/storage-inspector-v2/js/controls/FilterControl.js - executed lines 34/34; executed functions 8/9
-(90%) src/engine/audio/GaplessLoopPlayer.js - executed lines 187/187; executed functions 18/20
 (90%) tools/palette-manager-v2/modules/PaletteValidationService.js - executed lines 88/88; executed functions 9/10
 (90%) tools/text2speech-V2/js/controls/ActionNavControl.js - executed lines 117/117; executed functions 19/21
 (90%) tools/text2speech-V2/js/TextToSpeechToolApp.js - executed lines 807/807; executed functions 62/69
+(91%) src/engine/rendering/CanvasRenderer.js - executed lines 100/100; executed functions 10/11
 (91%) tools/object-vector-studio-v2/js/controls/ActionNavControl.js - executed lines 78/78; executed functions 10/11
 (91%) tools/toolRegistry.js - executed lines 526/526; executed functions 10/11
+(92%) src/engine/runtime/gameImageConvention.js - executed lines 233/233; executed functions 23/25
 (92%) tools/object-vector-studio-v2/js/controls/ToolStarterShellControl.js - executed lines 112/112; executed functions 11/12
 (92%) tools/workspace-manager-v2/js/services/WorkspaceManagerV2ContextService.js - executed lines 1662/1662; executed functions 149/162
 (93%) tools/asset-manager-v2/js/services/WorkspaceBridge.js - executed lines 305/305; executed functions 25/27
@@ -212,9 +218,9 @@ Files with executed line/function counts where available:
 (94%) games/shared/workspaceGameMetadataHydrator.js - executed lines 106/106; executed functions 16/17
 (94%) src/engine/rendering/ObjectVectorRuntimeAssetService.js - executed lines 1136/1136; executed functions 111/118
 (94%) tools/common/PaletteSortService.js - executed lines 103/103; executed functions 17/18
-(94%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 8334/8334; executed functions 818/866
 (95%) tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js - executed lines 458/458; executed functions 56/59
-(98%) tools/storage-inspector-v2/js/StorageInspectorV2App.js - executed lines 347/347; executed functions 51/52
+(95%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 8380/8380; executed functions 826/874
+(98%) tools/storage-inspector-v2/js/StorageInspectorV2App.js - executed lines 348/348; executed functions 52/53
 (100%) games/Asteroids/flow/attract.js - executed lines 17/17; executed functions 1/1
 (100%) games/Asteroids/flow/highscore.js - executed lines 16/16; executed functions 1/1
 (100%) games/Asteroids/flow/intro.js - executed lines 18/18; executed functions 1/1
@@ -275,10 +281,11 @@ Files with executed line/function counts where available:
 (100%) tools/storage-inspector-v2/js/bootstrap.js - executed lines 55/55; executed functions 4/4
 (100%) tools/storage-inspector-v2/js/controls/DataControl.js - executed lines 23/23; executed functions 5/5
 (100%) tools/storage-inspector-v2/js/controls/DirtyControl.js - executed lines 30/30; executed functions 6/6
+(100%) tools/storage-inspector-v2/js/controls/FilterControl.js - executed lines 35/35; executed functions 9/9
 (100%) tools/storage-inspector-v2/js/controls/JsonControl.js - executed lines 19/19; executed functions 5/5
 (100%) tools/storage-inspector-v2/js/controls/StatusLogControl.js - executed lines 32/32; executed functions 10/10
 (100%) tools/storage-inspector-v2/js/services/StorageInspectorV2RuntimeContract.js - executed lines 10/10; executed functions 2/2
-(100%) tools/storage-inspector-v2/js/services/StorageInspectorV2StorageService.js - executed lines 184/184; executed functions 29/29
+(100%) tools/storage-inspector-v2/js/services/StorageInspectorV2StorageService.js - executed lines 259/259; executed functions 39/39
 (100%) tools/text2speech-V2/js/controls/OutputSummaryControl.js - executed lines 8/8; executed functions 3/3
 (100%) tools/text2speech-V2/js/controls/SpeechOptionsControl.js - executed lines 451/451; executed functions 47/47
 (100%) tools/text2speech-V2/js/controls/StatusLogControl.js - executed lines 28/28; executed functions 8/8
@@ -297,5 +304,12 @@ Uncovered or low-coverage changed JS files:
 
 Changed JS files considered:
 (0%) tests/playwright/tools/WorkspaceManagerV2.spec.mjs - changed JS file not collected as browser runtime coverage
-(94%) tools/object-vector-studio-v2/js/ToolStarterApp.js - changed JS file with browser V8 coverage
+(86%) src/engine/runtime/fullscreenBezel.js - changed JS file with browser V8 coverage
+(86%) tools/workspace-manager-v2/js/WorkspaceManagerV2App.js - changed JS file with browser V8 coverage
+(88%) tools/preview-generator-v2/PreviewGeneratorV2App.js - changed JS file with browser V8 coverage
+(92%) src/engine/runtime/gameImageConvention.js - changed JS file with browser V8 coverage
+(95%) tools/object-vector-studio-v2/js/ToolStarterApp.js - changed JS file with browser V8 coverage
+(98%) tools/storage-inspector-v2/js/StorageInspectorV2App.js - changed JS file with browser V8 coverage
+(100%) tools/storage-inspector-v2/js/controls/FilterControl.js - changed JS file with browser V8 coverage
+(100%) tools/storage-inspector-v2/js/services/StorageInspectorV2StorageService.js - changed JS file with browser V8 coverage
 ```

docs/dev/reports/playwright_workspace_v2_results.md

@@ -1,24 +1,26 @@
-# npm run test:workspace-v2
+# Workspace V2 Playwright Results
 
-Exit code: 0
+PR: PR_26133_098-storage-preview-workspace-and-object-vector-fix-batch
+Date: 2026-05-18
+
+## Command
 
 ```text
-> html-javascript-gaming@1.0.0 test:workspace-v2
-> playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list
+npm run test:workspace-v2
+```
 
-Running 55 tests using 1 worker
+## Result
 
-Result: 55 passed (6.1m)
+PASS: 56/56 Playwright tests passed using the `playwright` project with 1 worker.
 
-Result for PR_26133_097:
-- PASS small pointer movement inside selected bounds does not start preview drag
-- PASS selected shape repeated click preserves the selected set
-- PASS empty canvas drag/click outside selected bounds follows normal deselect/no-move behavior
-- PASS single-shape live drag updates selection bounds and resize/point handle positions before mouseup
-- PASS multi-selected shapes and grouped shapes still move together from preview selection bounds
-- PASS realtime drag transform values remain max 3 decimals
+## Focused Coverage From This PR
 
-Additional focused checks run before the full suite:
-- drags selected Object Vector Studio V2 shapes from preview selection bounds
-- Object Vector Studio V2 layout shell and schema-only palette gate
-```
+- Storage Inspector V2: cookies are listed read-only, cookie delete is supported, and storage survival footer notes are visible for sessionStorage, localStorage, and cookies.
+- Asteroids: background resolves to `/games/Asteroids/assets/images/deluxe.png`; fullscreen bezel resolves to `/games/Asteroids/assets/images/bezel.png` and uses the transparent-window fit layout.
+- Preview Generator V2: missing repo-root path produces an actionable selection error and does not silently fallback.
+- Object Vector Studio V2: Auto Origin uses raw visible geometry bounds, and future shape tools are disabled/grayed out in alphabetized Shapes order.
+- Workspace Manager V2: dirty lifecycle buttons follow dirty/clean contracts: dirty enables Save/Cancel and disables Close; clean disables Save/Cancel and enables Close.
+
+## Console/Runtime Errors
+
+PASS: no page errors were observed by the workspace-v2 Playwright suite.

src/engine/runtime/fullscreenBezel.js

@@ -258,15 +258,23 @@ function parseStretchConfigPayload(payload, configPath = "") {
     return parsed;
   }
 
-  const flatAssetEntries = payload?.tools?.["asset-browser"]?.assets;
-  if (flatAssetEntries && typeof flatAssetEntries === "object") {
+  const assetEntriesByTool = [
+    payload?.tools?.["asset-browser"]?.assets,
+    payload?.tools?.["asset-manager-v2"]?.assets
+  ];
+  for (const flatAssetEntries of assetEntriesByTool) {
+    if (!flatAssetEntries || typeof flatAssetEntries !== "object") {
+      continue;
+    }
     const bezelAssetEntry = Object.entries(flatAssetEntries).find(([assetId, entry]) => {
       const normalizedAssetId = typeof assetId === "string" ? assetId.trim().toLowerCase() : "";
       const normalizedKind = typeof entry?.kind === "string" ? entry.kind.trim().toLowerCase() : "";
+      const normalizedType = typeof entry?.type === "string" ? entry.type.trim().toLowerCase() : "";
+      const normalizedRole = typeof entry?.role === "string" ? entry.role.trim().toLowerCase() : "";
       const hasStretch = entry?.stretchOverride && typeof entry.stretchOverride === "object";
       return hasStretch
-        && normalizedKind === "image"
-        && (normalizedAssetId.includes(".bezel") || normalizedAssetId.endsWith("bezel"));
+        && (normalizedKind === "image" || normalizedType === "image" || normalizedRole === "bezel")
+        && (normalizedRole === "bezel" || normalizedAssetId.includes(".bezel") || normalizedAssetId.endsWith("bezel"));
     });
     if (bezelAssetEntry && typeof bezelAssetEntry[1] === "object") {
       const stretchConfig = parseStretchConfigObject(bezelAssetEntry[1].stretchOverride);

src/engine/runtime/gameImageConvention.js

@@ -52,36 +52,64 @@ function deriveManifestPath(options = {}) {
   return deriveManifestPathFromGameId(gameId);
 }
 
-function normalizeAssetEntry(rawEntry, fallbackId = "") {
+function resolveManifestRelativePath(pathValue, manifestPath) {
+  const normalized = normalizePath(pathValue);
+  if (!normalized || hasUrlProtocol(normalized) || normalized.startsWith("/") || normalized.startsWith("//")) {
+    return normalized;
+  }
+  const baseManifestPath = normalizeManifestPath(manifestPath);
+  if (!baseManifestPath) {
+    return normalized;
+  }
+  const slashIndex = baseManifestPath.lastIndexOf("/");
+  const baseFolder = slashIndex >= 0 ? baseManifestPath.slice(0, slashIndex) : "";
+  return `${baseFolder}/${normalized.replace(/^\/+/, "")}`;
+}
+
+function normalizeAssetEntry(rawEntry, fallbackId = "", manifestPath = "") {
   const entry = toObject(rawEntry);
-  const path = normalizePath(entry.path || entry.runtimePath || entry.href);
+  const path = resolveManifestRelativePath(entry.path || entry.runtimePath || entry.href, manifestPath);
   if (!path) {
     return null;
   }
   return {
     id: safeText(entry.id, "") || safeText(fallbackId, ""),
     kind: safeText(entry.kind, "").toLowerCase(),
-    path
+    path,
+    role: safeText(entry.role, "").toLowerCase(),
+    type: safeText(entry.type, "").toLowerCase()
   };
 }
 
-function collectImageEntriesFromManifest(manifestPayload) {
+function collectImageEntriesFromManifest(manifestPayload, { manifestPath = "" } = {}) {
   const payload = toObject(manifestPayload);
   const entries = [];
 
+  const isImageEntry = (entry) => entry.type === "image"
+    || entry.kind === "image"
+    || entry.role === "background"
+    || entry.role === "bezel"
+    || entry.role === "preview"
+    || safeText(entry.id, "").toLowerCase().includes(".image.");
+
   const pushEntry = (entry) => {
     if (!entry || !entry.path) {
       return;
     }
-    if (entry.kind && entry.kind !== "image") {
+    if (!isImageEntry(entry)) {
       return;
     }
     entries.push(entry);
   };
 
   const assetBrowserAssets = toObject(payload?.tools?.["asset-browser"]?.assets);
   Object.entries(assetBrowserAssets).forEach(([assetId, rawEntry]) => {
-    pushEntry(normalizeAssetEntry(rawEntry, assetId));
+    pushEntry(normalizeAssetEntry(rawEntry, assetId, manifestPath));
+  });
+
+  const assetManagerAssets = toObject(payload?.tools?.["asset-manager-v2"]?.assets);
+  Object.entries(assetManagerAssets).forEach(([assetId, rawEntry]) => {
+    pushEntry(normalizeAssetEntry(rawEntry, assetId, manifestPath));
   });
 
   return entries;
@@ -97,7 +125,8 @@ function chooseSemanticImagePath(entries, semanticToken) {
 
   const byId = normalizedEntries.find((entry) => {
     const id = safeText(entry?.id, "").toLowerCase();
-    return id.includes(token);
+    const role = safeText(entry?.role, "").toLowerCase();
+    return role === token || id.includes(token);
   });
   if (byId?.path) {
     return byId.path;
@@ -205,7 +234,7 @@ export async function resolveManifestChromeAssetPaths(options = {}) {
     };
   }
 
-  const imageEntries = collectImageEntriesFromManifest(manifestPayload);
+  const imageEntries = collectImageEntriesFromManifest(manifestPayload, { manifestPath: base.manifestPath });
   return {
     ...base,
     manifestPayload,