Skip to content

Commit 57d6f43

Browse files
author
DavidQ
committed
Remove deprecated Skin Editor tooling and skin.main.json files - PR_26139_029-remove-skin-editor-and-skin-main-files
1 parent 0270973 commit 57d6f43

60 files changed

Lines changed: 241 additions & 4307 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

docs/design/tools/TOOLS_REENGINEERING_INDEX.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ This index lists the remaining rebuild anchors, schema baseline, and support fol
1111
| `asset-pipeline` | `tools/Asset Pipeline` | rebuildable tool | core-03 | tools.asset-pipeline | core rebuild lane |
1212
| `svg-asset-studio` | `tools/SVG Asset Studio` | rebuildable tool | core-04 | tools.svg-asset-studio | core rebuild lane |
1313
| `sprite-editor` | `tools/Sprite Editor` | rebuildable tool | core-05 | tools.sprite-editor | core rebuild lane |
14-
| `skin-editor` | `tools/Skin Editor` | rebuildable tool | core-06 | tools.skin-editor | core rebuild lane |
1514
| `tile-map-editor` | `tools/Tilemap Studio` | rebuildable tool | core-07 | tools.tile-map-editor | core rebuild lane |
1615
| `tile-model-converter` | `tools/Tile Model Converter` | rebuildable tool | core-08 | tools.tile-model-converter | core rebuild lane |
1716
| `parallax-editor` | `tools/Parallax Scene Studio` | rebuildable tool | core-09 | tools.parallax-editor | core rebuild lane |

docs/design/tools/skin-editor/REENGINEERING_DESIGN.md

Lines changed: 0 additions & 131 deletions
This file was deleted.

docs/dev/dod/tool_ui_readiness_dod.md

Lines changed: 0 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -727,52 +727,6 @@ layer list empty after successful fetch
727727
seeded/demo layers shown instead of loaded layers
728728
```
729729

730-
## 12. Skin Editor (`skin-editor`)
731-
732-
### Required inputs
733-
734-
```text
735-
gameId context
736-
skin payload json when samplePresetPath is provided
737-
palette/context handoff from workspace or game context
738-
```
739-
740-
### Required controls
741-
742-
```text
743-
object list/workbench
744-
selected object controls
745-
palette list
746-
preview canvas
747-
status/summary/context fields
748-
```
749-
750-
### Required output fields
751-
752-
```text
753-
status text that reports Loaded preset or load failure
754-
active game context output
755-
palette availability output
756-
selected object output
757-
```
758-
759-
### Success
760-
761-
```text
762-
game context fields match loaded launch context
763-
palette list is populated when palette context is required
764-
selected object controls bind loaded skin payload
765-
preview canvas renders loaded object state
766-
```
767-
768-
### Failure
769-
770-
```text
771-
missing game context hidden
772-
palette context missing while editor reports ready
773-
preview uses fallback/default object data
774-
```
775-
776730
## 13. State Inspector (`state-inspector`)
777731

778732
### Required inputs
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
# PR_26139_029 Remove Skin Editor And Skin Main Files
2+
3+
## Summary
4+
5+
- Removed the deprecated Skin Editor tool folder, registry entry, workspace schema reference, tool schema, design doc, and active shell/tool-hint references.
6+
- Removed all `skin.main.json` files and their `workspace.asset-catalog.json` entries.
7+
- Removed the runtime `skin.main` loader path and booted Pong, Breakout, Bouncing Ball, and Solar System with their existing built-in scene defaults.
8+
- Removed Skin Editor sample slices 0226/0227 and the Skin Editor payload from sample 1902.
9+
- Updated active tests and active generated validation reports so current surfaces no longer expect Skin Editor.
10+
11+
## Validation
12+
13+
- PASS: `npm run build:manifest`
14+
- PASS: `node scripts\validate-json-contracts.mjs --mode=games --details`
15+
- `game_manifest_schema_validation: total=11 invalid=0`
16+
- PASS: `node scripts\validate-json-contracts.mjs --mode=all --details`
17+
- Regenerated active schema reports; game manifest rows remain valid. Existing non-game strict schema/sample rows still report their current known invalid entries.
18+
- PASS: `node scripts\validate-tool-registry.mjs`
19+
- PASS: `npm run test:workspace-v2`
20+
- 58 passed
21+
- PASS: `node tests\tools\ToolSchemaStrictModeValidation.test.mjs`
22+
- PASS: direct tools index/registry assertion for removed Skin Editor.
23+
- PASS: active exact-reference sweeps for `skin-editor`, `Skin Editor`, `Primitive Skin Editor`, `primitive-skin-editor`, `skin.main.json`, `skin.main`, `loadGameSkin`, and `gameSkinLoader`.
24+
25+
## Notes
26+
27+
- Historical reports under `docs/dev/reports` still contain old PR/audit prose mentioning Skin Editor; active current surfaces and regenerated active reports do not.
28+
- Full launch smoke was not run because it creates workspace files under `tmp/`; the user explicitly reserved `tmp/` for the delta zip.

0 commit comments

Comments
 (0)