Continue AsteroidsGameScene cleanup without gameplay behavior changes - PR_26139_028-asteroids-game-scene-cleanup

DavidQ · DavidQ · commit 0270973ee294 · 2026-05-19T21:37:12.000-04:00
diff --git a/docs/dev/reports/PR_26139_028-asteroids-game-scene-cleanup_report.md b/docs/dev/reports/PR_26139_028-asteroids-game-scene-cleanup_report.md
@@ -0,0 +1,46 @@
+# PR_26139_028-asteroids-game-scene-cleanup
+
+## Summary
+- Audited `AsteroidsGameScene.js` for isolated helper logic after PR_26139_027.
+- Extracted debug-event summary formatting and dev-console diagnostics context building into `games/Asteroids/game/asteroidsDebugDiagnostics.js`.
+- Kept `AsteroidsGameScene.js` focused on scene lifecycle, update, render, and orchestration.
+- Did not change beat timing, collision, manifest rendering, asteroid scale tuning, or ship flame flicker behavior.
+
+## Moved Logic
+- `formatAsteroidsDebugEventSummary`
+- `buildAsteroidsDebugDiagnosticsContext`
+- shared Asteroids debug world-stage list
+
+## Behavior Preservation
+- Gameplay state is still owned by `AsteroidsGameScene`, `AsteroidsSession`, and `AsteroidsWorld`.
+- The new diagnostics helper reads existing scene/world/session state and returns the same diagnostics contract used by Asteroids debug tooling.
+- Weighted beat timing remains owned by the PR_26139_027 helper and was not retuned.
+
+## Validation
+- PASS: `npm run build:manifest`
+- PASS: `npx playwright test tests/playwright/tools/AsteroidsBeatTiming.spec.mjs --project=playwright --workers=1 --reporter=list`
+  - 1 passed.
+- PASS: `npx playwright test tests/playwright/tools/AsteroidsGameSceneCleanup.spec.mjs --project=playwright --workers=1 --reporter=list`
+  - 1 passed.
+- PASS: `git diff --check`
+
+## Targeted Gameplay Smoke
+- Added `AsteroidsGameSceneCleanup.spec.mjs`.
+- The smoke boots Asteroids, starts gameplay from the booted scene, verifies active gameplay state, and exercises the extracted diagnostics helper through the scene debug integration path.
+
+## Coverage
+- Playwright impacted: Yes.
+- V8 coverage collected changed Asteroids files:
+  - `(56%) games/Asteroids/game/AsteroidsGameScene.js - changed JS file with browser V8 coverage`
+  - `(100%) games/Asteroids/game/asteroidsDebugDiagnostics.js - changed JS file with browser V8 coverage`
+
+## Full Samples
+- Full samples smoke test was skipped.
+- Reason: scope is limited to Asteroids scene helper extraction with targeted Asteroids gameplay and beat timing validation.
+
+## Manual Validation
+1. Launch `games/Asteroids/index.html`.
+2. Start a one-player game.
+3. Confirm ship, asteroids, bullets, UFOs, and manifest-rendered objects behave as before.
+4. Confirm large-to-medium-to-small asteroid splitting keeps the PR_26139_027 weighted beat cadence behavior.
+5. Confirm no console errors appear during normal gameplay.
diff --git a/games/Asteroids/game/AsteroidsGameScene.js b/games/Asteroids/game/AsteroidsGameScene.js
@@ -14,6 +14,11 @@ import AsteroidsAttractAdapter from './AsteroidsAttractAdapter.js';
 import AsteroidsHighScoreService from '../systems/AsteroidsHighScoreService.js';
 import AsteroidsInitialsEntry from '../systems/AsteroidsInitialsEntry.js';
 import { createAsteroidGeometryProfilesFromObjectVectorAssets } from './asteroidObjectGeometry.js';
+import {
+  ASTEROIDS_DEBUG_WORLD_STAGES,
+  buildAsteroidsDebugDiagnosticsContext,
+  formatAsteroidsDebugEventSummary
+} from './asteroidsDebugDiagnostics.js';
 import {
   calculateAsteroidsBeatTiming,
   getAsteroidsBeatWeightedTotal
@@ -289,17 +294,6 @@ export default class AsteroidsGameScene extends Scene {
     }
   }
 
-  formatDebugEventSummary(details = {}) {
-    if (!details || typeof details !== 'object') {
-      return '';
-    }
-
-    const summaryParts = Object.entries(details)
-      .map(([key, value]) => `${key}=${String(value)}`)
-      .slice(0, 4);
-    return summaryParts.join(' ');
-  }
-
   pushDebugEvent(type, details = {}) {
     const eventType = typeof type === 'string' ? type.trim() : '';
     if (!eventType) {
@@ -309,7 +303,7 @@ export default class AsteroidsGameScene extends Scene {
     const entry = {
       frame: this.debugFrame,
       type: eventType,
-      summary: this.formatDebugEventSummary(details),
+      summary: formatAsteroidsDebugEventSummary(details),
       details: { ...details },
       timestamp: Date.now(),
     };
@@ -411,103 +405,6 @@ export default class AsteroidsGameScene extends Scene {
     this.lastWave = this.world.wave;
   }
 
-  buildDebugDiagnosticsContext(engine, dtSeconds, frameEvents = {}) {
-    const safeDt = Number.isFinite(dtSeconds) && dtSeconds > 0 ? dtSeconds : 1 / 60;
-    const fps = safeDt > 0 ? Math.round(1 / safeDt) : 0;
-    const activePlayer = this.session.activePlayer || { id: 1, score: 0, lives: 0 };
-    const recentEvents = this.debugEvents.slice(-12);
-    const input = engine?.input;
-    const worldStages = ['parallax', 'entities', 'sprite-effects', 'vector-overlay'];
-
-    return {
-      runtime: {
-        sceneId: 'asteroids-showcase',
-        status: this.session.mode,
-        fps,
-        frameTimeMs: Math.round(safeDt * 1000 * 100) / 100,
-        debugMode: this.debugConfig.debugMode,
-        debugEnabled: this.debugConfig.debugEnabled === true,
-      },
-      camera: {
-        x: 0,
-        y: 0,
-        viewportWidth: this.world.bounds.width,
-        viewportHeight: this.world.bounds.height,
-      },
-      entities: {
-        count: (this.world.shipActive ? 1 : 0) + this.world.asteroids.length + this.world.bullets.length + this.world.ufoBullets.length + (this.world.ufo ? 1 : 0),
-        shipActive: this.world.shipActive,
-        asteroidCount: this.world.asteroids.length,
-        bulletCount: this.world.bullets.length,
-        ufoBulletCount: this.world.ufoBullets.length,
-      },
-      tilemap: {
-        width: 0,
-        height: 0,
-        tileSize: 0,
-      },
-      input: {
-        left: input?.isDown?.('ArrowLeft') === true,
-        right: input?.isDown?.('ArrowRight') === true,
-        thrust: input?.isDown?.('ArrowUp') === true,
-        fire: input?.isDown?.('Space') === true,
-        pause: input?.isDown?.('KeyP') === true,
-        consoleToggle: input?.isDown?.('ShiftLeft') === true && input?.isDown?.('Backquote') === true,
-        overlayToggle: (input?.isDown?.('ControlLeft') === true || input?.isDown?.('ControlRight') === true) && input?.isDown?.('ShiftLeft') === true && input?.isDown?.('Backquote') === true,
-      },
-      hotReload: {
-        enabled: false,
-        pending: false,
-        mode: 'showcase-manual',
-      },
-      validation: {
-        errorCount: 0,
-        warningCount: 0,
-        asteroidsRecentEvents: recentEvents,
-        asteroidsFrameEvents: frameEvents,
-      },
-      render: {
-        stages: worldStages,
-        debugSurfaceTail: ['debug-overlay', 'dev-console-surface'],
-      },
-      assets: {
-        asteroidsShowcase: {
-          session: {
-            mode: this.session.mode,
-            status: this.session.status,
-            activePlayer: activePlayer.id,
-            score: activePlayer.score,
-            highScore: this.session.highScore,
-            lives: activePlayer.lives,
-            wave: this.world.wave,
-            isPaused: this.isPaused,
-          },
-          entities: {
-            ship: {
-              active: this.world.shipActive,
-              x: this.world.ship.x,
-              y: this.world.ship.y,
-              vx: this.world.ship.vx,
-              vy: this.world.ship.vy,
-              angle: this.world.ship.angle,
-            },
-            asteroidCount: this.world.asteroids.length,
-            bulletCount: this.world.bullets.length,
-            ufoBulletCount: this.world.ufoBullets.length,
-            ufo: {
-              active: Boolean(this.world.ufo),
-              type: this.world.ufo?.type || '',
-            },
-          },
-          presets: {
-            defaultCommand: 'asteroidsshowcase.preset.default',
-            eventsCommand: 'asteroidsshowcase.preset.events',
-          },
-        },
-      },
-    };
-  }
-
   updateDebugIntegration(engine, dtSeconds, frameEvents = {}) {
     if (!this.devConsoleIntegration) {
       return;
@@ -516,7 +413,16 @@ export default class AsteroidsGameScene extends Scene {
     this.devConsoleIntegration.update({
       engine,
       scene: this,
-      diagnosticsContext: this.buildDebugDiagnosticsContext(engine, dtSeconds, frameEvents),
+      diagnosticsContext: buildAsteroidsDebugDiagnosticsContext({
+        debugConfig: this.debugConfig,
+        debugEvents: this.debugEvents,
+        dtSeconds,
+        engine,
+        frameEvents,
+        isPaused: this.isPaused,
+        session: this.session,
+        world: this.world
+      }),
     });
   }
 
@@ -882,7 +788,7 @@ export default class AsteroidsGameScene extends Scene {
 
     if (this.devConsoleIntegration) {
       this.devConsoleIntegration.render(renderer, {
-        worldStages: ['parallax', 'entities', 'sprite-effects', 'vector-overlay'],
+        worldStages: [...ASTEROIDS_DEBUG_WORLD_STAGES],
       });
     }
     this.publishObjectVectorRuntimeDiagnostics();
diff --git a/games/Asteroids/game/asteroidsDebugDiagnostics.js b/games/Asteroids/game/asteroidsDebugDiagnostics.js
@@ -0,0 +1,117 @@
+export const ASTEROIDS_DEBUG_WORLD_STAGES = Object.freeze(['parallax', 'entities', 'sprite-effects', 'vector-overlay']);
+
+export function formatAsteroidsDebugEventSummary(details = {}) {
+  if (!details || typeof details !== 'object') {
+    return '';
+  }
+
+  const summaryParts = Object.entries(details)
+    .map(([key, value]) => `${key}=${String(value)}`)
+    .slice(0, 4);
+  return summaryParts.join(' ');
+}
+
+export function buildAsteroidsDebugDiagnosticsContext({
+  debugConfig,
+  debugEvents,
+  dtSeconds,
+  engine,
+  frameEvents,
+  isPaused,
+  session,
+  world,
+}) {
+  const safeDt = Number.isFinite(dtSeconds) && dtSeconds > 0 ? dtSeconds : 1 / 60;
+  const fps = safeDt > 0 ? Math.round(1 / safeDt) : 0;
+  const activePlayer = session.activePlayer || { id: 1, score: 0, lives: 0 };
+  const recentEvents = debugEvents.slice(-12);
+  const input = engine?.input;
+
+  return {
+    runtime: {
+      sceneId: 'asteroids-showcase',
+      status: session.mode,
+      fps,
+      frameTimeMs: Math.round(safeDt * 1000 * 100) / 100,
+      debugMode: debugConfig.debugMode,
+      debugEnabled: debugConfig.debugEnabled === true,
+    },
+    camera: {
+      x: 0,
+      y: 0,
+      viewportWidth: world.bounds.width,
+      viewportHeight: world.bounds.height,
+    },
+    entities: {
+      count: (world.shipActive ? 1 : 0) + world.asteroids.length + world.bullets.length + world.ufoBullets.length + (world.ufo ? 1 : 0),
+      shipActive: world.shipActive,
+      asteroidCount: world.asteroids.length,
+      bulletCount: world.bullets.length,
+      ufoBulletCount: world.ufoBullets.length,
+    },
+    tilemap: {
+      width: 0,
+      height: 0,
+      tileSize: 0,
+    },
+    input: {
+      left: input?.isDown?.('ArrowLeft') === true,
+      right: input?.isDown?.('ArrowRight') === true,
+      thrust: input?.isDown?.('ArrowUp') === true,
+      fire: input?.isDown?.('Space') === true,
+      pause: input?.isDown?.('KeyP') === true,
+      consoleToggle: input?.isDown?.('ShiftLeft') === true && input?.isDown?.('Backquote') === true,
+      overlayToggle: (input?.isDown?.('ControlLeft') === true || input?.isDown?.('ControlRight') === true) && input?.isDown?.('ShiftLeft') === true && input?.isDown?.('Backquote') === true,
+    },
+    hotReload: {
+      enabled: false,
+      pending: false,
+      mode: 'showcase-manual',
+    },
+    validation: {
+      errorCount: 0,
+      warningCount: 0,
+      asteroidsRecentEvents: recentEvents,
+      asteroidsFrameEvents: frameEvents,
+    },
+    render: {
+      stages: [...ASTEROIDS_DEBUG_WORLD_STAGES],
+      debugSurfaceTail: ['debug-overlay', 'dev-console-surface'],
+    },
+    assets: {
+      asteroidsShowcase: {
+        session: {
+          mode: session.mode,
+          status: session.status,
+          activePlayer: activePlayer.id,
+          score: activePlayer.score,
+          highScore: session.highScore,
+          lives: activePlayer.lives,
+          wave: world.wave,
+          isPaused,
+        },
+        entities: {
+          ship: {
+            active: world.shipActive,
+            x: world.ship.x,
+            y: world.ship.y,
+            vx: world.ship.vx,
+            vy: world.ship.vy,
+            angle: world.ship.angle,
+          },
+          asteroidCount: world.asteroids.length,
+          bulletCount: world.bullets.length,
+          ufoBulletCount: world.ufoBullets.length,
+          ufo: {
+            active: Boolean(world.ufo),
+            type: world.ufo?.type || '',
+          },
+        },
+        presets: {
+          defaultCommand: 'asteroidsshowcase.preset.default',
+          eventsCommand: 'asteroidsshowcase.preset.events',
+        },
+      },
+    },
+  };
+}
diff --git a/tests/playwright/tools/AsteroidsGameSceneCleanup.spec.mjs b/tests/playwright/tools/AsteroidsGameSceneCleanup.spec.mjs
