Remove Asset Manager V2 keyboard navigation - PR_26126_104-asset-manager-v2-remove-keyboard-navigation

Author: DavidQ

docs/dev/reports/PR_26126_101_asset_manager_v2_keyboard_navigation_notes.md

@@ -15,7 +15,7 @@
 - `docs/dev/reports/playwright_v8_coverage_report.txt` was regenerated by the required workspace-v2 validation run.
 
 ## Manual Checks Covered By Tests
-- Arrow-key adjacent tile selection updates selected tile, Selected Asset Detail, preview, and keyboard focus.
+- Asset tile keyboard navigation from this historical report was removed by PR_26126_104; Asset Manager V2 asset selection is click/tap driven only.
 - Selected color swatch gets a visible white selected border on the button and inner swatch.
 - Valid imported JSON still loads when referenced files are missing.
 - Missing referenced files are logged to Status with asset ID and path.

docs/dev/reports/PR_26126_101_asset_manager_v2_manual_validation_notes.md

@@ -17,7 +17,5 @@
 - Missing referenced files remain Status warnings with asset ID and path.
 - Missing referenced files do not fail otherwise valid imported JSON.
 - Missing file asset tiles render red `type:role` text.
-- Arrow keys work from a focused tile button and the Assets list.
-- Home, End, PageUp, PageDown, and Enter fallback navigation works where appropriate.
-- Keyboard selection updates selected tile styling, Selected Asset Detail, preview, and focus.
+- Asset tile keyboard navigation from this historical report was removed by PR_26126_104; Asset Manager V2 asset selection is click/tap driven only.
 - Sample JSON files were not modified.

docs/dev/reports/PR_26126_102_asset_manager_v2_keyboard_navigation_notes.md

@@ -8,9 +8,7 @@
 
 ## Results
 - `npm run test:workspace-v2` passed 12/12 Playwright tests.
-- Asset Manager V2 tool-mode validation covers WASD tile navigation from selected tile focus and Assets list focus.
-- Selection, Selected Asset Detail, and preview update after WASD navigation.
-- WASD handled key events are verified as default-prevented.
-- Arrow/Home/Page/Enter asset navigation handling was removed from Asset Manager V2.
+- PR_26126_104 superseded the asset navigation behavior from this historical report.
+- Asset Manager V2 asset selection is click/tap driven only after PR_26126_104.
 - Missing-file tile and Status warning behavior remains covered.
 - No sample JSON was modified.

docs/dev/reports/PR_26126_102_asset_manager_v2_manual_validation_notes.md

@@ -1,12 +1,12 @@
 # PR_26126_103 Scope Cleanup Notes
 
 ## PreviewGeneratorV2Baseline Review
-- `tests/playwright/PreviewGeneratorV2Baseline.spec.mjs` was changed in PR_26126_101 and PR_26126_102 to cover Asset Manager V2 asset tile keyboard selection and missing-file tile warnings.
+- `tests/playwright/PreviewGeneratorV2Baseline.spec.mjs` was changed in PR_26126_101 and PR_26126_102 to cover Asset Manager V2 asset tile selection and missing-file tile warnings.
 - The file is still the exact test target for `npm run test:workspace-v2`, so Asset Manager V2 validation remains in this spec for the current repository test layout.
 - No Preview Generator V2 runtime dependency requires this file to stay changed. The remaining changes are limited to the Asset Manager V2 sections of the workspace-v2 baseline validation.
 
 ## Cleanup Applied
-- Removed the prior ArrowLeft, ArrowRight, ArrowUp, ArrowDown, Home, End, PageUp, PageDown, and Enter asset navigation expectations.
-- Replaced them with WASD-only Asset Manager V2 navigation coverage.
+- PR_26126_104 superseded this cleanup by removing all Asset Manager V2 asset keyboard navigation coverage.
+- Asset Manager V2 asset selection is click/tap driven only after PR_26126_104.
 - Kept the missing-file tile assertions because they validate Asset Manager V2 behavior from PR_26126_102 and are not Preview Generator behavior.
 - Did not modify sample JSON.

docs/dev/reports/PR_26126_103_asset_manager_v2_manual_validation_notes.md

@@ -0,0 +1,18 @@
+# PR_26126_104 Keyboard Removal Notes
+
+## Removed Behavior
+- Asset Manager V2 no longer registers an Assets list `keydown` handler.
+- WASD asset navigation helpers were removed.
+- ArrowLeft, ArrowRight, ArrowUp, ArrowDown, Home, End, PageUp, PageDown, and Enter asset navigation handling was removed.
+- Asset tile buttons are not in the tab order.
+- Keyboard-generated click events are ignored for asset selection.
+
+## Preserved Behavior
+- Mouse/click/tap selection still calls the existing Asset Manager V2 selection callback.
+- Selected tile styling, Selected Asset Detail, and asset preview remain synchronized after click selection.
+- Missing-file tile styling and Status warning behavior remain unchanged.
+
+## Report Cleanup
+- Removed the PR_26126_101, PR_26126_102, and PR_26126_103 keyboard-navigation note files that described asset keyboard navigation as present.
+- Updated related historical manual/scope notes so they no longer claim Asset Manager V2 has keyboard asset navigation.
+- No sample JSON was modified.

docs/dev/reports/PR_26126_103_asset_manager_v2_scope_cleanup_notes.md

@@ -0,0 +1,15 @@
+# PR_26126_104 Manual Validation Notes
+
+## Commands
+- `node --check tools/asset-manager-v2/js/controls/AssetCatalogControl.js`
+- `node --check tests/playwright/PreviewGeneratorV2Baseline.spec.mjs`
+- `npm run test:workspace-v2`
+- `git diff --check`
+
+## Results
+- `npm run test:workspace-v2` passed 12/12 Playwright tests.
+- Playwright validates Asset Manager V2 has no list/tab tile navigation hooks.
+- Playwright validates W, A, S, D, ArrowLeft, ArrowRight, ArrowUp, ArrowDown, Home, End, PageUp, PageDown, and Enter do not change the selected asset.
+- Playwright validates mouse click selection still updates the selected tile, Selected Asset Detail, and preview.
+- JavaScript syntax checks passed for the changed Asset Manager V2 control and workspace-v2 Playwright spec.
+- No sample JSON was modified.

docs/dev/reports/PR_26126_103_asset_manager_v2_wasd_navigation_notes.md

@@ -1,20 +1,32 @@
 # git status --short
-M docs/dev/reports/coverage_changed_js_guardrail.txt
+D docs/dev/reports/PR_26126_101_asset_manager_v2_keyboard_navigation_notes.md
+ M docs/dev/reports/PR_26126_101_asset_manager_v2_manual_validation_notes.md
+ D docs/dev/reports/PR_26126_102_asset_manager_v2_keyboard_navigation_notes.md
+ M docs/dev/reports/PR_26126_102_asset_manager_v2_manual_validation_notes.md
+ M docs/dev/reports/PR_26126_103_asset_manager_v2_manual_validation_notes.md
+ M docs/dev/reports/PR_26126_103_asset_manager_v2_scope_cleanup_notes.md
+ D docs/dev/reports/PR_26126_103_asset_manager_v2_wasd_navigation_notes.md
+ M docs/dev/reports/coverage_changed_js_guardrail.txt
  M docs/dev/reports/playwright_v8_coverage_report.txt
  M tests/playwright/PreviewGeneratorV2Baseline.spec.mjs
  M tools/asset-manager-v2/js/controls/AssetCatalogControl.js
-?? docs/dev/reports/PR_26126_103_asset_manager_v2_manual_validation_notes.md
-?? docs/dev/reports/PR_26126_103_asset_manager_v2_scope_cleanup_notes.md
-?? docs/dev/reports/PR_26126_103_asset_manager_v2_wasd_navigation_notes.md
+?? docs/dev/reports/PR_26126_104_asset_manager_v2_keyboard_removal_notes.md
+?? docs/dev/reports/PR_26126_104_asset_manager_v2_manual_validation_notes.md
 
 # git ls-files --others --exclude-standard
-docs/dev/reports/PR_26126_103_asset_manager_v2_manual_validation_notes.md
-docs/dev/reports/PR_26126_103_asset_manager_v2_scope_cleanup_notes.md
-docs/dev/reports/PR_26126_103_asset_manager_v2_wasd_navigation_notes.md
+docs/dev/reports/PR_26126_104_asset_manager_v2_keyboard_removal_notes.md
+docs/dev/reports/PR_26126_104_asset_manager_v2_manual_validation_notes.md
 
 # git diff --stat
-docs/dev/reports/coverage_changed_js_guardrail.txt |  3 +-
- docs/dev/reports/playwright_v8_coverage_report.txt | 10 ++--
- .../playwright/PreviewGeneratorV2Baseline.spec.mjs | 54 ++++++++++++----------
- .../js/controls/AssetCatalogControl.js             | 52 ++++++++++++++-------
- 4 files changed, 71 insertions(+), 48 deletions(-)
+...1_asset_manager_v2_keyboard_navigation_notes.md |  17 ----
+ ...101_asset_manager_v2_manual_validation_notes.md |   2 +-
+ ...2_asset_manager_v2_keyboard_navigation_notes.md |  26 ------
+ ...102_asset_manager_v2_manual_validation_notes.md |   4 +-
+ ...103_asset_manager_v2_manual_validation_notes.md |   6 +-
+ ...126_103_asset_manager_v2_scope_cleanup_notes.md |   6 +-
+ ...6_103_asset_manager_v2_wasd_navigation_notes.md |  17 ----
+ docs/dev/reports/coverage_changed_js_guardrail.txt |   3 +-
+ docs/dev/reports/playwright_v8_coverage_report.txt |   8 +-
+ .../playwright/PreviewGeneratorV2Baseline.spec.mjs |  57 ++++-------
+ .../js/controls/AssetCatalogControl.js             | 104 ++-------------------
+ 11 files changed, 36 insertions(+), 214 deletions(-)