Skip to content

Commit fbf49c1

Browse files
author
DavidQ
committed
Clean Asset Manager V2 scope drift and switch asset navigation to WASD - PR_26126_103-asset-manager-v2-wasd-and-scope-cleanup
1 parent 0683090 commit fbf49c1

9 files changed

Lines changed: 352 additions & 468 deletions

‎docs/dev/reports/PR_26126_103_asset_manager_v2_manual_validation_notes.md‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
# PR_26126_103 Manual Validation Notes
2+
3+
## Commands
4+
- `node --check tools/asset-manager-v2/js/controls/AssetCatalogControl.js`
5+
- `node --check tests/playwright/PreviewGeneratorV2Baseline.spec.mjs`
6+
- `npm run test:workspace-v2`
7+
- `git diff --check`
8+
9+
## Results
10+
- `npm run test:workspace-v2` passed 12/12 Playwright tests.
11+
- Asset Manager V2 tool-mode validation covers WASD tile navigation from selected tile focus and Assets list focus.
12+
- Selection, Selected Asset Detail, and preview update after WASD navigation.
13+
- WASD handled key events are verified as default-prevented.
14+
- Arrow/Home/Page/Enter asset navigation handling was removed from Asset Manager V2.
15+
- Missing-file tile and Status warning behavior remains covered.
16+
- No sample JSON was modified.

‎docs/dev/reports/PR_26126_103_asset_manager_v2_scope_cleanup_notes.md‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
# PR_26126_103 Scope Cleanup Notes
2+
3+
## PreviewGeneratorV2Baseline Review
4+
- `tests/playwright/PreviewGeneratorV2Baseline.spec.mjs` was changed in PR_26126_101 and PR_26126_102 to cover Asset Manager V2 asset tile keyboard selection and missing-file tile warnings.
5+
- The file is still the exact test target for `npm run test:workspace-v2`, so Asset Manager V2 validation remains in this spec for the current repository test layout.
6+
- No Preview Generator V2 runtime dependency requires this file to stay changed. The remaining changes are limited to the Asset Manager V2 sections of the workspace-v2 baseline validation.
7+
8+
## Cleanup Applied
9+
- Removed the prior ArrowLeft, ArrowRight, ArrowUp, ArrowDown, Home, End, PageUp, PageDown, and Enter asset navigation expectations.
10+
- Replaced them with WASD-only Asset Manager V2 navigation coverage.
11+
- Kept the missing-file tile assertions because they validate Asset Manager V2 behavior from PR_26126_102 and are not Preview Generator behavior.
12+
- Did not modify sample JSON.

‎docs/dev/reports/PR_26126_103_asset_manager_v2_wasd_navigation_notes.md‎

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
# PR_26126_103 WASD Navigation Notes
2+
3+
## Behavior
4+
- Asset tile keyboard selection now handles only W, A, S, and D.
5+
- A selects the previous asset in sorted tile order.
6+
- D selects the next asset in sorted tile order.
7+
- W moves to the previous row using the current rendered grid column count.
8+
- S moves to the next row using the current rendered grid column count.
9+
10+
## Focus And Sync
11+
- WASD works when focus is on the Assets list or on the currently selected asset tile/button.
12+
- Handled WASD key events call `preventDefault()`.
13+
- Selection updates continue to flow through the existing Asset Manager V2 select callback, keeping the selected tile, Selected Asset Detail, and preview synchronized.
14+
15+
## Removed Navigation
16+
- Asset tile navigation no longer handles ArrowLeft, ArrowRight, ArrowUp, ArrowDown, Home, End, PageUp, PageDown, or Enter.
17+
- Accordion Enter/Space handling remains unchanged because it is unrelated to asset tile navigation.

‎docs/dev/reports/codex_changed_files.txt‎

Lines changed: 11 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -2,23 +2,19 @@
22
M docs/dev/reports/coverage_changed_js_guardrail.txt
33
M docs/dev/reports/playwright_v8_coverage_report.txt
44
M tests/playwright/PreviewGeneratorV2Baseline.spec.mjs
5-
M tools/asset-manager-v2/js/AssetManagerV2App.js
65
M tools/asset-manager-v2/js/controls/AssetCatalogControl.js
7-
M tools/asset-manager-v2/styles/assetManager.css
8-
?? docs/dev/reports/PR_26126_102_asset_manager_v2_keyboard_navigation_notes.md
9-
?? docs/dev/reports/PR_26126_102_asset_manager_v2_manual_validation_notes.md
10-
?? docs/dev/reports/PR_26126_102_asset_manager_v2_missing_file_tile_notes.md
6+
?? docs/dev/reports/PR_26126_103_asset_manager_v2_manual_validation_notes.md
7+
?? docs/dev/reports/PR_26126_103_asset_manager_v2_scope_cleanup_notes.md
8+
?? docs/dev/reports/PR_26126_103_asset_manager_v2_wasd_navigation_notes.md
119

1210
# git ls-files --others --exclude-standard
13-
docs/dev/reports/PR_26126_102_asset_manager_v2_keyboard_navigation_notes.md
14-
docs/dev/reports/PR_26126_102_asset_manager_v2_manual_validation_notes.md
15-
docs/dev/reports/PR_26126_102_asset_manager_v2_missing_file_tile_notes.md
11+
docs/dev/reports/PR_26126_103_asset_manager_v2_manual_validation_notes.md
12+
docs/dev/reports/PR_26126_103_asset_manager_v2_scope_cleanup_notes.md
13+
docs/dev/reports/PR_26126_103_asset_manager_v2_wasd_navigation_notes.md
1614

1715
# git diff --stat
18-
docs/dev/reports/coverage_changed_js_guardrail.txt | 7 +-
19-
docs/dev/reports/playwright_v8_coverage_report.txt | 16 ++--
20-
.../playwright/PreviewGeneratorV2Baseline.spec.mjs | 43 ++++++++++
21-
tools/asset-manager-v2/js/AssetManagerV2App.js | 20 ++++-
22-
.../js/controls/AssetCatalogControl.js | 93 ++++++++++++++++------
23-
tools/asset-manager-v2/styles/assetManager.css | 4 +
24-
6 files changed, 138 insertions(+), 45 deletions(-)
16+
docs/dev/reports/coverage_changed_js_guardrail.txt | 3 +-
17+
docs/dev/reports/playwright_v8_coverage_report.txt | 10 ++--
18+
.../playwright/PreviewGeneratorV2Baseline.spec.mjs | 54 ++++++++++++----------
19+
.../js/controls/AssetCatalogControl.js | 52 ++++++++++++++-------
20+
4 files changed, 71 insertions(+), 48 deletions(-)

0 commit comments

Comments
 (0)