Skip to content

Commit 3b8af2f

Browse files
author
DavidQ
committed
Add snap cycling selection defaults preview edit actions and geometry hit selection - PR_26133_064-snap-cycle-selection-and-preview-edit-actions
1 parent 2333982 commit 3b8af2f

7 files changed

Lines changed: 280 additions & 105 deletions

File tree

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,14 @@
11
# Playwright V8 Coverage Report
22

3-
PR: PR_26133_063-click-drag-shape-creation-and-snap-modes
3+
PR: PR_26133_064-snap-cycle-selection-and-preview-edit-actions
44

5-
Source: `docs/dev/reports/playwright_v8_coverage_report.txt` generated by `npm run test:workspace-v2`.
5+
Source: docs/dev/reports/playwright_v8_coverage_report.txt generated by the latest npm run test:workspace-v2 run.
6+
7+
## Summary
8+
9+
- PASS: V8 coverage was collected during the green workspace-v2 Playwright run.
10+
- Thresholds: advisory only; no blocking threshold configured.
11+
- Dependencies: no new npm packages.
612

713
## Exercised Tool Entry Points
814

@@ -15,12 +21,16 @@ Source: `docs/dev/reports/playwright_v8_coverage_report.txt` generated by `npm r
1521

1622
## Changed Runtime JS Files Covered
1723

18-
- (83%) tools/object-vector-studio-v2/js/bootstrap.js - executed lines 107/107; executed functions 5/6
24+
- (83%) tools/object-vector-studio-v2/js/bootstrap.js - executed lines 105/105; executed functions 5/6
1925
- (94%) src/engine/rendering/ObjectVectorRuntimeAssetService.js - executed lines 1135/1135; executed functions 111/118
2026
- (95%) tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js - executed lines 454/454; executed functions 55/58
21-
- (95%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 6198/6198; executed functions 635/666
27+
- (95%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 6250/6250; executed functions 637/668
2228

23-
## Result
29+
## Changed JS Files Considered
2430

25-
- Coverage generation completed successfully after the workspace-v2 Playwright run.
26-
- Coverage is advisory; no coverage threshold is enforced by this PR.
31+
- (0%) tests/helpers/playwrightV8CoverageReporter.mjs - changed JS file not collected as browser runtime coverage
32+
- (0%) tests/playwright/tools/WorkspaceManagerV2.spec.mjs - changed JS file not collected as browser runtime coverage
33+
- (83%) tools/object-vector-studio-v2/js/bootstrap.js - changed JS file with browser V8 coverage
34+
- (94%) src/engine/rendering/ObjectVectorRuntimeAssetService.js - changed JS file with browser V8 coverage
35+
- (95%) tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js - changed JS file with browser V8 coverage
36+
- (95%) tools/object-vector-studio-v2/js/ToolStarterApp.js - changed JS file with browser V8 coverage
Lines changed: 16 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,24 @@
11
# Playwright Workspace V2 Results
22

3-
PR: PR_26133_063-click-drag-shape-creation-and-snap-modes
3+
PR: PR_26133_064-snap-cycle-selection-and-preview-edit-actions
44

5-
## Commands
5+
## Validation
66

7-
- `node --check tools/object-vector-studio-v2/js/ToolStarterApp.js` - PASS
8-
- `node --check tools/object-vector-studio-v2/js/bootstrap.js` - PASS
9-
- `node --check src/engine/rendering/ObjectVectorRuntimeAssetService.js` - PASS
10-
- `node --check tests/helpers/playwrightV8CoverageReporter.mjs` - PASS
11-
- `node -e "JSON.parse(require('fs').readFileSync('tools/schemas/tools/object-vector-studio-v2.schema.json','utf8')); JSON.parse(require('fs').readFileSync('tools/schemas/game.manifest.schema.json','utf8')); console.log('schema json ok')"` - PASS
12-
- `npm run test:workspace-v2` - PASS, 54 passed
7+
- PASS: npm run test:workspace-v2
8+
- Result: 54 passed
9+
- Runtime: 4.4m
10+
- Browser project: playwright
11+
- Workers: 1
1312

14-
## Object Vector Studio V2 Verification
13+
## Targeted Checks Covered
1514

16-
- Selecting Shape/Tools enters drawing mode instead of dropping preset defaults.
17-
- Line creation uses first click, live preview, and second click commit.
18-
- Polygon and Polyline creation use clicked points with Enter/double-click finish once valid.
19-
- Esc cancels active drawing without committing invalid geometry.
20-
- Rectangle, Square, Circle, Ellipse, Arc, Triangle, and Text creation use canvas pointer flows.
21-
- Snap Grid, Snap Point, and Snap None are covered during drawing and point dragging; Snap Point renders visible point targets.
22-
- Palette renders at the top of the right column, and Object Transform renders under Shape/Tools.
23-
- No console/runtime errors were reported by the successful Playwright workspace-v2 run.
15+
- Snap button cycles Snap Grid -> Snap Point -> Snap None -> Snap Grid, with mode labels/icons updated.
16+
- Shape selection sets Stroke as the active Paint/Stroke mode without applying color.
17+
- Object Geometry and Object Transform locations are swapped.
18+
- Object Preview edit toolbar renders under Object ID with an HR separator; Undo/Redo/Copy/Paste are visibly disabled because backing behavior is not wired.
19+
- Canvas geometry hit testing selects filled and stroke-only shapes, including transformed geometry.
20+
- Existing mouse edit, transform-bounds, dirty-state, and Object Vector Studio V2 authoring tests remain green.
2421

25-
## Notes
22+
## Console/Runtime Errors
2623

27-
- A small V8 coverage reporter optimization keeps the required coverage write inside the Playwright afterAll timeout without changing coverage semantics.
24+
- PASS: Object Vector Studio V2 Playwright coverage keeps page error and console error collections empty in the exercised flows.

0 commit comments

Comments
 (0)