Convert Object Vector Studio to interactive shape drawing with snap modes and polyline - PR_26133_063-click-drag-shape-creation-and-snap-modes

Author: DavidQ

docs/dev/reports/playwright_v8_coverage_report.md

@@ -1,39 +1,26 @@
-# PR_26133_062 Playwright V8 Coverage Report
+# Playwright V8 Coverage Report
 
-Task: PR_26133_062-object-vector-future-notes-tool-sort-and-live-point-edit
-Date: 2026-05-15
+PR: PR_26133_063-click-drag-shape-creation-and-snap-modes
 
-## Result
-
-PASS - Coverage reporting was generated during `npm run test:workspace-v2`.
-
-- Coverage source: Playwright/Chromium built-in V8 coverage.
-- Thresholds: none enforced.
-- Coverage is advisory for this PR.
-- Source report: `docs/dev/reports/playwright_v8_coverage_report.txt`.
+Source: `docs/dev/reports/playwright_v8_coverage_report.txt` generated by `npm run test:workspace-v2`.
 
 ## Exercised Tool Entry Points
 
-```text
-(82%) Preview Generator V2 - exercised 19 runtime JS files
-(74%) Asset Manager V2 - exercised 13 runtime JS files
-(62%) Palette Manager V2 - exercised 12 runtime JS files
-(91%) Workspace Manager V2 - exercised 10 runtime JS files
-```
+- (82%) Preview Generator V2 - exercised 19 runtime JS files
+- (74%) Asset Manager V2 - exercised 13 runtime JS files
+- (62%) Palette Manager V2 - exercised 12 runtime JS files
+- (0%) Tool Template V2 - not exercised by this Playwright run
+- (91%) Workspace Manager V2 - exercised 10 runtime JS files
+- (0%) Workspace Manager - not exercised by this Playwright run
 
-## Relevant Runtime Coverage
+## Changed Runtime JS Files Covered
 
-```text
-(94%) src/engine/rendering/ObjectVectorRuntimeAssetService.js - executed lines 1131/1131; executed functions 111/118
-(95%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 5731/5731; executed functions 605/636
-```
+- (83%) tools/object-vector-studio-v2/js/bootstrap.js - executed lines 107/107; executed functions 5/6
+- (94%) src/engine/rendering/ObjectVectorRuntimeAssetService.js - executed lines 1135/1135; executed functions 111/118
+- (95%) tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js - executed lines 454/454; executed functions 55/58
+- (95%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 6198/6198; executed functions 635/666
 
-## Guardrail
-
-```text
-(100%) none - no changed runtime JS coverage warnings
-```
-
-## PR-Specific Note
+## Result
 
-The Workspace V2 run exercised Object Vector Studio V2 Shape/Tools ordering, Angle Snap UI/status behavior, live geometry point-handle editing before mouseup, Object Geometry input refresh during drag, workspace dirty tracking during drag, schema validation, and Asteroids runtime object-vector rendering.
+- Coverage generation completed successfully after the workspace-v2 Playwright run.
+- Coverage is advisory; no coverage threshold is enforced by this PR.

docs/dev/reports/playwright_workspace_v2_results.md

@@ -1,27 +1,27 @@
-# PR_26133_062 Workspace V2 Playwright Results
+# Playwright Workspace V2 Results
 
-Task: PR_26133_062-object-vector-future-notes-tool-sort-and-live-point-edit
-Date: 2026-05-15
+PR: PR_26133_063-click-drag-shape-creation-and-snap-modes
 
-## Result
+## Commands
 
-PASS - `npm run test:workspace-v2` completed successfully.
+- `node --check tools/object-vector-studio-v2/js/ToolStarterApp.js` - PASS
+- `node --check tools/object-vector-studio-v2/js/bootstrap.js` - PASS
+- `node --check src/engine/rendering/ObjectVectorRuntimeAssetService.js` - PASS
+- `node --check tests/helpers/playwrightV8CoverageReporter.mjs` - PASS
+- `node -e "JSON.parse(require('fs').readFileSync('tools/schemas/tools/object-vector-studio-v2.schema.json','utf8')); JSON.parse(require('fs').readFileSync('tools/schemas/game.manifest.schema.json','utf8')); console.log('schema json ok')"` - PASS
+- `npm run test:workspace-v2` - PASS, 54 passed
 
-- Command: `npm run test:workspace-v2`
-- Playwright target: `tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list`
-- Final result: 53 passed, 0 failed.
-- Runtime/console guard: Workspace Manager V2, Object Vector Studio V2, and Asteroids runtime scenarios completed with no reported page errors.
+## Object Vector Studio V2 Verification
 
-## PR-Specific Coverage
+- Selecting Shape/Tools enters drawing mode instead of dropping preset defaults.
+- Line creation uses first click, live preview, and second click commit.
+- Polygon and Polyline creation use clicked points with Enter/double-click finish once valid.
+- Esc cancels active drawing without committing invalid geometry.
+- Rectangle, Square, Circle, Ellipse, Arc, Triangle, and Text creation use canvas pointer flows.
+- Snap Grid, Snap Point, and Snap None are covered during drawing and point dragging; Snap Point renders visible point targets.
+- Palette renders at the top of the right column, and Object Transform renders under Shape/Tools.
+- No console/runtime errors were reported by the successful Playwright workspace-v2 run.
 
-- Verified `possible.future.adds.txt` contains the Object Vector atomic-object, future World Vector/Scene instancing, Object/World separation, and future 3D point3d/camera/projection/mesh notes.
-- Verified Shape/Tools order is Select first, alphabetical middle, and Text last.
-- Verified Angle Snap UI documents current behavior: enabled Angle Snap rounds the Rotate action's entered delta to 15 degree increments; disabled uses the raw entered delta.
-- Verified point-handle dragging updates geometry, Object Geometry inputs, preview geometry, selection handle position, and workspace dirty state before mouseup.
-- Verified Object Vector Studio V2 and Asteroids runtime scenarios completed without page or console errors.
+## Notes
 
-## Additional Validation
-
-- Focused Shape/Tools, Square creation, and dirty-state live edit slices passed:
-  `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list --grep "layout shell|square shapes|dirty state"` completed with 3 passed, 0 failed.
-- `git diff --check` passed. The command reported existing Windows LF-to-CRLF warnings for touched files and no whitespace errors.
+- A small V8 coverage reporter optimization keeps the required coverage write inside the Playwright afterAll timeout without changing coverage semantics.

src/engine/rendering/ObjectVectorRuntimeAssetService.js

@@ -179,7 +179,7 @@ function shapeBounds(shape) {
       y
     };
   }
-  if (geometryTool === "polygon") {
+  if (geometryTool === "polygon" || geometryTool === "polyline") {
     const xValues = shape.geometry.points.map((point) => point.x);
     const yValues = shape.geometry.points.map((point) => point.y);
     const minX = Math.min(...xValues);
@@ -766,15 +766,17 @@ export class ObjectVectorRuntimeAssetService {
       context.lineTo(shape.geometry.point2.x, shape.geometry.point2.y);
       return;
     }
-    if (geometryTool === "polygon") {
+    if (geometryTool === "polygon" || geometryTool === "polyline") {
       shape.geometry.points.forEach((point, index) => {
         if (index === 0) {
           context.moveTo(point.x, point.y);
         } else {
           context.lineTo(point.x, point.y);
         }
       });
-      context.closePath();
+      if (geometryTool === "polygon") {
+        context.closePath();
+      }
       return;
     }
     if (geometryTool === "arc") {
@@ -836,9 +838,11 @@ export class ObjectVectorRuntimeAssetService {
     if (geometryTool === "line") {
       return `<line x1="${shape.geometry.point1.x}" y1="${shape.geometry.point1.y}" x2="${shape.geometry.point2.x}" y2="${shape.geometry.point2.y}"${style}/>`;
     }
-    if (geometryTool === "polygon") {
+    if (geometryTool === "polygon" || geometryTool === "polyline") {
       const points = shape.geometry.points.map((point) => `${point.x},${point.y}`).join(" ");
-      return `<polygon points="${points}"${style}/>`;
+      return geometryTool === "polygon"
+        ? `<polygon points="${points}"${style}/>`
+        : `<polyline points="${points}"${style}/>`;
     }
     if (geometryTool === "arc") {
       const start = {

tests/helpers/playwrightV8CoverageReporter.mjs

@@ -135,11 +135,12 @@ export class PlaywrightV8CoverageReporter {
       return;
     }
     const lineStarts = this.lineStartOffsets(source);
+    const sourceLines = source.split(/\r?\n/);
     for (const range of this.executedRanges(entry)) {
       const startLine = this.lineNumberForOffset(lineStarts, range.startOffset);
       const endLine = this.lineNumberForOffset(lineStarts, Math.max(range.startOffset, range.endOffset - 1));
       for (let line = startLine; line <= endLine; line += 1) {
-        if (this.isCountableLine(source, line)) {
+        if (this.isCountableLine(sourceLines, line)) {
           record.executedLines.add(line);
         }
       }
@@ -206,7 +207,8 @@ export class PlaywrightV8CoverageReporter {
   }
 
   isCountableLine(source, oneBasedLineNumber) {
-    const line = source.split(/\r?\n/)[oneBasedLineNumber - 1] || "";
+    const sourceLines = Array.isArray(source) ? source : source.split(/\r?\n/);
+    const line = sourceLines[oneBasedLineNumber - 1] || "";
     return this.isCountableText(line);
   }