Skip to content

Commit 39338f7

Browse files
author
DavidQ
committed
Refine Object Vector Studio palette tools geometry controls and object actions - PR_26133_021-object-vector-studio-palette-tools-and-geometry-controls
1 parent 08daf5f commit 39338f7

7 files changed

Lines changed: 214 additions & 73 deletions

File tree

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
1-
# PR_26133_020 Playwright V8 Coverage Report
1+
# PR_26133_021 Playwright V8 Coverage Report
22

33
Coverage source: `docs/dev/reports/playwright_v8_coverage_report.txt`, refreshed by the final `npm run test:workspace-v2` run.
44

55
## Summary
66

77
- Coverage is advisory only; no thresholds are enforced.
8-
- Workspace Manager V2 entry point: 91%.
9-
- Object Vector Studio V2 runtime coverage entries from the generated report:
10-
- `tools/object-vector-studio-v2/js/bootstrap.js`: 83%, executed lines 105/105, executed functions 5/6.
11-
- `tools/object-vector-studio-v2/js/ToolStarterApp.js`: 93%, executed lines 4032/4032, executed functions 437/469.
8+
- Workspace Manager V2 entry point: `(91%) Workspace Manager V2 - exercised 10 runtime JS files`.
9+
- Changed Object Vector Studio V2 runtime JS coverage from the generated report:
10+
- `(83%) tools/object-vector-studio-v2/js/bootstrap.js - executed lines 106/106; executed functions 5/6`
11+
- `(93%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 4092/4092; executed functions 442/476`
1212
- Changed JS files considered by the generated report:
1313
- `tools/object-vector-studio-v2/js/bootstrap.js`: covered by browser V8 coverage.
1414
- `tools/object-vector-studio-v2/js/ToolStarterApp.js`: covered by browser V8 coverage.
@@ -18,5 +18,5 @@ Coverage source: `docs/dev/reports/playwright_v8_coverage_report.txt`, refreshed
1818

1919
- Main command: `npm run test:workspace-v2`.
2020
- Result: 48 passed.
21-
- Focused Object Vector Studio V2 icon, palette swatch, object delete cleanup, shape delete cleanup, polygon side editing, geometry-layout, preview coordinate, mouse-editing, animation-state, and asset-library scenarios passed as part of the workspace-v2 run.
22-
- Coverage includes the requested Nerd Font icon mappings, Object panel delete removal, tile delete reference cleanup, Paint/Stroke swatch rendering, and polygon side controls.
21+
- Focused Object Vector Studio V2 palette, icon mapping, Object Geometry header, polygon checkbox add/delete, transform icon, geometry-layout, preview coordinate, mouse-editing, animation-state, and asset-library scenarios passed as part of the workspace-v2 run.
22+
- Coverage includes the PR21 Object Vector Studio V2 runtime changes for glyph mapping, Object Geometry header state, and polygon point controls.

docs/dev/reports/playwright_workspace_v2_results.md

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,23 @@
1-
# PR_26133_020 Workspace V2 Results
1+
# PR_26133_021 Workspace V2 Results
22

33
## Command Results
44

55
- `node --check tools/object-vector-studio-v2/js/ToolStarterApp.js`: passed.
66
- `node --check tools/object-vector-studio-v2/js/bootstrap.js`: passed.
77
- `node --check tests/playwright/tools/WorkspaceManagerV2.spec.mjs`: passed.
8-
- `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list --grep "shows Object Vector Studio V2 layout shell|maps Object Vector Studio V2 preview coordinates|edits Object Vector Studio V2 preview shapes|supports Object Vector Studio V2 asset library"`: 4 passed after one test-only adjustment.
8+
- `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list -g "shows Object Vector Studio V2 layout shell and schema-only palette gate"`: 1 passed.
99
- `npm run test:workspace-v2`: 48 passed.
1010
- `git diff --check`: passed with LF-to-CRLF working-copy warnings for touched files.
1111

1212
## Targeted Object Vector Studio V2 Verification
1313

14-
- Confirmed requested Nerd Font glyph names are mapped for Triangle, Select, Zoom In, Zoom Out, Grid On/Off, Line, and Rectangle.
15-
- Confirmed Paint and Stroke buttons render a square color swatch before their icons and keep accessible labels/tooltips.
16-
- Confirmed Select icon renders 25% smaller and Rectangle icon renders 25% larger than the standard shape icon size.
17-
- Confirmed Object panel Delete is removed; object delete remains on object tiles only.
18-
- Confirmed object tile delete removes dependent `assetLibrary.assets[*].objectId`, `baseObjectId`, and dangling animation shape override references before schema validation.
19-
- Confirmed shape tile delete removes dependent `states[*].frames[*].shapeOverrides[*].shapeId` references before schema validation.
20-
- Confirmed Polygon Geometry Add Side/Subtract Side update the point list and reject invalid side counts visibly.
21-
- Confirmed workspace-v2 Object Vector Studio V2 scenarios reported no console/page errors.
14+
- Confirmed Palette no longer renders a `Stroke Width` label; `Width` sits to the right of the Stroke button in the palette control row.
15+
- Confirmed Shape/Tools icons use the requested mappings for Angle Snap, Select, Triangle, Rectangle, and existing tool glyphs; Select/Triangle/Rectangle are enlarged and Rectangle is offset upward.
16+
- Confirmed Object Transform action buttons use `nf-fa-scale_unbalanced` for Scale and `nf-md-resize` for Resize.
17+
- Confirmed Object Details is renamed to Object Geometry and the selected shape summary appears in the accordion header while the body no longer repeats `Shape <id> (<type>)`.
18+
- Confirmed polygon point rows expose checkboxes, Add Side inserts after the checked point and clears selections, Delete Point removes checked rows and clears selections, and invalid deletes are visibly rejected before schema-invalid point counts can apply.
19+
- Confirmed Object Add/Rename/Dup controls render directly under Object Name and above the Tag line.
20+
- Confirmed Object Vector Studio V2 tests reported no console/page errors in the targeted browser scenarios.
2221
- Confirmed `src/shared/font/0xProtoNerdFont` was preserved.
2322

2423
## Scope Checks

0 commit comments

Comments
 (0)