Skip to content

Commit 08daf5f

Browse files
author
DavidQ
committed
Fix Object Vector Studio icon mappings delete cleanup and polygon side controls - PR_26133_020-object-vector-studio-icon-delete-and-polygon-side-fixes
1 parent e2ed7a6 commit 08daf5f

7 files changed

Lines changed: 436 additions & 61 deletions

File tree

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# PR_26133_019 Playwright V8 Coverage Report
1+
# PR_26133_020 Playwright V8 Coverage Report
22

33
Coverage source: `docs/dev/reports/playwright_v8_coverage_report.txt`, refreshed by the final `npm run test:workspace-v2` run.
44

@@ -7,14 +7,16 @@ Coverage source: `docs/dev/reports/playwright_v8_coverage_report.txt`, refreshed
77
- Coverage is advisory only; no thresholds are enforced.
88
- Workspace Manager V2 entry point: 91%.
99
- Object Vector Studio V2 runtime coverage entries from the generated report:
10-
- `tools/object-vector-studio-v2/js/ToolStarterApp.js`: 93%, executed lines 3849/3849, executed functions 409/440.
10+
- `tools/object-vector-studio-v2/js/bootstrap.js`: 83%, executed lines 105/105, executed functions 5/6.
11+
- `tools/object-vector-studio-v2/js/ToolStarterApp.js`: 93%, executed lines 4032/4032, executed functions 437/469.
1112
- Changed JS files considered by the generated report:
13+
- `tools/object-vector-studio-v2/js/bootstrap.js`: covered by browser V8 coverage.
1214
- `tools/object-vector-studio-v2/js/ToolStarterApp.js`: covered by browser V8 coverage.
1315
- `tests/playwright/tools/WorkspaceManagerV2.spec.mjs`: not collected as browser runtime coverage.
1416

1517
## Validation Context
1618

1719
- Main command: `npm run test:workspace-v2`.
1820
- Result: 48 passed.
19-
- Focused Object Vector Studio V2 layout, icon, palette, geometry-layout, preview coordinate, mouse-editing, animation-state, and asset-authoring scenarios passed as part of the workspace-v2 run.
20-
- Coverage includes the scoped Nerd Font icon mapping, trash/delete glyph mapping, static palette/action icon decoration, dynamic tile icon decoration, shape delete targeting, and geometry layout checks.
21+
- Focused Object Vector Studio V2 icon, palette swatch, object delete cleanup, shape delete cleanup, polygon side editing, geometry-layout, preview coordinate, mouse-editing, animation-state, and asset-library scenarios passed as part of the workspace-v2 run.
22+
- Coverage includes the requested Nerd Font icon mappings, Object panel delete removal, tile delete reference cleanup, Paint/Stroke swatch rendering, and polygon side controls.

docs/dev/reports/playwright_workspace_v2_results.md

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,24 @@
1-
# PR_26133_019 Workspace V2 Results
1+
# PR_26133_020 Workspace V2 Results
22

33
## Command Results
44

55
- `node --check tools/object-vector-studio-v2/js/ToolStarterApp.js`: passed.
6+
- `node --check tools/object-vector-studio-v2/js/bootstrap.js`: passed.
67
- `node --check tests/playwright/tools/WorkspaceManagerV2.spec.mjs`: passed.
8+
- `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list --grep "shows Object Vector Studio V2 layout shell|maps Object Vector Studio V2 preview coordinates|edits Object Vector Studio V2 preview shapes|supports Object Vector Studio V2 asset library"`: 4 passed after one test-only adjustment.
79
- `npm run test:workspace-v2`: 48 passed.
810
- `git diff --check`: passed with LF-to-CRLF working-copy warnings for touched files.
911

1012
## Targeted Object Vector Studio V2 Verification
1113

12-
- Confirmed shape tile delete carries the source object id and removes the targeted shape only; no console/page errors were reported by the workspace-v2 scenarios.
13-
- Confirmed all Object Vector Studio V2 delete icon paths use `nf-md-trash_can_outline`.
14-
- Confirmed Object Vector Studio V2 icon glyphs render 75% larger through the scoped Nerd Font CSS scale without changing button actions, accessible labels, or tooltips.
15-
- Confirmed Paint, Stroke, Hue, Sat, Bri, and Name controls receive mapped Nerd Font icons.
16-
- Confirmed Palette UI no longer renders visible `Sort` text.
17-
- Confirmed the polygon tool uses `nf-md-vector_polygon`.
18-
- Confirmed Apply Geometry spacing is reduced and Arc Geometry renders `startAngle`/`endAngle` on the same row.
14+
- Confirmed requested Nerd Font glyph names are mapped for Triangle, Select, Zoom In, Zoom Out, Grid On/Off, Line, and Rectangle.
15+
- Confirmed Paint and Stroke buttons render a square color swatch before their icons and keep accessible labels/tooltips.
16+
- Confirmed Select icon renders 25% smaller and Rectangle icon renders 25% larger than the standard shape icon size.
17+
- Confirmed Object panel Delete is removed; object delete remains on object tiles only.
18+
- Confirmed object tile delete removes dependent `assetLibrary.assets[*].objectId`, `baseObjectId`, and dangling animation shape override references before schema validation.
19+
- Confirmed shape tile delete removes dependent `states[*].frames[*].shapeOverrides[*].shapeId` references before schema validation.
20+
- Confirmed Polygon Geometry Add Side/Subtract Side update the point list and reject invalid side counts visibly.
21+
- Confirmed workspace-v2 Object Vector Studio V2 scenarios reported no console/page errors.
1922
- Confirmed `src/shared/font/0xProtoNerdFont` was preserved.
2023

2124
## Scope Checks

0 commit comments

Comments
 (0)