Skip to content

Commit 1e2f91f

Browse files
author
DavidQ
committed
Fix Object Preview selection editing snap and independent Paint Stroke behavior - PR_26133_065-object-preview-editing-selection-and-style-fixes
1 parent 3b8af2f commit 1e2f91f

5 files changed

Lines changed: 196 additions & 111 deletions

File tree

docs/dev/reports/playwright_v8_coverage_report.md

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Playwright V8 Coverage Report
22

3-
PR: PR_26133_064-snap-cycle-selection-and-preview-edit-actions
3+
PR: PR_26133_065-object-preview-editing-selection-and-style-fixes
44

55
Source: docs/dev/reports/playwright_v8_coverage_report.txt generated by the latest npm run test:workspace-v2 run.
66

@@ -21,16 +21,13 @@ Source: docs/dev/reports/playwright_v8_coverage_report.txt generated by the late
2121

2222
## Changed Runtime JS Files Covered
2323

24-
- (83%) tools/object-vector-studio-v2/js/bootstrap.js - executed lines 105/105; executed functions 5/6
25-
- (94%) src/engine/rendering/ObjectVectorRuntimeAssetService.js - executed lines 1135/1135; executed functions 111/118
26-
- (95%) tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js - executed lines 454/454; executed functions 55/58
27-
- (95%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 6250/6250; executed functions 637/668
24+
- (95%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 6304/6304; executed functions 639/671
2825

2926
## Changed JS Files Considered
3027

31-
- (0%) tests/helpers/playwrightV8CoverageReporter.mjs - changed JS file not collected as browser runtime coverage
32-
- (0%) tests/playwright/tools/WorkspaceManagerV2.spec.mjs - changed JS file not collected as browser runtime coverage
33-
- (83%) tools/object-vector-studio-v2/js/bootstrap.js - changed JS file with browser V8 coverage
34-
- (94%) src/engine/rendering/ObjectVectorRuntimeAssetService.js - changed JS file with browser V8 coverage
35-
- (95%) tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js - changed JS file with browser V8 coverage
36-
- (95%) tools/object-vector-studio-v2/js/ToolStarterApp.js - changed JS file with browser V8 coverage
28+
- (0%) tests/playwright/tools/WorkspaceManagerV2.spec.mjs - Playwright test file, not collected as browser runtime coverage
29+
- (95%) tools/object-vector-studio-v2/js/ToolStarterApp.js - changed runtime JS file with browser V8 coverage
30+
31+
## Non-JS Changed Files
32+
33+
- tools/object-vector-studio-v2/styles/toolStarter.css - CSS layout/style change, not applicable to V8 coverage
Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,25 @@
11
# Playwright Workspace V2 Results
22

3-
PR: PR_26133_064-snap-cycle-selection-and-preview-edit-actions
3+
PR: PR_26133_065-object-preview-editing-selection-and-style-fixes
44

55
## Validation
66

77
- PASS: npm run test:workspace-v2
88
- Result: 54 passed
9-
- Runtime: 4.4m
9+
- Runtime: 4.3m
1010
- Browser project: playwright
1111
- Workers: 1
1212

1313
## Targeted Checks Covered
1414

15-
- Snap button cycles Snap Grid -> Snap Point -> Snap None -> Snap Grid, with mode labels/icons updated.
16-
- Shape selection sets Stroke as the active Paint/Stroke mode without applying color.
17-
- Object Geometry and Object Transform locations are swapped.
18-
- Object Preview edit toolbar renders under Object ID with an HR separator; Undo/Redo/Copy/Paste are visibly disabled because backing behavior is not wired.
19-
- Canvas geometry hit testing selects filled and stroke-only shapes, including transformed geometry.
20-
- Existing mouse edit, transform-bounds, dirty-state, and Object Vector Studio V2 authoring tests remain green.
15+
- Empty canvas click deselects the current shape and clicking another shape selects it/show Object Geometry.
16+
- Escape no longer cancels Object Vector Studio V2 drawing mode; switching tools cancels without committing invalid geometry.
17+
- Object Geometry has no Apply Geometry button; input change events auto-apply valid geometry and visibly reject invalid geometry.
18+
- Shape body drag, point/handle drag, polygon/polyline editing, and circle selector-corner resize update preview geometry and dirty state.
19+
- Snap Grid drawing and handle movement snap to whole-number logical grid coordinates.
20+
- New drawn shapes preserve the selected stroke color after deselect.
21+
- Paint and Stroke mode application paths remain independent and do not mutate the opposite opacity.
2122

2223
## Console/Runtime Errors
2324

24-
- PASS: Object Vector Studio V2 Playwright coverage keeps page error and console error collections empty in the exercised flows.
25+
- PASS: Object Vector Studio V2 Playwright coverage collected no page errors or console errors in the exercised flows.

0 commit comments

Comments
 (0)