Remove legacy vectorMaps from Object Vector Studio V2 workspace launch payloads - PR_26133_123-object-vector-workspace-schema-cleanup

Author: DavidQ

docs/dev/reports/PR_26133_123-object-vector-workspace-schema-cleanup_report.md

@@ -0,0 +1,39 @@
+# PR_26133_123 Object Vector Workspace Schema Cleanup Report
+
+## Scope
+- Fixed Workspace Manager V2 Object Vector Studio V2 payload synthesis so workspace contexts, tool session hydration, saved context persistence, imports, saves, and launches only carry `version`, `toolId`, `name`, and `objects`.
+- Preserved Object Vector Studio V2 `objects[].tags` and `objects[].shapes[]` as the active geometry SSoT.
+- Added an actionable Object Vector Studio V2 import/schema failure for legacy root `vectorMaps`.
+- Updated targeted Workspace Manager V2/Object Vector validation to assert canonical payload keys and no workspace-launched `vectorMaps`.
+
+## Files Changed
+- `tools/workspace-manager-v2/js/services/WorkspaceManagerV2ContextService.js`
+- `tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js`
+- `tests/tools/WorkspaceManagerV2ObjectVectorPayloadCleanup.test.mjs`
+- `tests/tools/ObjectVectorStudioV2DeleteCleanup.test.mjs`
+- `tests/playwright/tools/WorkspaceManagerV2.spec.mjs`
+
+## Validation
+- PASS: `node -e "import('./tests/tools/WorkspaceManagerV2ObjectVectorPayloadCleanup.test.mjs').then((m)=>m.run()).then(()=>console.log('PASS WorkspaceManagerV2ObjectVectorPayloadCleanup'))"`
+- PASS: `node -e "import('./tests/tools/ObjectVectorStudioV2DeleteCleanup.test.mjs').then((m)=>m.run()).then(()=>console.log('PASS ObjectVectorStudioV2DeleteCleanup'))"`
+- PASS: `node -e "import('./tests/games/AsteroidsValidation.test.mjs').then((m)=>m.run()).then(()=>console.log('PASS AsteroidsValidation'))"`
+- PASS: `node -e "import('./tests/games/AsteroidsAssetReferenceAdoption.test.mjs').then((m)=>m.run()).then(()=>console.log('PASS AsteroidsAssetReferenceAdoption'))"`
+- PASS: `node -e "import('./tests/games/AsteroidsPlatformDemo.test.mjs').then((m)=>m.run()).then(()=>console.log('PASS AsteroidsPlatformDemo'))"`
+- PASS: `node -e "const fs=require('fs'); ['tools/schemas/workspace.manifest.schema.json','tools/schemas/game.manifest.schema.json','tools/schemas/tools/object-vector-studio-v2.schema.json','games/Asteroids/game.manifest.json'].forEach((p)=>JSON.parse(fs.readFileSync(p,'utf8'))); console.log('PASS JSON parse schemas and Asteroids manifest');"`
+- PASS: `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list -g "shows Object Vector Studio V2 layout shell and schema-only palette gate|uses header lifecycle controls and launches tools from fixed Workspace Manager V2 tiles"`
+- PASS: `git diff --check`
+
+## Coverage
+- PASS: Playwright V8 coverage report generated at `docs/dev/reports/playwright_v8_coverage_report.txt`.
+- PASS: Changed runtime JS guardrail generated at `docs/dev/reports/coverage_changed_js_guardrail.txt`.
+- Coverage guardrail: `tools/workspace-manager-v2/js/services/WorkspaceManagerV2ContextService.js` 83%, `tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js` 93%, no changed runtime JS coverage warnings.
+
+## Full Samples Smoke Test
+- Skipped by request. This PR is limited to Object Vector Studio V2 schema/workspace launch cleanup and targeted Asteroids manifest validation.
+
+## Manual Validation
+1. Open Workspace Manager V2.
+2. Pick the repo folder and select Asteroids.
+3. Confirm the generated Workspace JSON has `tools.object-vector-studio-v2` with only `version`, `toolId`, `name`, and `objects`.
+4. Launch Object Vector Studio V2 and confirm the status log reports 7 loaded objects with no `vectorMaps` in JSON details.
+5. Import an Object Vector Studio V2 JSON containing root `vectorMaps` and confirm the failure explains to remove `root.vectorMaps` and use `root.objects[].tags` plus `root.objects[].shapes`.

tests/playwright/tools/WorkspaceManagerV2.spec.mjs

@@ -1942,6 +1942,20 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       await page.locator("#objectVectorStudioV2ImportJsonInput").setInputFiles(paletteDriftPayloadPath);
       await expect(page.locator("#statusLog")).toHaveValue(/FAIL Object Vector Studio V2 schema validation failed from import:object-vector-palette-drift\.json: root\.palette is not allowed\./);
 
+      const legacyVectorMapsPayloadPath = testInfo.outputPath("object-vector-legacy-vector-maps.json");
+      await writeFile(legacyVectorMapsPayloadPath, JSON.stringify({
+        name: "Legacy Vector Maps",
+        objects: [],
+        toolId: "object-vector-studio-v2",
+        vectorMaps: {
+          name: "Legacy Vector Maps",
+          shapes: []
+        },
+        version: 1
+      }, null, 2), "utf8");
+      await page.locator("#objectVectorStudioV2ImportJsonInput").setInputFiles(legacyVectorMapsPayloadPath);
+      await expect(page.locator("#statusLog")).toHaveValue(/FAIL Object Vector Studio V2 schema validation failed from import:object-vector-legacy-vector-maps\.json: root\.vectorMaps is deprecated legacy vector-map data\. Remove root\.vectorMaps and import Object Vector Studio V2 payloads with root\.objects\[\]\.tags and root\.objects\[\]\.shapes only\./);
+
       const unknownRootPayloadPath = testInfo.outputPath("object-vector-unknown-root.json");
       await writeFile(unknownRootPayloadPath, JSON.stringify({
         name: "Unknown Root",
@@ -9987,12 +10001,17 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       await expect(page.locator("#workspaceContextOutput")).toHaveValue(/"palette-manager-v2"/);
       await expect(page.locator("#workspaceContextOutput")).toHaveValue(/"object-vector-studio-v2"/);
       await expect(page.locator("#workspaceContextOutput")).not.toHaveValue(/"vector-map-editor"/);
-      await expect(page.locator("#workspaceContextOutput")).toHaveValue(/"vector\.asteroids\.ship"/);
+      await expect(page.locator("#workspaceContextOutput")).toHaveValue(/"object\.asteroids\.ship"/);
       const activeWorkspaceOutput = JSON.parse(await page.locator("#workspaceContextOutput").inputValue());
+      const activeObjectVectorPayload = activeWorkspaceOutput.tools["object-vector-studio-v2"];
+      expect(Object.keys(activeObjectVectorPayload).sort()).toEqual(["name", "objects", "toolId", "version"]);
+      expect(activeObjectVectorPayload.vectorMaps).toBeUndefined();
+      expect(activeObjectVectorPayload.objects.every((object) => Array.isArray(object.tags) && Array.isArray(object.shapes))).toBe(true);
       if (Object.hasOwn(activeWorkspaceOutput.tools, "text2speech-V2")) {
         expect(activeWorkspaceOutput.tools["text2speech-V2"]).toEqual(expect.any(Array));
       }
-      await expect(page.locator("#workspaceContextOutput")).toHaveValue(new RegExp('"vector' + "\\.asteroids"));
+      await expect(page.locator("#workspaceContextOutput")).not.toHaveValue(/"vectorMaps"/);
+      await expect(page.locator("#workspaceContextOutput")).not.toHaveValue(new RegExp('"vector' + "\\.asteroids"));
       await expect(page.locator("#workspaceContextOutput")).not.toHaveValue(/"palette-browser"/);
       await expect(page.locator("#workspaceContextOutput")).not.toHaveValue(/"asset-browser"/);
       await expect(page.locator("#workspaceContextOutput")).not.toHaveValue(/"activePalette"/);
@@ -10079,23 +10098,25 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       expect(JSON.stringify(selectedGameHydration.toolSessions)).not.toMatch(/getDirectoryHandle|createWritable|FileSystemDirectoryHandle/);
       expect(Object.keys(selectedGameHydration.dataByTool["asset-manager-v2"].assets)).toHaveLength(15);
       expect(selectedGameHydration.dataByTool["object-vector-studio-v2"].objects.map((object) => object.id)).toEqual(expect.arrayContaining([
+        "object.asteroids.bullet",
         "object.asteroids.ship",
         "object.asteroids.large-asteroid",
         "object.asteroids.medium-asteroid",
-        "object.asteroids.medium-asteroid-2",
         "object.asteroids.small-asteroid",
         "object.asteroids.large-ufo",
         "object.asteroids.small-ufo"
       ]));
       expect(selectedGameHydration.dataByTool["object-vector-studio-v2"].objects.map((object) => object.id)).toEqual(expect.arrayContaining([
+        "object.asteroids.bullet",
         "object.asteroids.ship",
         "object.asteroids.large-asteroid",
         "object.asteroids.medium-asteroid",
-        "object.asteroids.medium-asteroid-2",
         "object.asteroids.small-asteroid",
         "object.asteroids.large-ufo",
         "object.asteroids.small-ufo"
       ]));
+      expect(Object.keys(selectedGameHydration.dataByTool["object-vector-studio-v2"]).sort()).toEqual(["name", "objects", "toolId", "version"]);
+      expect(selectedGameHydration.dataByTool["object-vector-studio-v2"].vectorMaps).toBeUndefined();
       expect(selectedGameHydration.dataByTool["object-vector-studio-v2"].assetLibrary).toBeUndefined();
       expect(selectedGameHydration.dataByTool["object-vector-studio-v2"].objects.every((object) => object.id.startsWith("object.") && !Object.hasOwn(object, "objectId"))).toBe(true);
       expect(selectedGameHydration.dataByTool["object-vector-studio-v2"].objects.every((object) => /^object\.[a-z0-9-]+\.[a-z0-9][a-z0-9-]*$/.test(object.id))).toBe(true);
@@ -10243,6 +10264,7 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       expect(asteroidsManifest.tools["palette-manager-v2"].swatches.length).toBeGreaterThan(0);
       expect(asteroidsManifest.tools["object-vector-studio-v2"].palette).toBeUndefined();
       expect(asteroidsManifest.tools["object-vector-studio-v2"].objects.map((object) => object.id)).toEqual(expect.arrayContaining([
+        "object.asteroids.bullet",
         "object.asteroids.ship",
         "object.asteroids.large-asteroid",
         "object.asteroids.medium-asteroid",
@@ -10251,10 +10273,10 @@ test.describe("Workspace Manager V2 bootstrap", () => {
         "object.asteroids.small-ufo"
       ]));
       expect(asteroidsManifest.tools["object-vector-studio-v2"].objects.map((object) => object.id)).toEqual(expect.arrayContaining([
+        "object.asteroids.bullet",
         "object.asteroids.ship",
         "object.asteroids.large-asteroid",
         "object.asteroids.medium-asteroid",
-        "object.asteroids.medium-asteroid-2",
         "object.asteroids.small-asteroid",
         "object.asteroids.large-ufo",
         "object.asteroids.small-ufo"
@@ -10364,6 +10386,7 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       expect(storedContext.repoPath).toBe(manifestRepoPath(server));
       expect(storedContext.tools["palette-manager-v2"].swatches.length).toBeGreaterThan(0);
       expect(storedContext.tools["object-vector-studio-v2"].palette).toBeUndefined();
+      expect(Object.keys(storedContext.tools["object-vector-studio-v2"]).sort()).toEqual(["name", "objects", "toolId", "version"]);
       expect(storedContext.tools["object-vector-studio-v2"].objects.map((object) => object.name)).toEqual(expect.arrayContaining([
         "Asteroids Ship",
         "Large Asteroid",
@@ -10477,10 +10500,10 @@ test.describe("Workspace Manager V2 bootstrap", () => {
           objectVectorExtraKeys: [],
           objectVectorMissingKeys: [],
           objectVectorNames: expect.arrayContaining([
+            "Bullet",
             "Asteroids Ship",
             "Large Asteroid",
             "Medium Asteroid",
-            "Medium Asteroid 2",
             "Small Asteroid",
             "Large UFO",
             "Small UFO"
@@ -10519,19 +10542,20 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       await expect(page.locator("#objectVectorStudioV2PaletteSwatchCount")).toHaveText("(10 swatches)");
       await expect(page.locator("#objectVectorStudioV2PaletteSummary [data-palette-color]")).toHaveCount(10);
       await expect(page.locator("#statusLog")).toHaveValue(/INFO Runtime palette is read-only session\/workspace data; Object Vector JSON remains palette-free\./);
-      await expect(page.locator("#objectVectorStudioV2ObjectsCount")).toHaveText(/\(7 obj, states \d+, \d+ shapes\)/);
+      await expect(page.locator("#objectVectorStudioV2ObjectsCount")).toHaveText(/\(7 obj, states \d+, \d+ shapes?\)/);
       await expect(page.locator("#objectVectorStudioV2ObjectTiles")).toContainText("Asteroids Ship");
       await expect(page.locator("#objectVectorStudioV2ObjectTiles")).toContainText("Large Asteroid");
       await expect(page.locator("#objectVectorStudioV2ObjectTiles")).toContainText("Large UFO");
       const smallUfoTile = page.locator('.object-vector-studio-v2__object-tile[data-object-id="object.asteroids.small-ufo"]');
       await smallUfoTile.scrollIntoViewIfNeeded();
       await smallUfoTile.click();
       await expect(smallUfoTile).toContainText("object > asteroids > Small UFO");
-      await expect(page.locator(".object-vector-studio-v2__object-tile.is-selected .object-vector-studio-v2__object-tile-shapes [data-object-tile-shape-index] .object-vector-studio-v2__shape-select-label")).toHaveText(["1. Ellipse", "0. Ellipse"]);
+      await expect(page.locator(".object-vector-studio-v2__object-tile.is-selected .object-vector-studio-v2__object-tile-shapes [data-object-tile-shape-index] .object-vector-studio-v2__shape-select-label")).toHaveText(["0. Polyline"]);
       await page.locator('button[aria-controls="objectVectorStudioV2DependencyGraphContent"]').click();
       await expect(page.locator("#objectVectorStudioV2DependencyGraph")).toContainText("Object tags:");
       await expect(page.locator("#objectVectorStudioV2DependencyGraph")).toContainText("object.asteroids.ship: Asteroids Ship");
       await expect(page.locator("#objectVectorStudioV2JsonDetails")).not.toContainText('"palette"');
+      await expect(page.locator("#objectVectorStudioV2JsonDetails")).not.toContainText('"vectorMaps"');
       await expect(page.locator("#statusLog")).toHaveValue(/OK Runtime palette loaded from workspace\.tools\.palette-manager-v2\.data: 10 swatches\./);
       await expect(page.locator("#statusLog")).toHaveValue(/OK Loaded Object Vector Studio V2 schema payload from workspace\.tools\.object-vector-studio-v2: 7 objects\./);
       await page.locator("#returnToWorkspaceButton").click();
@@ -11102,7 +11126,7 @@ test.describe("Workspace Manager V2 bootstrap", () => {
 
       await page.locator('[data-workspace-tool-id="object-vector-studio-v2"]').click();
       await expect(page).toHaveURL(/object-vector-studio-v2\/index\.html.*launch=workspace/);
-      await expect(page.locator("#objectVectorStudioV2ObjectsCount")).toHaveText(/\(7 obj, states \d+, \d+ shapes\)/);
+      await expect(page.locator("#objectVectorStudioV2ObjectsCount")).toHaveText(/\(7 obj, states \d+, \d+ shapes?\)/);
       await expect(page.locator("#statusLog")).toHaveValue(/OK Loaded Object Vector Studio V2 schema payload from workspace\.tools\.object-vector-studio-v2: 7 objects\./);
 
       let objectVectorSession = await readObjectVectorWorkspaceSession(page);

tests/tools/ObjectVectorStudioV2DeleteCleanup.test.mjs

@@ -80,7 +80,11 @@ export async function run() {
   const legacyVectorValidation = service.validatePayload(legacyVectorPayload);
   assert.equal(legacyVectorValidation.ok, false);
   assert.equal(
-    legacyVectorValidation.errors.some((message) => message === "root.vectorMaps is not allowed."),
+    legacyVectorValidation.errors.some((message) => message.includes("root.vectorMaps is deprecated legacy vector-map data")),
+    true,
+  );
+  assert.equal(
+    legacyVectorValidation.errors.some((message) => message.includes("root.objects[].tags and root.objects[].shapes only")),
     true,
   );