Finish Object Vector Studio V2 manifest cleanup and remove stale vector-map role usage - PR_26133_122-object-vector-final-manifest-cleanup

Author: DavidQ

docs/dev/reports/PR_26133_122-object-vector-final-manifest-cleanup_report.md

@@ -0,0 +1,48 @@
+# PR_26133_122 Object Vector Final Manifest Cleanup Report
+
+## Summary
+- Removed the unused `object-vector-studio-v2.vectorMaps` manifest payload so Asteroids Object Vector Studio V2 data is owned by `objects[].tags` and `objects[].shapes[]`.
+- Renamed Asteroids runtime helpers from vector-map/role wording to object-geometry/tag wording.
+- Updated Asteroids launch/runtime wiring to pass `objectGeometry` and resolve gameplay/attract objects from manifest object IDs plus tags.
+- Updated Object Vector Studio V2 and game manifest schemas to reject the removed shared vector-map payload.
+- Confirmed Workspace Manager V2 still discovers Asteroids from the game manifest path.
+
+## Files Changed
+- `games/Asteroids/game.manifest.json`
+- `games/Asteroids/game/asteroidsObjectGeometryManifest.js`
+- `games/Asteroids/game/asteroidsObjectTags.js`
+- `games/Asteroids/game/AsteroidsGameScene.js`
+- `games/Asteroids/game/AsteroidsWorld.js`
+- `games/Asteroids/game/AsteroidsAttractAdapter.js`
+- `games/Asteroids/game/asteroidObjectGeometry.js`
+- `games/Asteroids/index.js`
+- `games/Asteroids/entities/Bullet.js`
+- `tools/schemas/game.manifest.schema.json`
+- `tools/schemas/tools/object-vector-studio-v2.schema.json`
+- `tools/schemas/tools/vector-map-editor.schema.json`
+- `tools/workspace-manager-v2/js/services/WorkspaceManagerV2ContextService.js`
+- Targeted Asteroids/Object Vector/Workspace Manager tests under `tests/`
+
+## Validation
+- PASS: `node --check` for changed JavaScript and test files.
+- PASS: JSON parse for changed manifests/schemas.
+- PASS: Object Vector Studio V2 Asteroids manifest-load validation.
+- PASS: `tests/tools/ObjectVectorStudioV2DeleteCleanup.test.mjs`
+- PASS: `tests/games/AsteroidsValidation.test.mjs`
+- PASS: `tests/games/AsteroidsVectorTransforms.test.mjs`
+- PASS: `tests/games/AsteroidsAssetReferenceAdoption.test.mjs`
+- PASS: `tests/games/AsteroidsPlatformDemo.test.mjs`
+- PASS: `tests/games/AsteroidsPresentation.test.mjs`
+- PASS: `tests/games/AsteroidsHardening.test.mjs`
+- PASS: `tests/games/AsteroidsCollisionTimingStress.test.mjs`
+- PASS: `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list -g "discovers Active Game options|loads Object Vector Studio V2 runtime assets"`
+- PASS: `git diff --check`
+
+## Skipped
+- `npm run test:workspace-v2` was not run; PR requested targeted Workspace Manager V2 validation only.
+- Full regression and full samples smoke test were not run; this change is limited to Asteroids/Object Vector manifest cleanup and Workspace Manager discovery verification.
+
+## Manual Validation
+1. Open `tools/workspace-manager-v2/index.html`, pick the repo folder, and confirm the Active Game dropdown includes `Asteroids`.
+2. Select `Asteroids` and confirm the generated workspace context includes `tools["object-vector-studio-v2"].objects` and does not include `tools["object-vector-studio-v2"].vectorMaps`.
+3. Open `games/Asteroids/index.html` and confirm the game launches with ship, asteroid, UFO, and bullet Object Vector geometry rendering.

games/Asteroids/entities/Bullet.js

@@ -25,7 +25,7 @@ export default class Bullet {
     this.life = life;
     this.collisionPoints = normalizePoints(collisionPoints);
     if (this.collisionPoints.length < 3) {
-      throw new Error('Asteroids Bullet requires manifest-loaded bullet vector map geometry.');
+      throw new Error('Asteroids Bullet requires manifest-loaded bullet object geometry.');
     }
   }
 

games/Asteroids/game.manifest.json

@@ -212,13 +212,6 @@
       "version": 1,
       "toolId": "object-vector-studio-v2",
       "name": "Asteroids Object Vector Assets",
-      "vectorMaps": {
-        "schema": "html-js-gaming.asteroids-object-vector-shapes",
-        "version": 1,
-        "name": "Asteroids Object Vector Shape Roles",
-        "source": "object-vector-studio-v2",
-        "shapes": []
-      },
       "objects": [
         {
           "id": "object.asteroids.bullet",

games/Asteroids/game/AsteroidsAttractAdapter.js

@@ -5,7 +5,7 @@ David Quesenberry
 AsteroidsAttractAdapter.js
 */
 import { clamp } from '../../../src/shared/utils/mathUtils.js';
-import { ASTEROIDS_OBJECT_VECTOR_IDS } from './asteroidsVectorMaps.js';
+import { ASTEROIDS_OBJECT_GEOMETRY_IDS } from './asteroidsObjectGeometryManifest.js';
 
 function estimateTextWidth(text, fontPx) {
   return String(text ?? '').length * (fontPx * 0.62);
@@ -121,21 +121,21 @@ export default class AsteroidsAttractAdapter {
     }
 
     this.scene?.drawObjectVectorAsset?.(renderer, 'attractShip', {
-      ...this.scene.objectVectorRoleOptions('ship'),
+      ...this.scene.objectVectorTagOptions('ship'),
       elapsedMs: this.scene.objectVectorPlaybackMs,
       fps: 12,
-      objectId: ASTEROIDS_OBJECT_VECTOR_IDS.attractShip,
+      objectId: ASTEROIDS_OBJECT_GEOMETRY_IDS.attractShip,
       rotation: -0.28,
       scale: 1.1,
       stateId: 'idle',
       x: 328,
       y: 348,
     });
     this.scene?.drawObjectVectorAsset?.(renderer, 'attractAsteroid', {
-      ...this.scene.objectVectorRoleOptions('asteroidLarge'),
+      ...this.scene.objectVectorTagOptions('asteroidLarge'),
       elapsedMs: this.scene.objectVectorPlaybackMs,
       fps: 12,
-      objectId: ASTEROIDS_OBJECT_VECTOR_IDS.attractAsteroid,
+      objectId: ASTEROIDS_OBJECT_GEOMETRY_IDS.attractAsteroid,
       scale: 0.72,
       stateId: 'active',
       x: 632,
@@ -210,10 +210,10 @@ export default class AsteroidsAttractAdapter {
     const x = 480 + Math.cos(this.demoTime * 0.7) * 220;
     const y = 340 + Math.sin(this.demoTime * 1.1) * 130;
     this.scene?.drawObjectVectorAsset?.(renderer, 'attractShip', {
-      ...this.scene.objectVectorRoleOptions('ship'),
+      ...this.scene.objectVectorTagOptions('ship'),
       elapsedMs: this.scene.objectVectorPlaybackMs,
       fps: 12,
-      objectId: ASTEROIDS_OBJECT_VECTOR_IDS.attractShip,
+      objectId: ASTEROIDS_OBJECT_GEOMETRY_IDS.attractShip,
       rotation: Math.sin(this.demoTime * 0.9) * 1.2,
       stateId: 'idle',
       x,
@@ -223,20 +223,20 @@ export default class AsteroidsAttractAdapter {
     const rockX = 480 + Math.sin(this.demoTime * 0.5) * 250;
     const rockY = 330 + Math.cos(this.demoTime * 0.9) * 120;
     this.scene?.drawObjectVectorAsset?.(renderer, 'attractAsteroid', {
-      ...this.scene.objectVectorRoleOptions('asteroidLarge'),
+      ...this.scene.objectVectorTagOptions('asteroidLarge'),
       elapsedMs: this.scene.objectVectorPlaybackMs,
       fps: 12,
-      objectId: ASTEROIDS_OBJECT_VECTOR_IDS.attractAsteroid,
+      objectId: ASTEROIDS_OBJECT_GEOMETRY_IDS.attractAsteroid,
       scale: 0.72,
       stateId: 'active',
       x: rockX,
       y: rockY,
     });
     this.scene?.drawObjectVectorAsset?.(renderer, 'attractUfo', {
-      ...this.scene.objectVectorRoleOptions('ufoLarge'),
+      ...this.scene.objectVectorTagOptions('ufoLarge'),
       elapsedMs: this.scene.objectVectorPlaybackMs,
       fps: 12,
-      objectId: ASTEROIDS_OBJECT_VECTOR_IDS.attractUfo,
+      objectId: ASTEROIDS_OBJECT_GEOMETRY_IDS.attractUfo,
       stateId: 'active',
       x: 480 + Math.cos(this.demoTime * 0.43) * 280,
       y: 284,

games/Asteroids/game/AsteroidsGameScene.js

@@ -15,10 +15,10 @@ import AsteroidsHighScoreService from '../systems/AsteroidsHighScoreService.js';
 import AsteroidsInitialsEntry from '../systems/AsteroidsInitialsEntry.js';
 import { createAsteroidGeometryProfilesFromObjectVectorAssets } from './asteroidObjectGeometry.js';
 import {
-  ASTEROID_SIZE_RUNTIME_ROLES,
-  runtimeObjectRoleOptions,
-  validateAsteroidsRuntimeObjectRoles
-} from './asteroidsObjectVectorRoles.js';
+  ASTEROID_SIZE_RUNTIME_OBJECT_KEYS,
+  runtimeObjectTagOptions,
+  validateAsteroidsRuntimeObjectTags
+} from './asteroidsObjectTags.js';
 import {
   ASTEROIDS_GAME_OVER_AUTO_EXIT_SECONDS, ASTEROIDS_GAME_OVER_RETURN_MODE
 } from "../rules/flowRules.js";
@@ -88,17 +88,17 @@ export default class AsteroidsGameScene extends Scene {
     this.devConsoleIntegration = options.devConsoleIntegration || null;
     this.objectVectorAssets = options.objectVectorAssets || null;
     this.objectVectorRuntime = options.objectVectorRuntime || null;
-    this.vectorMaps = options.vectorMaps || null;
-    if (!this.vectorMaps?.objectVectorMapsById || !this.vectorMaps?.objectsByRole) {
+    this.objectGeometry = options.objectGeometry || null;
+    if (!this.objectGeometry?.objectsById || !this.objectGeometry?.objectsByKey) {
       const message = 'Asteroids Object Vector manifest validation failed: object geometry was not loaded from game.manifest.json.';
       console.error(message);
       throw new Error(message);
     }
     this.objectVectorRuntimeObjectValidation = this.objectVectorAssets
-      ? validateAsteroidsRuntimeObjectRoles([...this.objectVectorAssets.objectsById.values()], {
+      ? validateAsteroidsRuntimeObjectTags([...this.objectVectorAssets.objectsById.values()], {
         logger: this.objectVectorRuntime,
       })
-      : { errors: [], objectsByRole: {}, ok: false, warnings: [] };
+      : { errors: [], objectsByKey: {}, ok: false, warnings: [] };
     if (this.objectVectorAssets && !this.objectVectorRuntimeObjectValidation.ok) {
       const message = validationFailureMessage(this.objectVectorRuntimeObjectValidation);
       this.objectVectorRuntime?.log?.('FAIL', message, {
@@ -125,7 +125,7 @@ export default class AsteroidsGameScene extends Scene {
     };
     this.world = new AsteroidsWorld({ width: 960, height: 720 }, {
       asteroidGeometryProfiles: this.asteroidGeometryProfiles,
-      vectorMaps: this.vectorMaps,
+      objectGeometry: this.objectGeometry,
     });
     this.highScoreService = new AsteroidsHighScoreService();
     this.highScoreRows = this.highScoreService.loadTable();
@@ -734,9 +734,9 @@ export default class AsteroidsGameScene extends Scene {
     }
 
     this.world.asteroids.forEach((asteroid) => {
-      const roleId = ASTEROID_SIZE_RUNTIME_ROLES[asteroid.size];
+      const objectKey = ASTEROID_SIZE_RUNTIME_OBJECT_KEYS[asteroid.size];
       this.drawObjectVectorAsset(renderer, "asteroids", {
-        ...this.objectVectorRoleOptions(roleId),
+        ...this.objectVectorTagOptions(objectKey),
         elapsedMs: this.objectVectorPlaybackMs,
         fps: 12,
         rotation: asteroid.angle,
@@ -747,9 +747,9 @@ export default class AsteroidsGameScene extends Scene {
     });
 
     if (this.world.ufo) {
-      const roleId = this.world.ufo.type === "small" ? "ufoSmall" : "ufoLarge";
+      const objectKey = this.world.ufo.type === "small" ? "ufoSmall" : "ufoLarge";
       this.drawObjectVectorAsset(renderer, "ufo", {
-        ...this.objectVectorRoleOptions(roleId),
+        ...this.objectVectorTagOptions(objectKey),
         elapsedMs: this.objectVectorPlaybackMs,
         fps: 12,
         stateId: "active",
@@ -760,7 +760,7 @@ export default class AsteroidsGameScene extends Scene {
 
     this.world.bullets.forEach((bullet) => {
       this.drawObjectVectorAsset(renderer, "bullet", {
-        ...this.objectVectorRoleOptions("bullet"),
+        ...this.objectVectorTagOptions("bullet"),
         stateId: "active",
         x: bullet.x,
         y: bullet.y,
@@ -769,7 +769,7 @@ export default class AsteroidsGameScene extends Scene {
 
     this.world.ufoBullets.forEach((bullet) => {
       this.drawObjectVectorAsset(renderer, "bullet", {
-        ...this.objectVectorRoleOptions("bullet"),
+        ...this.objectVectorTagOptions("bullet"),
         stateId: "active",
         x: bullet.x,
         y: bullet.y,
@@ -780,7 +780,7 @@ export default class AsteroidsGameScene extends Scene {
 
     if (this.world.shipActive && !this.session.isTurnIntroActive() && this.session.mode !== 'menu') {
       this.drawObjectVectorAsset(renderer, "ship", {
-        ...this.objectVectorRoleOptions("ship"),
+        ...this.objectVectorTagOptions("ship"),
         elapsedMs: this.objectVectorPlaybackMs,
         fps: 12,
         rotation: this.world.ship.angle,
@@ -857,8 +857,8 @@ export default class AsteroidsGameScene extends Scene {
     this.publishObjectVectorRuntimeDiagnostics();
   }
 
-  objectVectorRoleOptions(roleId) {
-    return runtimeObjectRoleOptions(roleId);
+  objectVectorTagOptions(objectKey) {
+    return runtimeObjectTagOptions(objectKey);
   }
 
   drawLives(renderer, centerX, y, lives) {
@@ -869,7 +869,7 @@ export default class AsteroidsGameScene extends Scene {
     const startX = centerX - ((lives - 1) * LIFE_SPACING) / 2;
     Array.from({ length: lives }).forEach((_, index) => {
       this.drawObjectVectorAsset(renderer, "shipLife", {
-        ...this.objectVectorRoleOptions("ship"),
+        ...this.objectVectorTagOptions("ship"),
         elapsedMs: this.objectVectorPlaybackMs,
         fps: 12,
         rotation: -Math.PI / 2,
@@ -916,10 +916,9 @@ export default class AsteroidsGameScene extends Scene {
         assetCount: this.objectVectorAssets?.objectsById?.size || 0,
         loaded: Boolean(this.objectVectorAssets),
         objectCount: this.objectVectorAssets?.objectsById?.size || 0,
-        objectVectorObjectIds: this.vectorMaps?.objectVectorMaps?.map((object) => object.id) || [],
+        objectVectorObjectIds: this.objectGeometry?.objects?.map((object) => object.id) || [],
         runtimeObjectsValid: Boolean(this.objectVectorRuntimeObjectValidation?.ok),
         renderCounts: { ...this.objectVectorRenderCounts },
-        sharedShapeCount: this.vectorMaps?.shapes?.length || 0,
       };
     } catch {
       // Ignore diagnostics assignment in restricted runtimes.

games/Asteroids/game/AsteroidsWorld.js

@@ -13,8 +13,8 @@ import { distance } from '../../../src/shared/utils/mathUtils.js';
 import { randomRange } from '../utils/math.js';
 import { sanitizeFiniteNumber, sanitizePositiveNumber } from '../../../src/shared/math/numberNormalization.js';
 import {
-  requireAsteroidsObjectVectorPoints,
-} from './asteroidsVectorMaps.js';
+  requireAsteroidsObjectGeometryPoints,
+} from './asteroidsObjectGeometryManifest.js';
 
 const WAVE_ASTEROID_COUNTS = [4, 6, 8];
 const RESPAWN_SAFE_DISTANCE = 100;
@@ -139,21 +139,21 @@ function getRectOverlapDepth(x, y, radius, rect) {
 }
 
 export default class AsteroidsWorld {
-  constructor(bounds, { rng = Math.random, asteroidGeometryProfiles = null, vectorMaps = null } = {}) {
+  constructor(bounds, { rng = Math.random, asteroidGeometryProfiles = null, objectGeometry = null } = {}) {
     if (!hasLoggedWorldConstruction) {
       hasLoggedWorldConstruction = true;
       logWorldBootStage('constructed', bounds);
     }
     this.asteroidGeometryProfiles = asteroidGeometryProfiles;
-    this.vectorMaps = vectorMaps;
-    if (!this.vectorMaps?.objectVectorMapsById) {
+    this.objectGeometry = objectGeometry;
+    if (!this.objectGeometry?.objectsById) {
       throw new Error('AsteroidsWorld requires manifest-loaded Object Vector geometry for ship, UFO, asteroid, and bullet gameplay geometry.');
     }
-    this.bulletCollisionPoints = requireAsteroidsObjectVectorPoints(this.vectorMaps, 'bullet', 'bullet object geometry');
-    this.shipCollisionPoints = requireAsteroidsObjectVectorPoints(this.vectorMaps, 'ship', 'ship object geometry');
+    this.bulletCollisionPoints = requireAsteroidsObjectGeometryPoints(this.objectGeometry, 'bullet', 'bullet object geometry');
+    this.shipCollisionPoints = requireAsteroidsObjectGeometryPoints(this.objectGeometry, 'ship', 'ship object geometry');
     this.ufoCollisionPoints = {
-      large: requireAsteroidsObjectVectorPoints(this.vectorMaps, 'ufoLarge', 'large UFO object geometry'),
-      small: requireAsteroidsObjectVectorPoints(this.vectorMaps, 'ufoSmall', 'small UFO object geometry'),
+      large: requireAsteroidsObjectGeometryPoints(this.objectGeometry, 'ufoLarge', 'large UFO object geometry'),
+      small: requireAsteroidsObjectGeometryPoints(this.objectGeometry, 'ufoSmall', 'small UFO object geometry'),
     };
     this.rng = typeof rng === 'function' ? rng : Math.random;
     this.bounds = sanitizeBounds(bounds);

games/Asteroids/game/asteroidObjectGeometry.js

@@ -1,7 +1,7 @@
 import {
-  ASTEROID_SIZE_RUNTIME_ROLES,
-  resolveAsteroidsObjectVectorRole,
-} from './asteroidsObjectVectorRoles.js';
+  ASTEROID_SIZE_RUNTIME_OBJECT_KEYS,
+  resolveAsteroidsTaggedObject,
+} from './asteroidsObjectTags.js';
 
 const ASTEROID_SIZE_LABELS = Object.freeze({
   1: 'SML',
@@ -64,8 +64,8 @@ function extractPrimaryPolygonPoints(object) {
 function createProfilesFromObjects(objects, options = {}) {
   const profiles = {};
 
-  Object.entries(ASTEROID_SIZE_RUNTIME_ROLES).forEach(([size, roleId]) => {
-    const object = resolveAsteroidsObjectVectorRole(objects, roleId, options);
+  Object.entries(ASTEROID_SIZE_RUNTIME_OBJECT_KEYS).forEach(([size, objectKey]) => {
+    const object = resolveAsteroidsTaggedObject(objects, objectKey, options);
     const points = centerPoints(extractPrimaryPolygonPoints(object));
     if (points.length < 3) {
       return;