Skip to content

Commit 1418513

Browse files
author
DavidQ
committed
Remove tools/shared dependencies and apply common style consolidation for Preview Generator V2 - PR_26126_037-preview-generator-v2-remove-shared-and-consolidate-common
1 parent 439f748 commit 1418513

12 files changed

Lines changed: 754 additions & 452 deletions

‎.gitignore‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,8 @@ NEXT_COMMAND.txt
1616
# Ignore the tests results and temporary files
1717
node_modules/
1818
tests/results/
19-
tmp/
19+
tmp/
20+
21+
22+
codex_review.diff
23+
codex_changed_files.txt

‎docs/dev/codex_commands.md‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
1-
# Codex Commands - PR_26126_036-preview-generator-v2-shared-dependency-and-style-audit
1+
# Codex Commands - PR_26126_037-preview-generator-v2-remove-shared-and-consolidate-common
22

33
```bash
4-
codex run "Create PR_26126_036-preview-generator-v2-shared-dependency-and-style-audit. Audit Preview Generator V2 structure and validation only. Verify tools/shared dependencies, report common CSS declaration candidates by comparing declaration bodies, verify Playwright launches Preview Generator V2, repair minimal Playwright coverage only if needed, do not modify samples, do not add schema, do not modify start_of_day folders, and produce required review artifacts."
4+
codex run "Create PR_26126_037-preview-generator-v2-remove-shared-and-consolidate-common. Fix Preview Generator V2 based on audit findings. Preserve existing behavior exactly. Remove all tools/shared dependencies from Preview Generator V2, consolidate safe repeated CSS declarations into common styles, update Preview Generator V2 to consume those common styles, verify Playwright, do not modify samples, do not add schema, do not modify start_of_day folders, and produce required reports."
55
```
66

77
## Validation Commands
88

99
```powershell
10-
rg -n "tools/shared|../shared|../../tools/shared|platformShell|shared/" tools/preview-generator-v2 tests/playwright/PreviewGeneratorV2Baseline.spec.mjs
10+
rg -n "tools/shared|../shared|../../tools/shared|platformShell|shared/" tools/preview-generator-v2 tools/common tests/playwright/PreviewGeneratorV2Baseline.spec.mjs
1111
if ($LASTEXITCODE -eq 1) { Write-Output "no tools/shared references found"; $global:LASTEXITCODE = 0 }
12-
rg -n "<link|<script|import .* from" tools/preview-generator-v2 tests/playwright/PreviewGeneratorV2Baseline.spec.mjs
12+
rg -n "<link|<script|import .* from" tools/preview-generator-v2 tools/common tests/playwright/PreviewGeneratorV2Baseline.spec.mjs
1313
1414
$files = Get-ChildItem -Path tools/preview-generator-v2 -Recurse -Filter *.js | Select-Object -ExpandProperty FullName
1515
foreach ($file in $files) {
@@ -18,25 +18,25 @@ foreach ($file in $files) {
1818
}
1919
node --check tests/playwright/PreviewGeneratorV2Baseline.spec.mjs
2020
npx playwright test tests/playwright/PreviewGeneratorV2Baseline.spec.mjs --project=playwright --reporter=list
21-
git status --short -- samples tools/schemas start_of_day
22-
git diff --check -- tools/preview-generator-v2 tests/playwright docs/dev/codex_commands.md docs/dev/commit_comment.txt docs/dev/reports/preview_generator_v2_shared_dependency_audit.txt docs/dev/reports/preview_generator_v2_common_style_candidates.txt docs/dev/reports/preview_generator_v2_playwright_result.txt
21+
git status --short -- samples tools/schemas start_of_day tests/results
22+
git diff --check -- tools/preview-generator-v2 tools/common tests/playwright docs/dev/codex_commands.md docs/dev/commit_comment.txt docs/dev/reports/preview_generator_v2_shared_removed.txt docs/dev/reports/preview_generator_v2_common_styles_applied.txt docs/dev/reports/preview_generator_v2_playwright_result.txt
2323
npm run test:workspace-v2
2424
```
2525

2626
## Playwright
2727

28-
Playwright validates that Preview Generator V2 launches, the main shell/menu/status controls render, Generate Preview and Stop start disabled, Games is the default target source, and a working accordion collapses/reopens without page errors.
28+
Playwright validates that Preview Generator V2 launches, the main shell/menu/status controls render, Generate Preview and Stop start disabled, Games is the default target source, a working accordion collapses/reopens, the common stylesheet loads, and the consolidated common style declarations are active.
2929

30-
Expected pass behavior: the targeted Playwright test passes with one launched tool page.
30+
Expected pass behavior: the targeted Playwright test passes with one launched tool page and no page errors.
3131

32-
Expected fail behavior: the test fails if the tool cannot load, controls are missing, the default target source changes unexpectedly, accordion behavior is broken, or page errors are emitted.
32+
Expected fail behavior: the test fails if the tool cannot load, controls are missing, common styles are not applied, accordion behavior is broken, or page errors are emitted.
3333

3434
## Test Notes
3535

3636
`npm run test:workspace-v2` is not defined in the current `package.json`.
3737

3838
## Manual Test
3939

40-
Open `tools/preview-generator-v2/index.html`, confirm the tool shell loads, toggle Repo Destination, confirm Generate Preview is visible but disabled before required fields are complete, and verify Status/Clear remain visible.
40+
Open `tools/preview-generator-v2/index.html`, confirm the tool shell looks unchanged, toggle Repo Destination, use Hide Header and Details/Show Header and Details, and confirm Generate Preview remains visible but disabled before required fields are complete.
4141

4242
Full samples smoke test was skipped because this PR does not modify samples or shared sample loading.

‎docs/dev/commit_comment.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Audit Preview Generator V2 dependencies and add launch baseline - PR_26126_036-preview-generator-v2-shared-dependency-and-style-audit
1+
Consolidate Preview Generator V2 shell styles without tools/shared - PR_26126_037-preview-generator-v2-remove-shared-and-consolidate-common

‎docs/dev/reports/codex_changed_files.txt‎

Lines changed: 28 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,32 @@
11
# git status --short
2+
M .gitignore
23
M docs/dev/codex_commands.md
34
M docs/dev/commit_comment.txt
4-
M docs/dev/reports/codex_changed_files.txt
5-
M docs/dev/reports/codex_review.diff
6-
?? docs/dev/reports/preview_generator_v2_common_style_candidates.txt
7-
?? docs/dev/reports/preview_generator_v2_playwright_result.txt
8-
?? docs/dev/reports/preview_generator_v2_shared_dependency_audit.txt
9-
?? tests/playwright/
5+
M docs/dev/reports/preview_generator_v2_playwright_result.txt
6+
M tests/playwright/PreviewGeneratorV2Baseline.spec.mjs
7+
M tools/preview-generator-v2/index.html
8+
M tools/preview-generator-v2/previewGeneratorV2.css
9+
?? docs/dev/reports/preview_generator_v2_common_styles_applied.txt
10+
?? docs/dev/reports/preview_generator_v2_shared_removed.txt
11+
?? tools/common/toolShellCommon.css
1012

11-
# git diff --stat -- . excluding generated review artifact files
12-
docs/dev/codex_commands.md | 74 +++++++++++----------------------------------
13-
docs/dev/commit_comment.txt | 2 +-
14-
2 files changed, 18 insertions(+), 58 deletions(-)
15-
# New file diff stat: docs/dev/reports/preview_generator_v2_common_style_candidates.txt
16-
...review_generator_v2_common_style_candidates.txt | 96 ++++++++++++++++++++++
17-
1 file changed, 96 insertions(+)
18-
# New file diff stat: docs/dev/reports/preview_generator_v2_playwright_result.txt
19-
.../preview_generator_v2_playwright_result.txt | 38 ++++++++++++++++++++++
20-
1 file changed, 38 insertions(+)
21-
# New file diff stat: docs/dev/reports/preview_generator_v2_shared_dependency_audit.txt
22-
...review_generator_v2_shared_dependency_audit.txt | 40 ++++++++++++++++++++++
23-
1 file changed, 40 insertions(+)
24-
# New file diff stat: tests/playwright/PreviewGeneratorV2Baseline.spec.mjs
25-
.../playwright/PreviewGeneratorV2Baseline.spec.mjs | 47 ++++++++++++++++++++++
26-
1 file changed, 47 insertions(+)
13+
# Note
14+
.gitignore is present in the worktree status but is unrelated to PR_26126_037 and is excluded from the PR-scoped review diff/stat.
15+
16+
# PR-scoped diff stat excluding unrelated .gitignore and generated review artifact files
17+
docs/dev/codex_commands.md | 20 +++---
18+
docs/dev/commit_comment.txt | 2 +-
19+
.../preview_generator_v2_playwright_result.txt | 13 ++--
20+
.../playwright/PreviewGeneratorV2Baseline.spec.mjs | 35 ++++++++++
21+
tools/preview-generator-v2/index.html | 29 +++++----
22+
tools/preview-generator-v2/previewGeneratorV2.css | 75 ----------------------
23+
6 files changed, 66 insertions(+), 108 deletions(-)
24+
# New file diff stat: docs/dev/reports/preview_generator_v2_common_styles_applied.txt
25+
.../preview_generator_v2_common_styles_applied.txt | 53 ++++++++++++++++++++++
26+
1 file changed, 53 insertions(+)
27+
# New file diff stat: docs/dev/reports/preview_generator_v2_shared_removed.txt
28+
.../preview_generator_v2_shared_removed.txt | 39 ++++++++++++++++++++++
29+
1 file changed, 39 insertions(+)
30+
# New file diff stat: tools/common/toolShellCommon.css
31+
NUL => tools/common/toolShellCommon.css | 66 +++++++++++++++++++++++++++++++++
32+
1 file changed, 66 insertions(+)

0 commit comments

Comments
 (0)