Audit Preview Generator V2 shared dependencies, common style candidates, and Playwright coverage - PR_26126_036-preview-generator-v2-shared-dependency-and-style-audit

Author: DavidQ

docs/dev/codex_commands.md

@@ -1,82 +1,42 @@
-# Codex Commands - PR_26126_035-preview-generator-v2-file-split-and-control-classes
+# Codex Commands - PR_26126_036-preview-generator-v2-shared-dependency-and-style-audit
 
 ```bash
-codex run "Create PR_26126_035-preview-generator-v2-file-split-and-control-classes. Fix Preview Generator V2 structure only. Preserve current working behavior exactly. Remove all inline style blocks and inline script blocks from tools/preview-generator-v2/index.html. Move CSS into external stylesheet files. Move JavaScript into external module files. Use one class per JavaScript file. Give each UI control/section its own class. Keep a small app/bootstrap entry file only for wiring classes together. Preserve existing IDs and DOM behavior unless a rename is required for correctness. Do not rewrite generation logic. Do not add schema. Do not modify samples. Do not modify start_of_day folders. Produce review artifacts and class ownership notes."
+codex run "Create PR_26126_036-preview-generator-v2-shared-dependency-and-style-audit. Audit Preview Generator V2 structure and validation only. Verify tools/shared dependencies, report common CSS declaration candidates by comparing declaration bodies, verify Playwright launches Preview Generator V2, repair minimal Playwright coverage only if needed, do not modify samples, do not add schema, do not modify start_of_day folders, and produce required review artifacts."
 ```
 
 ## Validation Commands
 
 ```powershell
+rg -n "tools/shared|../shared|../../tools/shared|platformShell|shared/" tools/preview-generator-v2 tests/playwright/PreviewGeneratorV2Baseline.spec.mjs
+if ($LASTEXITCODE -eq 1) { Write-Output "no tools/shared references found"; $global:LASTEXITCODE = 0 }
+rg -n "<link|<script|import .* from" tools/preview-generator-v2 tests/playwright/PreviewGeneratorV2Baseline.spec.mjs
+
 $files = Get-ChildItem -Path tools/preview-generator-v2 -Recurse -Filter *.js | Select-Object -ExpandProperty FullName
 foreach ($file in $files) {
   node --check $file
   if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE }
 }
-@'
-const fs = require('fs');
-const html = fs.readFileSync('tools/preview-generator-v2/index.html', 'utf8');
-if (/<style\b/i.test(html) || /<\/style>/i.test(html)) throw new Error('Inline style block remains');
-const inlineScripts = [...html.matchAll(/<script(?![^>]*\bsrc=)[^>]*>/gi)];
-if (inlineScripts.length) throw new Error(`Inline script block remains: ${inlineScripts.length}`);
-if (!html.includes('./previewGeneratorV2.css')) throw new Error('External CSS link missing');
-if (!html.includes('./previewGeneratorV2.bootstrap.js')) throw new Error('Bootstrap module missing');
-console.log('index has no inline style/script blocks');
-'@ | node -
-@'
-const fs = require('fs');
-const path = require('path');
-const root = 'tools/preview-generator-v2';
-const files = [];
-function walk(dir) {
-  for (const entry of fs.readdirSync(dir, { withFileTypes: true })) {
-    const full = path.join(dir, entry.name);
-    if (entry.isDirectory()) walk(full);
-    if (entry.isFile() && entry.name.endsWith('.js')) files.push(full);
-  }
-}
-walk(root);
-for (const file of files) {
-  const text = fs.readFileSync(file, 'utf8');
-  const classes = [...text.matchAll(/\bclass\s+[A-Za-z0-9_]+/g)].map(match => match[0]);
-  if (classes.length > 1) throw new Error(`${file} has more than one class: ${classes.join(', ')}`);
-}
-console.log('one class per js file check ok');
-'@ | node -
-@'
-const fs = require('fs');
-const path = require('path');
-const root = 'tools/preview-generator-v2';
-const files = [];
-function walk(dir) {
-  for (const entry of fs.readdirSync(dir, { withFileTypes: true })) {
-    const full = path.join(dir, entry.name);
-    if (entry.isDirectory()) walk(full);
-    if (entry.isFile() && entry.name.endsWith('.js')) files.push(full);
-  }
-}
-walk(root);
-for (const file of files) {
-  const text = fs.readFileSync(file, 'utf8');
-  for (const match of text.matchAll(/from\s+["'](.+?)["']/g)) {
-    const target = path.resolve(path.dirname(file), match[1]);
-    if (!fs.existsSync(target)) throw new Error(`${file} imports missing ${match[1]}`);
-  }
-}
-console.log('local module imports resolve');
-'@ | node -
+node --check tests/playwright/PreviewGeneratorV2Baseline.spec.mjs
+npx playwright test tests/playwright/PreviewGeneratorV2Baseline.spec.mjs --project=playwright --reporter=list
 git status --short -- samples tools/schemas start_of_day
-git diff --check -- tools/preview-generator-v2 docs/dev/codex_commands.md docs/dev/commit_comment.txt docs/dev/reports/preview_generator_v2_class_responsibilities.md docs/dev/reports/codex_review.diff docs/dev/reports/codex_changed_files.txt
+git diff --check -- tools/preview-generator-v2 tests/playwright docs/dev/codex_commands.md docs/dev/commit_comment.txt docs/dev/reports/preview_generator_v2_shared_dependency_audit.txt docs/dev/reports/preview_generator_v2_common_style_candidates.txt docs/dev/reports/preview_generator_v2_playwright_result.txt
 npm run test:workspace-v2
 ```
 
 ## Playwright
 
-No new Playwright test was added. This PR is a file split and class ownership cleanup for Preview Generator V2 only; existing behavior is intended to remain unchanged. `npm run test:workspace-v2` is attempted as the standard command if available.
+Playwright validates that Preview Generator V2 launches, the main shell/menu/status controls render, Generate Preview and Stop start disabled, Games is the default target source, and a working accordion collapses/reopens without page errors.
+
+Expected pass behavior: the targeted Playwright test passes with one launched tool page.
+
+Expected fail behavior: the test fails if the tool cannot load, controls are missing, the default target source changes unexpectedly, accordion behavior is broken, or page errors are emitted.
 
 ## Test Notes
 
 `npm run test:workspace-v2` is not defined in the current `package.json`.
 
 ## Manual Test
 
-Open Preview Generator V2 and confirm the page loads with the same layout and controls. Pick a repo, verify Generate Preview gating, run a small known path, use Stop/Clear, and confirm Last Generated Image and Output Summary update as before.
+Open `tools/preview-generator-v2/index.html`, confirm the tool shell loads, toggle Repo Destination, confirm Generate Preview is visible but disabled before required fields are complete, and verify Status/Clear remain visible.
+
+Full samples smoke test was skipped because this PR does not modify samples or shared sample loading.

docs/dev/commit_comment.txt

@@ -1 +1 @@
-Split Preview Generator V2 files and add per-section control classes - PR_26126_035-preview-generator-v2-file-split-and-control-classes
+Audit Preview Generator V2 dependencies and add launch baseline - PR_26126_036-preview-generator-v2-shared-dependency-and-style-audit

docs/dev/reports/codex_changed_files.txt

@@ -1,111 +1,26 @@
-# Full git status --short
+# git status --short
  M docs/dev/codex_commands.md
  M docs/dev/commit_comment.txt
  M docs/dev/reports/codex_changed_files.txt
  M docs/dev/reports/codex_review.diff
- M docs/dev/reports/preview_generator_v2_class_responsibilities.md
- M tools/preview-generator-v2/index.html
- D tools/preview-generator-v2/previewGeneratorV2.js
-?? tools/preview-generator-v2/PreviewGeneratorV2App.js
-?? tools/preview-generator-v2/PreviewGeneratorV2Capture.js
-?? tools/preview-generator-v2/PreviewGeneratorV2Logger.js
-?? tools/preview-generator-v2/PreviewGeneratorV2RepoAccess.js
-?? tools/preview-generator-v2/PreviewGeneratorV2ShellControl.js
-?? tools/preview-generator-v2/PreviewGeneratorV2Ui.js
-?? tools/preview-generator-v2/controls/
-?? tools/preview-generator-v2/previewGeneratorV2.bootstrap.js
-?? tools/preview-generator-v2/previewGeneratorV2.css
-
-# PR scoped git diff --stat
- docs/dev/codex_commands.md                         |   76 +-
- docs/dev/commit_comment.txt                        |    2 +-
- .../preview_generator_v2_class_responsibilities.md |   35 +-
- tools/preview-generator-v2/index.html              |  476 +------
- tools/preview-generator-v2/previewGeneratorV2.js   | 1317 --------------------
- 5 files changed, 85 insertions(+), 1821 deletions(-)
-
-# New file diff stat: tools/preview-generator-v2/previewGeneratorV2.css
- .../preview-generator-v2/previewGeneratorV2.css    | 338 +++++++++++++++++++++
- 1 file changed, 338 insertions(+)
-
-# New file diff stat: tools/preview-generator-v2/previewGeneratorV2.bootstrap.js
- .../preview-generator-v2/previewGeneratorV2.bootstrap.js             | 5 +++++
- 1 file changed, 5 insertions(+)
-
-# New file diff stat: tools/preview-generator-v2/PreviewGeneratorV2App.js
- .../preview-generator-v2/PreviewGeneratorV2App.js  | 1200 ++++++++++++++++++++
- 1 file changed, 1200 insertions(+)
-
-# New file diff stat: tools/preview-generator-v2/PreviewGeneratorV2Capture.js
- .../PreviewGeneratorV2Capture.js                   | 27 ++++++++++++++++++++++
- 1 file changed, 27 insertions(+)
-
-# New file diff stat: tools/preview-generator-v2/PreviewGeneratorV2Logger.js
- .../PreviewGeneratorV2Logger.js                    | 24 ++++++++++++++++++++++
- 1 file changed, 24 insertions(+)
-
-# New file diff stat: tools/preview-generator-v2/PreviewGeneratorV2RepoAccess.js
- .../PreviewGeneratorV2RepoAccess.js                | 25 ++++++++++++++++++++++
- 1 file changed, 25 insertions(+)
-
-# New file diff stat: tools/preview-generator-v2/PreviewGeneratorV2ShellControl.js
- .../PreviewGeneratorV2ShellControl.js              | 136 +++++++++++++++++++++
- 1 file changed, 136 insertions(+)
-
-# New file diff stat: tools/preview-generator-v2/PreviewGeneratorV2Ui.js
- .../preview-generator-v2/PreviewGeneratorV2Ui.js   | 84 ++++++++++++++++++++++
- 1 file changed, 84 insertions(+)
-
-# New file diff stat: tools/preview-generator-v2/controls/AssetFolderControl.js
- .../controls/AssetFolderControl.js                    | 19 +++++++++++++++++++
- 1 file changed, 19 insertions(+)
-
-# New file diff stat: tools/preview-generator-v2/controls/CaptureModeControl.js
- .../controls/CaptureModeControl.js                 | 28 ++++++++++++++++++++++
- 1 file changed, 28 insertions(+)
-
-# New file diff stat: tools/preview-generator-v2/controls/LastGeneratedImageControl.js
- .../controls/LastGeneratedImageControl.js          | 29 ++++++++++++++++++++++
- 1 file changed, 29 insertions(+)
-
-# New file diff stat: tools/preview-generator-v2/controls/MenuSampleControl.js
- .../controls/MenuSampleControl.js                  | 25 ++++++++++++++++++++++
- 1 file changed, 25 insertions(+)
-
-# New file diff stat: tools/preview-generator-v2/controls/OutputSummaryControl.js
- .../controls/OutputSummaryControl.js                     | 16 ++++++++++++++++
- 1 file changed, 16 insertions(+)
-
-# New file diff stat: tools/preview-generator-v2/controls/PathsOrIdsControl.js
- .../preview-generator-v2/controls/PathsOrIdsControl.js    | 15 +++++++++++++++
- 1 file changed, 15 insertions(+)
-
-# New file diff stat: tools/preview-generator-v2/controls/PreviewFrameControl.js
- .../preview-generator-v2/controls/PreviewFrameControl.js      | 11 +++++++++++
- 1 file changed, 11 insertions(+)
-
-# New file diff stat: tools/preview-generator-v2/controls/RenderControlsControl.js
- .../controls/RenderControlsControl.js                | 20 ++++++++++++++++++++
- 1 file changed, 20 insertions(+)
-
-# New file diff stat: tools/preview-generator-v2/controls/RepoDestinationControl.js
- .../controls/RepoDestinationControl.js                  | 17 +++++++++++++++++
- 1 file changed, 17 insertions(+)
-
-# New file diff stat: tools/preview-generator-v2/controls/StatusControl.js
- .../preview-generator-v2/controls/StatusControl.js          | 13 +++++++++++++
- 1 file changed, 13 insertions(+)
-
-# New file diff stat: tools/preview-generator-v2/controls/TargetSourceControl.js
- .../controls/TargetSourceControl.js                | 35 ++++++++++++++++++++++
- 1 file changed, 35 insertions(+)
-
-# Full git diff --stat
- docs/dev/codex_commands.md                         |   76 +-
- docs/dev/commit_comment.txt                        |    2 +-
- docs/dev/reports/codex_changed_files.txt           |  128 +-
- docs/dev/reports/codex_review.diff                 | 5734 +++++++++++---------
- .../preview_generator_v2_class_responsibilities.md |   35 +-
- tools/preview-generator-v2/index.html              |  476 +-
- tools/preview-generator-v2/previewGeneratorV2.js   | 1317 -----
- 7 files changed, 3276 insertions(+), 4492 deletions(-)
+?? docs/dev/reports/preview_generator_v2_common_style_candidates.txt
+?? docs/dev/reports/preview_generator_v2_playwright_result.txt
+?? docs/dev/reports/preview_generator_v2_shared_dependency_audit.txt
+?? tests/playwright/
+
+# git diff --stat -- . excluding generated review artifact files
+ docs/dev/codex_commands.md  | 74 +++++++++++----------------------------------
+ docs/dev/commit_comment.txt |  2 +-
+ 2 files changed, 18 insertions(+), 58 deletions(-)
+# New file diff stat: docs/dev/reports/preview_generator_v2_common_style_candidates.txt
+ ...review_generator_v2_common_style_candidates.txt | 96 ++++++++++++++++++++++
+ 1 file changed, 96 insertions(+)
+# New file diff stat: docs/dev/reports/preview_generator_v2_playwright_result.txt
+ .../preview_generator_v2_playwright_result.txt     | 38 ++++++++++++++++++++++
+ 1 file changed, 38 insertions(+)
+# New file diff stat: docs/dev/reports/preview_generator_v2_shared_dependency_audit.txt
+ ...review_generator_v2_shared_dependency_audit.txt | 40 ++++++++++++++++++++++
+ 1 file changed, 40 insertions(+)
+# New file diff stat: tests/playwright/PreviewGeneratorV2Baseline.spec.mjs
+ .../playwright/PreviewGeneratorV2Baseline.spec.mjs | 47 ++++++++++++++++++++++
+ 1 file changed, 47 insertions(+)