Skip to content

Commit 0cf9667

Browse files
author
DavidQ
committed
Align preview tool layout to Palette Manager base and add last generated preview display - PR_26126_004-preview-tool-layout-refinement
1 parent 792713f commit 0cf9667

5 files changed

Lines changed: 425 additions & 662 deletions

File tree

docs/dev/codex_commands.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
1-
# Codex Commands - PR_26126_003-preview-tool-layout-spec
1+
# Codex Commands - PR_26126_004-preview-tool-layout-refinement
22

33
```bash
4-
codex run "Create PR_26126_003-preview-tool-layout-spec. Convert the preview tool design into a concrete layout spec for tools/preview/index.html. Define exact regions (header, left panel controls, main preview canvas, right panel properties, footer actions). Specify each control placement (input source, validation status, preview mode selector, zoom, background toggle, export buttons). Include DOM structure outline (ids/classes only, no implementation), state model (toolState shape), and interaction flows (load -> validate -> render -> export). No runtime code. Do not modify samples. Place doc under docs/pr/PR_26126_003-preview-tool-layout-spec.md and produce required review artifacts."
4+
codex run "Create PR_26126_004-preview-tool-layout-refinement. Update the preview tool layout spec to explicitly use Palette Manager as the base layout and interaction pattern (panel structure, control grouping, header usage). Add requirement: center column must include a 'last generated preview' section at the bottom showing the most recent rendered image. Define its placement, sizing, and behavior (replaces on new render, no history, no fallback). Keep strict JSON input rules. No implementation code. Do not modify samples. Update docs/pr/PR_26126_003-preview-tool-layout-spec.md and produce review artifacts."
55
```
66

77
## Validation Commands
88

99
```bash
1010
git diff --check -- docs/pr/PR_26126_003-preview-tool-layout-spec.md docs/dev/codex_commands.md docs/dev/commit_comment.txt
11-
node --input-type=module <write PR-scoped review artifacts>
11+
npm run codex:review-artifacts
1212
```
1313

1414
## Playwright
1515

16-
No Playwright impact. This PR is a documentation/layout-spec-only PR for the Preview tool and does not modify implementation code.
16+
No Playwright impact. This PR refines documentation/layout specification only and does not modify implementation code.
1717

1818
## Full Samples
1919

docs/dev/commit_comment.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Add Preview tool layout spec - PR_26126_003-preview-tool-layout-spec
1+
Refine Preview tool layout spec from Palette Manager pattern - PR_26126_004-preview-tool-layout-refinement
Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,10 @@
11
# git status --short
22
M docs/dev/codex_commands.md
33
M docs/dev/commit_comment.txt
4-
?? docs/pr/PR_26126_003-preview-tool-layout-spec.md
4+
M docs/pr/PR_26126_003-preview-tool-layout-spec.md
55

66
# git diff --stat
7-
docs/dev/codex_commands.md | 10 +++++-----
8-
docs/dev/commit_comment.txt | 2 +-
9-
2 files changed, 6 insertions(+), 6 deletions(-)
10-
11-
# New design doc diff --stat
12-
.../pr/PR_26126_003-preview-tool-layout-spec.md | 619 +++++++++++++++++++++
13-
1 file changed, 619 insertions(+)
14-
15-
# Scope note
16-
PR_26126_003 is documentation/layout-spec only. No samples or runtime code were modified.
7+
docs/dev/codex_commands.md | 8 +-
8+
docs/dev/commit_comment.txt | 2 +-
9+
docs/pr/PR_26126_003-preview-tool-layout-spec.md | 149 +++++++++++++++++++++--
10+
3 files changed, 141 insertions(+), 18 deletions(-)

0 commit comments

Comments
 (0)