Skip to content

Commit 792713f

Browse files
author
DavidQ
committed
Define concrete layout spec and control placement for preview tool - PR_26126_003-preview-tool-layout-spec
1 parent 1a8b4c5 commit 792713f

5 files changed

Lines changed: 1275 additions & 33 deletions

File tree

docs/dev/codex_commands.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
1-
# Codex Commands - PR_26126_002-preview-tool-detailed-design
1+
# Codex Commands - PR_26126_003-preview-tool-layout-spec
22

33
```bash
4-
codex run "Create PR_26126_002-preview-tool-detailed-design. Add a detailed design document for tools/preview/index.html covering capabilities, UI regions, control placement, input/output contracts, error states, preview modes, and export actions. No implementation code. Do not modify samples. Place design under docs/pr/PR_26126_002-preview-tool-detailed-design.md and produce required review artifacts."
4+
codex run "Create PR_26126_003-preview-tool-layout-spec. Convert the preview tool design into a concrete layout spec for tools/preview/index.html. Define exact regions (header, left panel controls, main preview canvas, right panel properties, footer actions). Specify each control placement (input source, validation status, preview mode selector, zoom, background toggle, export buttons). Include DOM structure outline (ids/classes only, no implementation), state model (toolState shape), and interaction flows (load -> validate -> render -> export). No runtime code. Do not modify samples. Place doc under docs/pr/PR_26126_003-preview-tool-layout-spec.md and produce required review artifacts."
55
```
66

77
## Validation Commands
88

99
```bash
10-
git diff --check -- docs/pr/PR_26126_002-preview-tool-detailed-design.md docs/dev/codex_commands.md docs/dev/commit_comment.txt
11-
npm run codex:review-artifacts
10+
git diff --check -- docs/pr/PR_26126_003-preview-tool-layout-spec.md docs/dev/codex_commands.md docs/dev/commit_comment.txt
11+
node --input-type=module <write PR-scoped review artifacts>
1212
```
1313

1414
## Playwright
1515

16-
No Playwright impact. This PR is a documentation/design-only PR for the Preview tool and does not modify implementation code.
16+
No Playwright impact. This PR is a documentation/layout-spec-only PR for the Preview tool and does not modify implementation code.
1717

1818
## Full Samples
1919

docs/dev/commit_comment.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Add Preview tool detailed design - PR_26126_002-preview-tool-detailed-design
1+
Add Preview tool layout spec - PR_26126_003-preview-tool-layout-spec
Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,16 @@
11
# git status --short
22
M docs/dev/codex_commands.md
33
M docs/dev/commit_comment.txt
4+
?? docs/pr/PR_26126_003-preview-tool-layout-spec.md
45

56
# git diff --stat
6-
docs/dev/codex_commands.md | 19 +++++--------------
7+
docs/dev/codex_commands.md | 10 +++++-----
78
docs/dev/commit_comment.txt | 2 +-
8-
2 files changed, 6 insertions(+), 15 deletions(-)
9+
2 files changed, 6 insertions(+), 6 deletions(-)
10+
11+
# New design doc diff --stat
12+
.../pr/PR_26126_003-preview-tool-layout-spec.md | 619 +++++++++++++++++++++
13+
1 file changed, 619 insertions(+)
14+
15+
# Scope note
16+
PR_26126_003 is documentation/layout-spec only. No samples or runtime code were modified.

0 commit comments

Comments
 (0)