Skip to content

Commit 0190349

Browse files
author
DavidQ
committed
Normalize sample JSON destination hints to sample-local paths - PR 10.24
1 parent be5c6d0 commit 0190349

9 files changed

Lines changed: 173 additions & 13 deletions

File tree

‎docs/dev/codex_commands.md‎

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,17 @@
11
# CODEX COMMANDS
22

33
model: gpt-5.3-codex
4-
reasoning: low
4+
reasoning: medium
55

6-
Apply PR_10_23_SAMPLE_IMPORT_DESTINATION_PRESET_FIX.
6+
Apply PR_10_24_SAMPLE_JSON_DESTINATION_NORMALIZATION.
77

88
Required:
9-
- In sample-owned tool JSON presets, replace misleading `games/<project>/...` importDestination values with sample-local paths.
10-
- Cover all samples, including 0204, 1413, and 1505.
11-
- Do not change game-owned workflow presets under games/.
12-
- Preserve asset catalogs, IDs, source paths, schemas, and preview behavior.
13-
- Verify no sample-owned JSON still contains `games/<project>/`.
14-
- Add validation report at docs/dev/reports/PR_10_23_SAMPLE_IMPORT_DESTINATION_PRESET_FIX_report.md.
15-
- Return ZIP artifact at tmp/PR_10_23_SAMPLE_IMPORT_DESTINATION_PRESET_FIX_delta.zip.
9+
- Check all JSON files under samples/ for misleading destination hints.
10+
- Replace any sample-owned `games/<project>/...` destination with sample-local paths.
11+
- Remove/replace sample destination hints that point to nonexistent `config/` folders.
12+
- Specifically fix sample 1413 Asset Browser / Import Hub suggested destination from `games/<project>/config/` to a valid sample-local path.
13+
- Preserve asset catalogs, source paths, IDs, schemas, and tool identities.
14+
- Do not modify game-owned JSON under games/.
15+
- Do not modify start_of_day folders.
16+
- Add validation report at docs/dev/reports/PR_10_24_SAMPLE_JSON_DESTINATION_NORMALIZATION_report.md.
17+
- Return ZIP artifact at tmp/PR_10_24_SAMPLE_JSON_DESTINATION_NORMALIZATION_delta.zip.

‎docs/dev/commit_comment.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Use sample-local import destinations in sample Asset Browser and Import Hub presets - PR 10.23
1+
Normalize sample JSON destination hints to sample-local paths - PR 10.24

‎docs/dev/reports/PR_10_24_SAMPLE_JSON_DESTINATION_NORMALIZATION_report.md‎

Lines changed: 54 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,54 @@
1+
# PR_10_24_SAMPLE_JSON_DESTINATION_NORMALIZATION Report
2+
3+
## Scope
4+
Normalized misleading sample-owned JSON destination hints under `samples/` to valid sample-local paths, without modifying game-owned JSON or runtime/sample implementation code.
5+
6+
## Files Changed
7+
- `samples/phase-02/0204/sample.0204.asset-browser.json`
8+
- `samples/phase-14/1413/sample.1413.asset-browser.json`
9+
- `samples/phase-15/1505/sample.1505.asset-browser.json`
10+
- `docs/dev/reports/PR_10_24_SAMPLE_JSON_DESTINATION_NORMALIZATION_report.md`
11+
12+
## Destination Hint Changes
13+
14+
### 0204
15+
- `importDestination`
16+
- from: `/samples/phase-02/0204/config/`
17+
- to: `/samples/phase-02/0204/assets/`
18+
19+
### 1413
20+
- `importDestination`
21+
- from: `/samples/phase-14/1413/assets/sprites/`
22+
- to: `/samples/phase-14/1413/assets/images/`
23+
24+
### 1505
25+
- `importDestination`
26+
- from: `/samples/phase-15/1505/config/`
27+
- to: `/samples/phase-15/1505/assets/`
28+
29+
## 1413 Specific Requirement
30+
- The sample 1413 Asset Browser / Import Hub destination hint is now a valid sample-local path:
31+
- `/samples/phase-14/1413/assets/images/`
32+
33+
## Preservation Confirmations
34+
- Asset catalogs unchanged.
35+
- Source paths unchanged.
36+
- IDs unchanged.
37+
- Schemas unchanged.
38+
- Tool identities unchanged.
39+
- Preview behavior-related fields unchanged.
40+
41+
## Validation Performed
42+
1. Searched all JSON under `samples/` for `games/<project>/` placeholders.
43+
2. Enumerated `importDestination` fields in all sample JSON.
44+
3. Parsed changed JSON files to confirm valid JSON.
45+
4. Verified each updated destination path exists on disk.
46+
47+
## Validation Results
48+
- No sample-owned JSON contains `games/<project>/`.
49+
- Updated destination hints point to existing sample-local folders.
50+
- Changed JSON files parse successfully.
51+
52+
## Guardrails
53+
- No modifications under `games/`.
54+
- No `start_of_day` folder changes.

‎docs/dev/reports/REPORT_PR_10_24.md‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
# REPORT_PR_10_24_SAMPLE_JSON_DESTINATION_NORMALIZATION
2+
3+
## Bundle Summary
4+
This PR cleans up sample-owned JSON destination hints across all samples.
5+
6+
## Target Behavior
7+
- No sample JSON points to `games/<project>/...`.
8+
- No sample JSON suggests nonexistent `config/` destinations.
9+
- Sample 1413 Workflow JSON destination becomes sample-local.
10+
- Catalog data remains unchanged.

‎docs/pr/PR_10_24_SAMPLE_JSON_DESTINATION_NORMALIZATION/BUILD.md‎

Lines changed: 66 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,66 @@
1+
# BUILD_PR_10_24_SAMPLE_JSON_DESTINATION_NORMALIZATION
2+
3+
## Required Codex Work
4+
5+
### 1. Search sample JSON only
6+
Search all `*.json` files under:
7+
`samples/`
8+
9+
Find destination-like fields/values including:
10+
- `importDestination`
11+
- `exportDestination`
12+
- `destination`
13+
- `suggestedDestination`
14+
- `outputPath`
15+
- any displayed "Suggested destination" value
16+
- any string containing `games/<project>/`
17+
- any string ending in `/config/` or containing `/config/`
18+
19+
### 2. Normalize destinations
20+
For sample-owned JSON:
21+
- replace `games/<project>/...` with sample-local paths
22+
- do not use `config/` unless the specific sample actually has/uses a config folder
23+
- prefer existing real folders when present
24+
- otherwise prefer a clear sample-local generated/import folder such as:
25+
- `samples/phase-XX/NNNN/assets/`
26+
- `samples/phase-XX/NNNN/assets/imports/`
27+
- `samples/phase-XX/NNNN/data/`
28+
- `samples/phase-XX/NNNN/imports/`
29+
30+
Use the smallest path that matches the asset/category purpose.
31+
32+
### 3. Specific required fix
33+
For sample 1413:
34+
- `sample.1413.asset-browser.json`
35+
- row/category: `Workflow JSON`
36+
- current suggested destination: `games/<project>/config/`
37+
- must become a sample-local destination.
38+
- Do not create or reference `config/` unless it is intentionally added and justified. Prefer an existing or clearly sample-owned folder.
39+
40+
### 4. Preserve data ownership
41+
Do not alter:
42+
- asset catalog IDs
43+
- asset source paths
44+
- schema references
45+
- tool identity
46+
- selected asset IDs unless required because the destination field was the only issue
47+
48+
### 5. Validation
49+
Create:
50+
docs/dev/reports/PR_10_24_SAMPLE_JSON_DESTINATION_NORMALIZATION_report.md
51+
52+
Report must include:
53+
- scan scope
54+
- every matched issue
55+
- every changed file
56+
- before/after destination values
57+
- confirmation no `samples/**/*.json` contains `games/<project>/`
58+
- confirmation no invalid sample `config/` destination remains
59+
- confirmation no `games/` files changed
60+
- confirmation no start_of_day changes
61+
62+
## Constraints
63+
- Samples JSON destination normalization only.
64+
- No tool implementation changes unless a display-only label is incorrectly hardcoded.
65+
- No schema rewrite.
66+
- No sample runtime code changes.

‎docs/pr/PR_10_24_SAMPLE_JSON_DESTINATION_NORMALIZATION/PLAN.md‎

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
# PLAN_PR_10_24_SAMPLE_JSON_DESTINATION_NORMALIZATION
2+
3+
## Purpose
4+
Normalize all sample-owned JSON import/export destination hints so they point to real sample-local locations.
5+
6+
## Problem
7+
Some sample JSON files still contain misleading destination hints such as:
8+
- `games/<project>/config/`
9+
- sample-local workflows suggesting a `config/` folder that does not exist
10+
- Asset Browser / Import Hub rows like:
11+
`Workflow JSON | /samples/phase-14/1413/sample.1413.asset-browser.json | Suggested destination: games/<project>/config/`
12+
13+
When the user is inside `samples/`, destination hints must not refer to `games/`, and must not suggest nonexistent folders.
14+
15+
## Scope
16+
- Check all JSON files under `samples/`.
17+
- Fix sample-owned destination fields only.
18+
- Normalize sample import/export destinations to real sample-local paths.
19+
- Preserve source asset paths, schema, IDs, and catalog entries.
20+
- Do not modify game-owned JSON.
21+
- Do not modify start_of_day folders.
22+
23+
## Acceptance
24+
- No JSON under `samples/` contains `games/<project>/` as a destination hint.
25+
- No JSON under `samples/` suggests `config/` unless that sample folder actually has/uses a config folder.
26+
- Sample 1413 Asset Browser preset shows a sample-local destination, not `games/<project>/config/`.
27+
- Asset Browser / Import Hub still loads the full catalog.
28+
- Validation report lists every changed JSON file and before/after destination.

‎samples/phase-02/0204/sample.0204.asset-browser.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
"selectedAssetId": "sample-0204-registry-node",
4040
"search": "0204",
4141
"importCategory": "Workflow JSON",
42-
"importDestination": "/samples/phase-02/0204/config/",
42+
"importDestination": "/samples/phase-02/0204/assets/",
4343
"importName": "sample-0204-import.workflow.json"
4444
}
4545
}

‎samples/phase-14/1413/sample.1413.asset-browser.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
"selectedAssetId": "sample-1413-imported-sheet",
4040
"search": "",
4141
"importCategory": "Sprite Projects",
42-
"importDestination": "/samples/phase-14/1413/assets/sprites/",
42+
"importDestination": "/samples/phase-14/1413/assets/images/",
4343
"importName": "sample-1413-import.sprite.json"
4444
}
4545
}

‎samples/phase-15/1505/sample.1505.asset-browser.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
"selectedAssetId": "sample-1505-asset-browser-preset",
3131
"search": "",
3232
"importCategory": "Workflow JSON",
33-
"importDestination": "/samples/phase-15/1505/config/",
33+
"importDestination": "/samples/phase-15/1505/assets/",
3434
"importName": "sample-1505-import.workflow.json"
3535
}
3636
}

0 commit comments

Comments
 (0)