feat(https-proxy-agent): add esm support to https-proxy-agent#375
Closed
ryanleecode wants to merge 1 commit intoTooTallNate:mainfrom
Closed
feat(https-proxy-agent): add esm support to https-proxy-agent#375ryanleecode wants to merge 1 commit intoTooTallNate:mainfrom
ryanleecode wants to merge 1 commit intoTooTallNate:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 561d666 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ryanleecode
force-pushed
the
feat/https-proxy-agent-esm
branch
from
3cc2f30 to
df64535
Compare
ryanleecode
changed the title
ryanleecode
force-pushed
the
feat/https-proxy-agent-esm
branch
from
df64535 to
561d666
Compare
Owner
|
Curious - what is the issue with CJS? |
Author
|
Cannot be dynamically imported
…On Mon, Jul 7, 2025, 12:35 p.m. Nathan Rajlich ***@***.***> wrote:
*TooTallNate* left a comment (TooTallNate/proxy-agents#375)
<#375 (comment)>
Curious - what is the issue with CJS?
—
Reply to this email directly, view it on GitHub
<#375 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFDCXUCFNBOG2IIEK2HEKBL3HKOU7AVCNFSM6AAAAAB6OH7GYGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTANBVHA3DAOBVGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Owner
|
Not sure what you mean. As in |
Fool256
approved these changes
Jul 31, 2025
I'm migrating my package to ESM and wanna be able to just import it in the ESM context like so |
Contributor
|
This was addressed in 9c92c09 which converted all packages to ESM with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently every package is outputting CJS. This adds support for ESM and CJS output for the https-proxy-agent package. if accepted, this approach can be used for other packages.