Skip to content

ci: add workflow_dispatch and build step to npm-publish #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TonyCasey merged 1 commit into from
Feb 16, 2026
Merged

ci: add workflow_dispatch and build step to npm-publish #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/npm-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ name: Node.js Package
on:
release:
types: [created]
workflow_dispatch:

Comment on lines 7 to 10
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow triggers on release: created, but the repo already publishes via semantic-release on push to main (release-on-merge.yml) and creates GitHub releases. When semantic-release creates a release, this workflow will also run and attempt a second npm publish, which will likely fail (version already published) and adds operational noise. Consider removing the release trigger and keeping only workflow_dispatch, or otherwise ensure it won’t double-publish (e.g., guard conditions / use a different registry or artifact source).

Suggested change
release:
types: [created]
workflow_dispatch:
workflow_dispatch:

Copilot uses AI. Check for mistakes.
jobs:
build:
Expand All @@ -28,6 +29,7 @@ jobs:
node-version: 20
registry-url: https://registry.npmjs.org/
- run: npm ci
- run: npm run build
- run: npm publish
env:
NODE_AUTH_TOKEN: ${{secrets.npm_token}}