Add native SponsorBlock integration#49
Conversation
|
Can you send me a screenshot about the skip banner? I want to see what it looks like. |
|
Can you trigger a skip dialog and send a screenshot here? |
|
Note: This is a v1 implementation focused on getting all the core functionality working. Known limitations that I plan to address later(in a follow up PR):
All core SponsorBlock functionality is complete and working — skipping, notifications, per-category settings, overlay toggle, and highlight support. |
|
One more thing, can you do a long press on the miniplayer to see what happens? |
Nothing happens on long press of the miniplayer. Video continues to play normally |
|
@grohit1810 Nevermind, I tested it. The dialog is too small compares to YTLite. But a lot of things need to implement here.
|
|
@Tonwalter888 Updated the PR with all the requested changes
|
|
@grohit1810 Can you make the skip dialog like in YTLite? |
|
@grohit1810 Actually, can you use system UI settings (like this Sponsorblock) for all settings? YouTube’s settings are unstable and glichy. |
|
@Tonwalter888 For the system UI settings rewrite do you want that in this same PR, or should I open a separate one? It's a bigger change that touches the entire settings flow, so wanted to check. Also just a heads up: I am writing and understanding the code myself (not fully AI generated), so my turnaround will be slower |
You can do on this PR. Just rewrite like the SponsorBlock you wrote, that's all I wanted. (Inside the sections) |
|
@Tonwalter888 Update the PR with both the changes
|
Will test this, thanks for implementing them. |
|
@grohit1810 I think there are some missing SponsorBlock segments. |
|
Also adds a skip dialog for hightlight |
|
@grohit1810 Also makes the button hidden with the overlay. |
|
@grohit1810 I will add the new features in v1.4.0 in here. |
|
@Tonwalter888 I am not sure why you are not able to see the new pill shaped button in fullscreen mode? I have the fix other two issues - Slider bar and hide sponsorblock button overlay |
|
@grohit1810 Okey then. |
|
@Tonwalter888 Found the issue with full screen. I will fix this as well in my next commit |
Alright, I will add more features after you pushed your fix. |
|
@grohit1810 The back button stays black in dark mode. |
|
@Tonwalter888 Fixed all three issues I will fix the back button stays not visible in dark mode in the next commit. |
|
@grohit1810 Lastly, can you use the dialog for downloading? Replace the HUD toast with our dialog. (Replace the skip icon to a check and a cross (x) for errors) |
|
@grohit1810 |
|
@Tonwalter888 I will fix all three issues - back button, not adhering to the wait times and the black back button |
|
Known issue I discovered: The Shorts download button does not pull up the download manager. |
Yep, I know. |
Fixed. |
|
But we're not done yet with 2.0.0. We still have to move the download manager button and bug fixes, just to name a few. |
The download button is moved to the player overlay. |
|
However one thing that bothers me about the SponsorBlock is the skip delay/cooldown after a segment has been skipped. |















Summary
Adds built-in SponsorBlock support to YouMod, implementing all 9 segment categories with configurable per-category actions. This is a native implementation (not a bundled iSponsorBlock dylib), making it easier to maintain and extending support to include the Highlight (poi_highlight) category that iSponsorBlock lacks.
Resolves #34
Features
Architecture
Files/SponsorBlock.xFiles/SponsorBlockUI.xFiles/SponsorBlockSettings.x