Conversation
data is not installed by the pip command so it is not useful to clone the repo recursively
paskino
requested review from
casperdcl,
gfardell and
lauramurgatroyd
and removed request for
a team
Added information about creating a shallow clone with --depth parameter.
docs/source/developer_guide.rst
Outdated
| - Command | ||
| - Status | ||
| * - Linux | ||
| - ``conda env create -f https://tomographicimaging.github.io/scripts/env/cil_development.yml`` |
There was a problem hiding this comment.
conda env create -f https://tomographicimaging.github.io/scripts/env/cil_development.yml
CondaHTTPError: HTTP 404 NOT FOUND for url https://tomographicimaging.github.io/scripts/env/cil_development.yml
There was a problem hiding this comment.
For anyone else who is testing the files are here and you need to use them instead of the url:
https://github.com/TomographicImaging/scripts/pull/9/changes
There was a problem hiding this comment.
That's right, I didn't want to link to a PR, so I wrote the link as it will be once #9 is merged
casperdcl
left a comment
casperdcl
left a comment
There was a problem hiding this comment.
a bit concerned about:
- repetition in
README.md&developer_guide.rst(would prefer one to link to the other) - lack of mention of conda env names (
create --name <env_name>&&activate <env_name)
|
|
||
|
|
||
|
|
| #### Install Dependencies | ||
|
|
||
| To create a conda environment with all the dependencies for building CIL run the following shell script: | ||
| We suggest creating a conda environment with all the dependencies for building CIL running the following shell script depending on operating system: |
There was a problem hiding this comment.
| We suggest creating a conda environment with all the dependencies for building CIL running the following shell script depending on operating system: | |
| We suggest creating a conda environment with all the dependencies for building CIL using the appropriate command for your operating system: |
|
I agree with @casperdcl , please remove the duplication. I found it confusing to review, let alone maintain in the future |
| Install Dependencies | ||
| """""""""""""""""" | ||
|
|
||
| We suggest creating a conda environment with all the dependencies for building CIL running the following shell script depending on operating system: |
There was a problem hiding this comment.
| We suggest creating a conda environment with all the dependencies for building CIL running the following shell script depending on operating system: | |
| We suggest creating a conda environment with all the dependencies for building CIL using the appropriate command for your operating system: |
Signed-off-by: Casper da Costa-Luis <casper.dcl@physics.org>
3 participants
Description
FindIPP.cmaketo find IPP libraries on WindowsExample Usage
Contribution Notes
Changes
README.md-Ccmake.define.IPP_ROOT=$CONDA_PREFIXwas passedTesting you performed
Local build on:
Checked the artifact documentation produced by GHA.
Linux
On Linux a total of 43 tests are skipped:
Plus these which test compatibility with SIRF (which is not installed)
Windows
Related issues/links
Checklist