Added name attribute to CTkButton, CTkFrame and CTkBaseClass#1676
Open
octimot wants to merge 5 commits intoTomSchimansky:masterfrom
Open
Added name attribute to CTkButton, CTkFrame and CTkBaseClass#1676octimot wants to merge 5 commits intoTomSchimansky:masterfrom
octimot wants to merge 5 commits intoTomSchimansky:masterfrom
Conversation
889b0aa to
d973d84
Compare
Removed icon replacement
Fixed CTkLabel name attribute
|
@TomSchimansky sry to ping but any chance this could get merged in a future version ? This would be really usefull |
Collaborator
|
Hi all, Let me reverse the question: is there any reason to use this method? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
nameattribute is super useful when dealing with multiple windows and/or observer patterns, since it's the cleanest way to update widgets from different objects/functions etc. using nametowidget()I would recommend adding this attribute back to all the widgets, if possible.
This was mentioned multiple times, including #419 #422 #961 etc.
I find my proposed method the easiest to implement.
Is there any reason to avoid this?