Skip to content

Compatible with Julia 1.11#13

Draft
MarDiehl wants to merge 3 commits into
Tokazama:masterfrom
MarDiehl:MarDiehl/12-compatible-with-Julia-1.11
Draft

Compatible with Julia 1.11#13
MarDiehl wants to merge 3 commits into
Tokazama:masterfrom
MarDiehl:MarDiehl/12-compatible-with-Julia-1.11

Conversation

@MarDiehl

Copy link
Copy Markdown

using works, but tests fail.

Understanding the specialization is beyond my Julia knowledge.

fixes #12

MarDiehl added 2 commits July 13, 2025 16:52
dependencies for test can be specified in subdirectory
@MarDiehl MarDiehl changed the title Draft: compatible with Julia 1.11 Compatible with Julia 1.11 Jul 13, 2025
@MarDiehl MarDiehl marked this pull request as draft July 13, 2025 15:55
@MarDiehl MarDiehl force-pushed the MarDiehl/12-compatible-with-Julia-1.11 branch from f22f87f to b7f47f2 Compare September 10, 2025 08:35
old versions do not work anymore
@MarDiehl MarDiehl force-pushed the MarDiehl/12-compatible-with-Julia-1.11 branch from b7f47f2 to 2100d2b Compare September 10, 2025 10:31
@MarDiehl

Copy link
Copy Markdown
Author

the detailed error message is

3 ambiguities found. To get a list, set `broken = false`.
Ambiguity #1
read!(x::Metadata.MetaIO, A::AbstractArray) @ Metadata ~/work/Metadata.jl/Metadata.jl/src/MetaIO.jl:23
read!(s::IO, A::StridedArray{T}) where T @ Base io.jl:930

Possible fix, define
  read!(::Metadata.MetaIO, ::StridedArray{T}) where T

Ambiguity #2
write(s::Metadata.MetaIO, x::SubArray{T, N, P} where P<:Array) where {T, N} @ Metadata ~/work/Metadata.jl/Metadata.jl/src/MetaIO.jl:35
write(s::IO, A::StridedArray) @ Base io.jl:833

Possible fix, define
  write(::Metadata.MetaIO, ::SubArray{T, N, A, I} where {A<:Array, I<:Tuple{Vararg{Union{Base.AbstractCartesianIndex, AbstractRange{<:Union{Int128, Int16, Int32, Int64, Int8, UInt128, UInt16, UInt32, UInt64, UInt8}}, Base.ReshapedArray{T, N, A, Tuple{}} where {T, N, A<:AbstractUnitRange}, Int128, Int16, Int32, Int64, Int8, UInt128, UInt16, UInt32, UInt64, UInt8}}}}) where {T, N}

Ambiguity #3
write(x::Metadata.MetaIO, A::AbstractArray) @ Metadata ~/work/Metadata.jl/Metadata.jl/src/MetaIO.jl:31
write(s::IO, A::StridedArray) @ Base io.jl:833

Possible fix, define
  write(::Metadata.MetaIO, ::StridedArray)

Method ambiguity: Test Failed at /home/runner/.julia/packages/Aqua/MCcFg/src/ambiguities.jl:78
  Expression: iszero(num_ambiguities)

see https://github.com/MarDiehl/Metadata.jl/actions/runs/17608108934

@Tokazama

Copy link
Copy Markdown
Owner

Sorry, I completely forgot about this. I took a look at some of your work and fixed the ambiguities for the PR that I just merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compatibility with Julia 1.11

2 participants