Fix: 32-bit iOS builds failing due to targeting an iOS version that is too high#275
Merged
toktok-releaser merged 1 commit intoTokTok:masterfrom Mar 30, 2026
Merged
Conversation
Fixes builds failing due to the clang warning being triggered: clang: error: invalid iOS deployment version '-miphoneos-version-min=15.0', iOS 10 is the maximum deployment target for 32-bit targets [-Winvalid-ios-deployment-target]
Green-Sky
approved these changes
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iOS 10 is the maximum deployment target for 32-bit builds, yet we are targeting iOS 15. It looks like clang was updated and added a warning for this at some point, so our builds now fail, since we
-Werror.Snippet of the CI failure from TokTok/c-toxcore#3031:
While c-toxcore's
other/deploy/ios.shscript does attempt to set the version to iOS 10:https://github.com/TokTok/c-toxcore/blob/8ffeabe452938609c3516665db2f14785f259d30/other/deploy/ios.sh#L23
it does so too late in the script, as it sets it only for building toxcore, not the deps. The failure happens during the dep building, in the
deps.shcall, which callsparse_archfunction from TokTok/Dockerfiles'sdockerfiles/qtox/build_utils.sh, where it's hardcoded to 15.0 viaIOS_MINIMUM_SUPPORTED_VERSION=15.0:dockerfiles/qtox/build_utils.sh
Line 36 in 0774716
This PR fixes builds failing due to the clang warning being triggered by setting the
IOS_MINIMUM_SUPPORTED_VERSIONto 10.0 for 32-bit iOS builds.I have tested this change in the mentioned PR TokTok/c-toxcore#3031 with TokTok/c-toxcore@d18ee91 and it did indeed fix the failure.
When trying to figure out why the c-toxcore iOS CI is failing, seeing it call into qtox scripts raised some eyebrows here. I thought it might be mistakenly calling the wrong scripts, since c-toxcore shouldn't have anything to do with qtox. Surprised there is no common deps directory of sorts.
This change is