refactor: Add tox_options_set_savedata, deprecate old functions.#2840
Draft
iphydf wants to merge 1 commit intoTokTok:masterfrom
Draft
refactor: Add tox_options_set_savedata, deprecate old functions.#2840iphydf wants to merge 1 commit intoTokTok:masterfrom
iphydf wants to merge 1 commit intoTokTok:masterfrom
Conversation
github-actions
bot
added
the
refactor
iphydf
force-pushed
the
savedata
branch
4 times, most recently
from
092015c to
ce5870d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2840 +/- ##
==========================================
- Coverage 72.14% 72.02% -0.12%
==========================================
Files 152 152
Lines 31182 31192 +10
==========================================
- Hits 22496 22467 -29
- Misses 8686 8725 +39 ☔ View full report in Codecov by Sentry. |
iphydf
force-pushed
the
savedata
branch
4 times, most recently
from
17045ee to
1038738
Compare
This one is simpler than the existing tox_options_set_savedata_data and therefore safer for clients to use. It will either fail (no change) or succeed (allocation+copy). Also setting data size without setting data makes no sense, so that function is now deprecated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one is simpler than the existing tox_options_set_savedata_data and
therefore safer for clients to use. It will either fail (no change) or
succeed (allocation+copy).
Also setting data size without setting data makes no sense, so that
function is now deprecated.
This change is