Skip to content

fix crash when using empty placeholders #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Toine-db merged 1 commit into from
Feb 5, 2025
Merged

fix crash when using empty placeholders #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/MarkdownParser/Writer/ViewFormatter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ private void WriteInlineToView(Inline inline, ViewWriter<T> writer)
writer.AddEmphasis(inline, inline.SourcePosition, inline.SourceLength);
break;
case InlineTag.Placeholder:
writer.AddPlaceholder(inline.SourcePosition, inline.SourceLength, inline.TargetUrl, inline.FirstChild.LiteralContent);
writer.AddPlaceholder(inline.SourcePosition, inline.SourceLength, inline.TargetUrl, inline.FirstChild?.LiteralContent);
break;
case InlineTag.Strikethrough:
case InlineTag.Emphasis:
Expand Down
5 changes: 5 additions & 0 deletions src/MarkdownParser/Writer/ViewWriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,11 @@ public void AddLink(int firstCharacterPosition, int length, string url, string u

public void AddPlaceholder(int firstCharacterPosition, int length, string url, string title)
{
if (string.IsNullOrWhiteSpace(url))
{
return;
}

GetWorkbenchItem().AddPlaceholder(firstCharacterPosition, length, url, title);
}

Expand Down
26 changes: 26 additions & 0 deletions test/MarkdownParser.Test/MarkdownParserSingleComponentSpecs.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,4 +246,30 @@ public void When_parsing_a_placeholder_it_should_output_a_PlaceHolderView()
parseResult.Count.Should().Be(1);
parseResult.First().Should().Be("textview:my-placeholder");
}

[TestMethod]
public void When_parsing_a_empty_placeholder_it_should_not_output_placeholder()
{
//-----------------------------------------------------------------------------------------------------------
// Arrange
//-----------------------------------------------------------------------------------------------------------
var markdown = @"
[ ]
[]
";

var mockComponentSupplier = new StringComponentSupplier();
var parser = new MarkdownParser<string>(mockComponentSupplier);

//-----------------------------------------------------------------------------------------------------------
// Act
//-----------------------------------------------------------------------------------------------------------
var parseResult = parser.Parse(markdown);

//-----------------------------------------------------------------------------------------------------------
// Assert
//-----------------------------------------------------------------------------------------------------------
parseResult.Count.Should().Be(1);
parseResult.First().Should().Be("textview:");
}
}
Loading