-
Notifications
You must be signed in to change notification settings - Fork 159
Feature/Issue-622 | Feature/issue-548 | Mods and Authors can edit event #667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feature/Issue-622 | Feature/issue-548 | Mods and Authors can edit event #667
Conversation
|
ScreenCapture of Fix: |
…dit event now | Fixed a bug where author was showing as Deleted | Populated the user in PATCH Request
|
Thanks for the PR, looks like linting failed, might need to run Prettier |
…nt | Fixed linting in Contributing.md
Hi @DevinCLane , I have fixed linting in Contributing.md. |
| 1. Set upstream to track the remote repository containing the original repo. (Not just your fork.) | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah just unsure why these files are changed in this PR, maybe possible to remove this from the PR? If too difficult I'm sure we can make it work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DevinCLane it is not mine changes, but on previous commits because of contributing.md the checks were failing and i think this file was not formatted, so to fix checks I have run formatting command and pushed formatted contributing.md to pass checks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah so I would try to remove this from your git history so the file remains unchanged in this PR. That might entail a rebase. If that's too difficult we can leave it as it.
…ent now
Description
The changes included mostly on backend and frontend, On backend added updateEventController to update the event based on particular id and used PATCH for Partial updation, on the other side added Editmodal which will be prefilled by default, user or mods can edit to edit there there event, Added isEditing state by that addEventModal and EditEventModal will come.
Type of change
Please select everything applicable. Please, do not delete any lines.
Issue
Checklist:
npm run testandnpm run test:e2eand all tests have passed successfully or I have included details within my PR on the failure.npm run lintand resolved any outstanding errors. Most issues can be solved by executingnpm run format