Skip to content

Conversation

@PratikTomar
Copy link
Contributor

…ent now

Description

The changes included mostly on backend and frontend, On backend added updateEventController to update the event based on particular id and used PATCH for Partial updation, on the other side added Editmodal which will be prefilled by default, user or mods can edit to edit there there event, Added isEditing state by that addEventModal and EditEventModal will come.

Type of change

Please select everything applicable. Please, do not delete any lines.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change requires an update to testing

Issue

Checklist:

  • This PR is up to date with the main branch, and merge conflicts have been resolved
  • I have executed npm run test and npm run test:e2e and all tests have passed successfully or I have included details within my PR on the failure.
  • I have executed npm run lint and resolved any outstanding errors. Most issues can be solved by executing npm run format
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@PratikTomar
Copy link
Contributor Author

ScreenCapture of Fix:
screen-capture.webm

…dit event now | Fixed a bug where author was showing as Deleted | Populated the user in PATCH Request
@DevinCLane
Copy link
Collaborator

Thanks for the PR, looks like linting failed, might need to run Prettier

@PratikTomar
Copy link
Contributor Author

Thanks for the PR, looks like linting failed, might need to run Prettier

Hi @DevinCLane , I have fixed linting in Contributing.md.

Comment on lines +130 to +131
1. Set upstream to track the remote repository containing the original repo. (Not just your fork.)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah just unsure why these files are changed in this PR, maybe possible to remove this from the PR? If too difficult I'm sure we can make it work

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DevinCLane it is not mine changes, but on previous commits because of contributing.md the checks were failing and i think this file was not formatted, so to fix checks I have run formatting command and pushed formatted contributing.md to pass checks

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah so I would try to remove this from your git history so the file remains unchanged in this PR. That might entail a rebase. If that's too difficult we can leave it as it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants