-
Notifications
You must be signed in to change notification settings - Fork 159
fix: remove hardcoded issue reference from PR template #609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
also in general, it's best to keep working on the same pull request instead of opening another one |
|
@absar22 any updates on this? |
|
Please review when you get a chance. |
.github/pull_request_template.md
Outdated
| ## Issue | ||
|
|
||
| - [ ] Is this related to a specific issue? If so, please specify: | ||
| Resolves #532 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Resolves #532 | |
| Resolves #[add your issue number here, keep the `#`, delete this text and the `[]`] |
|
Hi Devin, I’ve updated the PR template with the dynamic issue placeholder as requested. Could you please re-review? |
merrua
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this change. The text is understandable to link the pr to the issue.
It looks like you have multiple commits that can be squashed into one, also can you rebase on main?
|
can you squash your commits @absar22 ? thanks! |
|
Got it, I’ll squash and push the updated commit soon. 👍 |
|
Hi @DevinCLane , |
|
sure no problem |
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. Additionally, please include reasoning if tests have failed.
Type of change
Please select everything applicable. Please, do not delete any lines.
Issue
Checklist:
npm run testandnpm run test:e2eand all tests have passed successfully or I have included details within my PR on the failure.npm run lintand resolved any outstanding errors. Most issues can be solved by executingnpm run format