Skip to content

Conversation

@absar22
Copy link
Contributor

@absar22 absar22 commented Jul 31, 2025

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. Additionally, please include reasoning if tests have failed.

Type of change

Please select everything applicable. Please, do not delete any lines.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change requires an update to testing

Issue

  • Is this related to a specific issue? If so, please specify:

Checklist:

  • This PR is up to date with the main branch, and merge conflicts have been resolved
  • I have executed npm run test and npm run test:e2e and all tests have passed successfully or I have included details within my PR on the failure.
  • I have executed npm run lint and resolved any outstanding errors. Most issues can be solved by executing npm run format
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@DevinCLane
Copy link
Collaborator

also in general, it's best to keep working on the same pull request instead of opening another one

@DevinCLane
Copy link
Collaborator

@absar22 any updates on this?

@absar22
Copy link
Contributor Author

absar22 commented Aug 14, 2025

Please review when you get a chance.

## Issue

- [ ] Is this related to a specific issue? If so, please specify:
Resolves #532
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Resolves #532
Resolves #[add your issue number here, keep the `#`, delete this text and the `[]`]

@absar22
Copy link
Contributor Author

absar22 commented Aug 15, 2025

Hi Devin, I’ve updated the PR template with the dynamic issue placeholder as requested. Could you please re-review?

Copy link
Collaborator

@merrua merrua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change. The text is understandable to link the pr to the issue.
It looks like you have multiple commits that can be squashed into one, also can you rebase on main?

@DevinCLane DevinCLane mentioned this pull request Aug 18, 2025
13 tasks
@DevinCLane
Copy link
Collaborator

can you squash your commits @absar22 ? thanks!

@absar22
Copy link
Contributor Author

absar22 commented Oct 15, 2025

Got it, I’ll squash and push the updated commit soon. 👍

@absar22
Copy link
Contributor Author

absar22 commented Oct 15, 2025

Hi @DevinCLane ,
I’m in the middle of squashing the commits for the PR, but the rebase got messy with multiple conflicts. Would it be okay if I refork the repo and redo everything from the start on a fresh branch so I can create a clean, single commit for the PR?

@DevinCLane
Copy link
Collaborator

sure no problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants