-
Notifications
You must be signed in to change notification settings - Fork 6
Add support for Symfony 8, require at least PHP 8.1 and add PHP 8.5 to CI #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Symfony 8, require at least PHP 8.1 and add PHP 8.5 to CI #48
Conversation
|
@Toflar CI seems currently be disabled. Github is doing this because there where not any changes and disable CI with schedules after 1-2 month: psr6-symfony-http-cache-store/.github/workflows/ci.yaml Lines 10 to 11 in 9b3eb5b
You should be able reactivate it in: https://github.com/Toflar/psr6-symfony-http-cache-store/actions |
|
Re-enabled, I guess you need to push again to trigger CI? |
|
@Toflar how would you handle the deprecation errors on lowest? As I added PHP Lot of
|
|
I guess that's a wrong configuration of phpunit because those are not deprecations we can influence, are they? So update the phpunit configuration, maybe? |
|
for those test failures: my solution was to require phpunit |
Co-authored-by: David Buchmann <david@liip.ch>
|
@Toflar can you please allow this to build again? |
|
Looks like CI is blocked again. CI Need be reenabled here: https://github.com/Toflar/psr6-symfony-http-cache-store/actions This is because of psr6-symfony-http-cache-store/.github/workflows/ci.yaml Lines 10 to 11 in 9b3eb5b
|
|
Done! |
|
@Toflar by require the new phpunit bridge versions we would require to remove PHP 8.0 support? Should we investigate to still support PHP 8.0 or remove support of it? Sulus currently PHP minimum version is 8.2. |
|
8.0 is EOL. i suggest we bump to 8.1 |
.github/workflows/ci.yaml
Outdated
|
|
||
| - name: Set composer stability | ||
| if: ${{ matrix.php == '8.5' }} | ||
| run: composer config minimum-stability ${{ matrix.composer-stability }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't see anything setting the composer-stability. i don't think we need this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, think make still sense to test against pre versions. But doing now only in a 8.6 task.
|
We can bump the dependencies for sure, no need to force things for old stuff. |
dbu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me.
|
Thanks for the work guys! Is it enough to release this as 4.3.0 or would you actually prefer having a major (which could allow for more cleanup if needed?). |
|
I'm fine with releasing it as 4.3.0. |
Test current compatibility to Symfony 8.
Is required: FriendsOfSymfony/FOSHttpCache#597 as CI installs this package.