Skip to content

Conversation

@alexander-schranz
Copy link
Contributor

@alexander-schranz alexander-schranz commented Sep 22, 2025

Test current compatibility to Symfony 8.

Is required: FriendsOfSymfony/FOSHttpCache#597 as CI installs this package.

@alexander-schranz
Copy link
Contributor Author

@Toflar CI seems currently be disabled. Github is doing this because there where not any changes and disable CI with schedules after 1-2 month:

schedule:
- cron: 0 13 * * MON

You should be able reactivate it in: https://github.com/Toflar/psr6-symfony-http-cache-store/actions

@Toflar
Copy link
Owner

Toflar commented Sep 23, 2025

Re-enabled, I guess you need to push again to trigger CI?

@alexander-schranz
Copy link
Contributor Author

alexander-schranz commented Sep 26, 2025

@Toflar how would you handle the deprecation errors on lowest? As I added PHP 8.4:

Lot of Implicitly marking parameter like are shown:

Implicitly marking parameter $value as nullable is deprecated, the explicit nullable type must be used instead

@Toflar
Copy link
Owner

Toflar commented Sep 27, 2025

I guess that's a wrong configuration of phpunit because those are not deprecations we can influence, are they? So update the phpunit configuration, maybe?

@dbu
Copy link
Contributor

dbu commented Nov 29, 2025

for those test failures: my solution was to require phpunit ^9.6.29 as that avoided the deprecations that are treated as failure here. can you try that?

Co-authored-by: David Buchmann <david@liip.ch>
@dbu
Copy link
Contributor

dbu commented Dec 3, 2025

@Toflar can you please allow this to build again?

@alexander-schranz
Copy link
Contributor Author

alexander-schranz commented Dec 3, 2025

Looks like CI is blocked again. CI Need be reenabled here: https://github.com/Toflar/psr6-symfony-http-cache-store/actions

This is because of

schedule:
- cron: 0 13 * * MON
and Github after a while just disable the whole actions if schedule is enabled on a repo without any activity.

@Toflar
Copy link
Owner

Toflar commented Dec 3, 2025

Done!

@alexander-schranz alexander-schranz marked this pull request as ready for review December 3, 2025 10:02
@alexander-schranz
Copy link
Contributor Author

alexander-schranz commented Dec 3, 2025

@Toflar by require the new phpunit bridge versions we would require to remove PHP 8.0 support? Should we investigate to still support PHP 8.0 or remove support of it?

Sulus currently PHP minimum version is 8.2.

@dbu
Copy link
Contributor

dbu commented Dec 3, 2025

8.0 is EOL. i suggest we bump to 8.1
also, latest FOSHttpCache requires 8.1

@alexander-schranz alexander-schranz changed the title Add support for Symfony 8 Add support for Symfony 8, Require atleast PHP 8.1 and add PHP 8.5 to CI Dec 3, 2025

- name: Set composer stability
if: ${{ matrix.php == '8.5' }}
run: composer config minimum-stability ${{ matrix.composer-stability }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't see anything setting the composer-stability. i don't think we need this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, think make still sense to test against pre versions. But doing now only in a 8.6 task.

@Toflar
Copy link
Owner

Toflar commented Dec 3, 2025

We can bump the dependencies for sure, no need to force things for old stuff.

Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@Toflar
Copy link
Owner

Toflar commented Dec 3, 2025

Thanks for the work guys! Is it enough to release this as 4.3.0 or would you actually prefer having a major (which could allow for more cleanup if needed?).

@alexander-schranz
Copy link
Contributor Author

I'm fine with releasing it as 4.3.0.

@Toflar Toflar changed the title Add support for Symfony 8, Require atleast PHP 8.1 and add PHP 8.5 to CI Add support for Symfony 8, require at least PHP 8.1 and add PHP 8.5 to CI Dec 3, 2025
@Toflar Toflar merged commit 9d4c4b4 into Toflar:4.x Dec 3, 2025
13 checks passed
@Toflar
Copy link
Owner

Toflar commented Dec 3, 2025

@alexander-schranz alexander-schranz deleted the feature/symfony-8-upgrade branch December 3, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants