Expose dashboard as a mountable starlette app#76
Open
jklaise wants to merge 2 commits intoTkTech:26_uxfrom
Open
Expose dashboard as a mountable starlette app#76jklaise wants to merge 2 commits intoTkTech:26_uxfrom
jklaise wants to merge 2 commits intoTkTech:26_uxfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 26_ux #76 +/- ##
==========================================
+ Coverage 66.71% 66.76% +0.05%
==========================================
Files 59 59
Lines 3506 3563 +57
==========================================
+ Hits 2339 2379 +40
- Misses 1167 1184 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TkTech
reviewed
Jan 28, 2026
| name=route["name"], | ||
| ) | ||
|
|
||
| async def prefix_config(request): |
Owner
There was a problem hiding this comment.
This seems reasonable overall. We should probably pass the port through as well.
Owner
|
Overall I don't see any glaring issues - we should probably pass through the port as well, and we'll need to add a short doc page on mounting under a sub-path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for #64.
Full disclosure - I'm not familiar with React development, so for the frontend wiring I have relied on ChatGPT. There are also a bunch of formatting changes made automatically by my IDE - I re-ran
npm run lint -- --fixbut this didn't change the formatting back.Basic idea:
chancy-config.jsand expose it over the API so that the backend server can tell the (statically bundled) frontend under what prefix it is runningconfig.tsthat are used elsewhere to make all route references relative to the base path with the prefixAn example FastAPI app with the dashboard mounted as a subapp: