Skip to content

Conversation

@jakobsarthur
Copy link
Collaborator

No description provided.

Arthur Jakobs added 2 commits October 16, 2025 16:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds resource name sanitization functionality to the validation system, ensuring resource names comply with required naming patterns. The implementation provides automatic sanitization suggestions and validation to help users create valid resource names.

  • Implemented resource name sanitization methods with pattern validation ^[a-z0-9\-_.]+$
  • Added comprehensive UI integration for resource name validation with user-friendly error handling
  • Enhanced validation workflow to automatically suggest sanitized names for invalid resource names

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
trailpack/validation/standard_validator.py Added sanitize_resource_name() and validate_and_sanitize_resource_name() methods with pattern validation and automatic suggestion functionality
trailpack/validation/README.md Added documentation section explaining resource name sanitization with examples and usage patterns
trailpack/ui/streamlit_app.py Integrated resource name validation UI with real-time feedback, suggestion acceptance, and reset functionality
tests/test_schema_validation.py Added comprehensive test coverage for resource name sanitization methods and validation integration
README.md Updated workflow description to mention resource name validation feature

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@jakobsarthur
Copy link
Collaborator Author

don't merge quite yet!

@jakobsarthur jakobsarthur requested review from l-reitz and removed request for TimoDiepers October 16, 2025 15:31
@jakobsarthur jakobsarthur merged commit c084b56 into main Oct 16, 2025
@jakobsarthur jakobsarthur deleted the resource_name_cleaning branch October 16, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants