Conversation
fix os.cpus is not a function
* Add compilerOptions option * Add unit tests * Update version and changelog * Update README.md Co-Authored-By: ianschmitz <ianschmitz@gmail.com>
…Strong#175) * chore(deps): update lodash, mocha away from vulnerable versions, fix associated code and npm scripts, update tslint config * chore(config): use full es2015 instead of 2015.core+es2016 in tsconfig libs
Merge in compilerOptions prior to calling parseJsonConfigFileContent
Add support for reportFiles option
|
Hey @Timer, I was just taking create-react-app 2 for a spin using the TypeScript support. When I ejected I discovered that it wasn't using the It may be that your changes are very CRA specific. If there's changes here that are worth making in fork-ts-checker-webpack-plugin directly, we'd love to know! A fork is often a sign of a deficiency in a package; and we'd be keen to solve for that! Also, I'm imagining maintaining a fork isn't what you want to spend your time doing 😄 |
|
@johnnyreilly hey! I mentioned this in TypeStrong#165 (comment), but dropping the peer dependency is a hard requirement for us. If you're OK with dropping the peer dependency, I'm more than happy to refine this PR and send it upstream! (yes I know this breaks Yarn PnP but I'm OK with this) |
|
Ha - sorry I didn't see that comment @Timer!
Sounds good to me! @piotr-oles (who originally created
Does this approach work for you? If so I'd be more than happy to look at a PR. |
|
Yes, I'm happy with that approach and checking the version! Will PR soon! |
|
Thanks! |
|
@Timer could u summarize shortly what needs to be done? I could probably work on this |
|
I believe @johnnyreilly has a PR ready-to-go in the CRA repo, pending one final review. |
6 participants
No description provided.