chore: improve logging#2462
Open
zepfred wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds new DEBUG-level “phase started” log lines across several solver phases to make solver lifecycle logs more complete and easier to correlate with existing step/phase-end logging.
Changes:
- Log “Custom phase started” at DEBUG when a custom phase begins.
- Log “Construction Heuristic phase started” at DEBUG when CH begins.
- Log “Exhaustive Search phase started” and “Local Search phase started” at DEBUG when those phases begin.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| core/src/main/java/ai/timefold/solver/core/impl/phase/custom/DefaultCustomPhase.java | Adds a DEBUG log line at custom phase start. |
| core/src/main/java/ai/timefold/solver/core/impl/constructionheuristic/DefaultConstructionHeuristicPhase.java | Adds a DEBUG log line at construction heuristic phase start. |
| core/src/main/java/ai/timefold/solver/core/impl/exhaustivesearch/DefaultExhaustiveSearchPhase.java | Adds a DEBUG log line at exhaustive search phase start. |
| core/src/main/java/ai/timefold/solver/core/impl/localsearch/DefaultLocalSearchPhase.java | Adds a DEBUG log line at local search phase start. |
|
triceo
requested changes
Jul 6, 2026
triceo
left a comment
Collaborator
There was a problem hiding this comment.
From the provided log, you can see that this brings zero benefit.
The delay - where there is a delay - is not wrapped by any logging statement; therefore this logging is pointless.
IMO we can just close this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The PR adds additional logging information at the DEBUG level: