feat: add nullable to model config params#2452
feat: add nullable to model config params#2452diogodanielsoaresferreira wants to merge 3 commits into
Conversation
diogodanielsoaresferreira
temporarily deployed
to
internal
GitHub Actions
Inactive
diogodanielsoaresferreira
temporarily deployed
to
internal
GitHub Actions
Inactive
| * @param arrayItemType the OpenAPI schema type for array items | ||
| * @param format the data format which further specifies the schema type | ||
| * @param schemaTypeRef the OpenAPI schema type reference (used when the schema type is not a primitive type) | ||
| * @param nullable whether the parameter accepts {@code null} as a value, as defined by the OpenAPI schema |
There was a problem hiding this comment.
nullable has been removed from OpenAPI in 3.1 so not sure we should rely on it https://www.openapis.org/blog/2021/02/16/migrating-from-openapi-3-0-to-3-1-0
There was a problem hiding this comment.
just noticed that platform uses 3.1 and models use still 3.0.3 ... might be worth to address this at some point, but we might be ok to keep it as is for now. @rsynek FYI
There was a problem hiding this comment.
Thanks, I didn't know that! I took a look at the migration guide and it seems that there are other things that will also have to be changed when we migrate to 3.1. I would say to implement now as is and when we migrate, we can change everything (type arrays, examples).
mswiderski
left a comment
mswiderski
left a comment
There was a problem hiding this comment.
approving as this is valid for the OpenAPI version used by models
diogodanielsoaresferreira
temporarily deployed
to
internal
GitHub Actions
Inactive
diogodanielsoaresferreira
temporarily deployed
to
internal
GitHub Actions
Inactive
3 participants
Fixes: https://github.com/TimefoldAI/timefold-platform/issues/4992