Open
Conversation
Member
|
Hey, @VoidXWalker! Thank you, so much, for this PR. Unfortunately, MCDW is in the middle of a refactor. I can let you know when that is done and, if you're able, would you be willing to update your PR? Since 1.20.4 is not compatible with 1.20.1, making the PR as a separate branch would be preferable |
|
The PR I sent has one bug, I believe it's when you ride or interact with the horse, I didn't test it or saw any bugs but it's in the code changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated MCDungeonWeapons to Minecraft 1.20.4.
Testing suggests that the port works as intended.
Running this port requires an, at the time this pull requested is being opened, unofficial 1.20.4 build of Better Combat: ZsoltMolnarrr/BetterCombat#332